filbranden / rpms / systemd

Forked from rpms/systemd 4 years ago
Clone
b12ff75
From df5013c79d99848730abe4585dd93f77409a95c0 Mon Sep 17 00:00:00 2001
b12ff75
From: Lennart Poettering <lennart@poettering.net>
b12ff75
Date: Wed, 18 Dec 2013 05:07:34 +0100
b12ff75
Subject: [PATCH] log: don't reopen /dev/console each time we call log_open()
b12ff75
b12ff75
Instead, force reopen it only if we really really have to.
b12ff75
---
b12ff75
 src/core/main.c     | 1 +
b12ff75
 src/core/shutdown.c | 1 +
b12ff75
 src/shared/log.c    | 2 --
b12ff75
 3 files changed, 2 insertions(+), 2 deletions(-)
b12ff75
b12ff75
diff --git a/src/core/main.c b/src/core/main.c
b12ff75
index 58c3a9e..935762f 100644
b12ff75
--- a/src/core/main.c
b12ff75
+++ b/src/core/main.c
b12ff75
@@ -1347,6 +1347,7 @@ int main(int argc, char *argv[]) {
b12ff75
                 /* Running inside a container, as PID 1 */
b12ff75
                 arg_running_as = SYSTEMD_SYSTEM;
b12ff75
                 log_set_target(LOG_TARGET_CONSOLE);
b12ff75
+                log_close_console(); /* force reopen of /dev/console */
b12ff75
                 log_open();
b12ff75
 
b12ff75
                 /* For the later on, see above... */
b12ff75
diff --git a/src/core/shutdown.c b/src/core/shutdown.c
b12ff75
index ea02b60..5e0f3ce 100644
b12ff75
--- a/src/core/shutdown.c
b12ff75
+++ b/src/core/shutdown.c
b12ff75
@@ -155,6 +155,7 @@ int main(int argc, char *argv[]) {
b12ff75
 
b12ff75
         log_parse_environment();
b12ff75
         log_set_target(LOG_TARGET_CONSOLE); /* syslog will die if not gone yet */
b12ff75
+        log_close_console(); /* force reopen of /dev/console */
b12ff75
         log_open();
b12ff75
 
b12ff75
         umask(0022);
b12ff75
diff --git a/src/shared/log.c b/src/shared/log.c
b12ff75
index 8f4995a..bd918fb 100644
b12ff75
--- a/src/shared/log.c
b12ff75
+++ b/src/shared/log.c
b12ff75
@@ -272,8 +272,6 @@ int log_open(void) {
b12ff75
         log_close_journal();
b12ff75
         log_close_syslog();
b12ff75
 
b12ff75
-        /* Get the real /dev/console if we are PID=1, hence reopen */
b12ff75
-        log_close_console();
b12ff75
         return log_open_console();
b12ff75
 }
b12ff75