From 1b7c0ee13fc28a387981ae3086b40620f49831dd Mon Sep 17 00:00:00 2001

From: =?UTF-8?q?=E5=8D=9C=E9=83=A8=E6=98=8C=E5=B9=B3?=

 <shyouhei@ruby-lang.org>

Date: Thu, 23 Jan 2020 15:33:42 +0900

Subject: [PATCH 1/2] brace the fact that lchmod(2) can EOPNOTSUPP

Musl libc has this function as a tiny wrapper of fchmodat(3posix).  On

the other hand Linux kernel does not support changing modes of a symlink.

The operation always fails with EOPNOTSUPP.  This fchmodat behaviour is

defined in POSIX.  We have to take care of such exceptions.

---

 lib/fileutils.rb               |  3 ++-

 test/pathname/test_pathname.rb |  2 +-

 test/ruby/test_notimp.rb       | 19 ++++++++++++-------

 3 files changed, 15 insertions(+), 9 deletions(-)

diff --git a/lib/fileutils.rb b/lib/fileutils.rb

index 8981ef98e8..6332fcd6f1 100644

--- a/lib/fileutils.rb

+++ b/lib/fileutils.rb

@@ -1320,6 +1320,7 @@ def chmod(mode)

       else

         File.chmod mode, path()

       end

+    rescue Errno::EOPNOTSUPP

     end

     def chown(uid, gid)

@@ -1411,7 +1412,7 @@ def copy_metadata(path)

       if st.symlink?

         begin

           File.lchmod mode, path

-        rescue NotImplementedError

+        rescue NotImplementedError, Errno::EOPNOTSUPP

         end

       else

         File.chmod mode, path

diff --git a/test/pathname/test_pathname.rb b/test/pathname/test_pathname.rb

index f8e4937802..750fabf039 100644

--- a/test/pathname/test_pathname.rb

+++ b/test/pathname/test_pathname.rb

@@ -824,7 +824,7 @@ def test_lchmod

       old = path.lstat.mode

       begin

         path.lchmod(0444)

-      rescue NotImplementedError

+      rescue NotImplementedError, Errno::EOPNOTSUPP

         next

       end

       assert_equal(0444, path.lstat.mode & 0777)

diff --git a/test/ruby/test_notimp.rb b/test/ruby/test_notimp.rb

index ddebb657bf..daa5a82d7b 100644

--- a/test/ruby/test_notimp.rb

+++ b/test/ruby/test_notimp.rb

@@ -13,11 +13,11 @@ def test_respond_to_fork

   def test_respond_to_lchmod

     assert_include(File.methods, :lchmod)

-    if /linux/ =~ RUBY_PLATFORM

-      assert_equal(false, File.respond_to?(:lchmod))

-    end

-    if /freebsd/ =~ RUBY_PLATFORM

+    case RUBY_PLATFORM

+    when /freebsd/, /linux-musl/

       assert_equal(true, File.respond_to?(:lchmod))

+    when /linux/

+      assert_equal(false, File.respond_to?(:lchmod))

     end

   end

@@ -57,9 +57,14 @@ def test_call_lchmod

         File.open(f, "w") {}

         File.symlink f, g

         newmode = 0444

-        File.lchmod newmode, "#{d}/g"

-        snew = File.lstat(g)

-        assert_equal(newmode, snew.mode & 0777)

+        begin

+          File.lchmod newmode, "#{d}/g"

+        rescue Errno::EOPNOTSUPP

+          skip $!

+        else

+          snew = File.lstat(g)

+          assert_equal(newmode, snew.mode & 0777)

+        end

       }

     end

   end

-- 

2.26.2