|
 |
e6583ae |
From patchwork Mon Sep 30 05:59:25 2019
|
|
|
e6583ae |
Content-Type: text/plain; charset="utf-8"
|
|
|
e6583ae |
MIME-Version: 1.0
|
|
|
e6583ae |
Content-Transfer-Encoding: 7bit
|
|
|
e6583ae |
X-Patchwork-Submitter: Masahiro Yamada <yamada.masahiro@socionext.com>
|
|
|
e6583ae |
X-Patchwork-Id: 1132459
|
|
|
e6583ae |
Return-Path: <SRS0=rUXN=XZ=vger.kernel.org=linux-kernel-owner@kernel.org>
|
|
|
e6583ae |
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
|
|
|
e6583ae |
by smtp.lore.kernel.org (Postfix) with ESMTP id DF215C4360C
|
|
|
e6583ae |
for <linux-kernel@archiver.kernel.org>; Mon, 30 Sep 2019 06:02:56 +0000 (UTC)
|
|
|
e6583ae |
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
|
|
|
e6583ae |
by mail.kernel.org (Postfix) with ESMTP id B032A20815
|
|
|
e6583ae |
for <linux-kernel@archiver.kernel.org>; Mon, 30 Sep 2019 06:02:56 +0000 (UTC)
|
|
|
e6583ae |
Authentication-Results: mail.kernel.org;
|
|
|
e6583ae |
dkim=pass (2048-bit key) header.d=nifty.com header.i=@nifty.com
|
|
|
e6583ae |
header.b="sVJyT1RO"
|
|
|
e6583ae |
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
|
|
|
e6583ae |
id S1729635AbfI3GCz (ORCPT
|
|
|
e6583ae |
<rfc822;linux-kernel@archiver.kernel.org>);
|
|
|
e6583ae |
Mon, 30 Sep 2019 02:02:55 -0400
|
|
|
e6583ae |
Received: from conuserg-10.nifty.com ([210.131.2.77]:65305 "EHLO
|
|
|
e6583ae |
conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
|
|
|
e6583ae |
with ESMTP id S1726121AbfI3GCz (ORCPT
|
|
|
e6583ae |
<rfc822;linux-kernel@vger.kernel.org>);
|
|
|
e6583ae |
Mon, 30 Sep 2019 02:02:55 -0400
|
|
|
e6583ae |
Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp
|
|
|
e6583ae |
[153.142.97.92]) (authenticated)
|
|
|
e6583ae |
by conuserg-10.nifty.com with ESMTP id x8U60ANM011158;
|
|
|
e6583ae |
Mon, 30 Sep 2019 15:00:10 +0900
|
|
|
e6583ae |
DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com x8U60ANM011158
|
|
|
e6583ae |
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com;
|
|
|
e6583ae |
s=dec2015msa; t=1569823213;
|
|
|
e6583ae |
bh=31RHoPop8t0h2pCPRnwABR+VMelvfuLJ6qwFWQxvRAk=;
|
|
|
e6583ae |
h=From:To:Cc:Subject:Date:From;
|
|
|
e6583ae |
b=sVJyT1ROU+6mzkZMRTb0M214/0QcKkmxRbNgDwh2q1TPJpEjPLOoE+y1jkVndgyce
|
|
|
e6583ae |
qBfr7v3nYiN5WSsx5xTwPYvHohsWcSS3AWwyVRw8Kxjd0CGrX8l5WcF76SmCvJPLCB
|
|
|
e6583ae |
wLRZ7C1/Z/zv9v8AVlB2BGhDmSvNQJ9bvuGi42d+JbBXGDfg0HZGGHEj7yDDLBV9nW
|
|
|
e6583ae |
EZkTGzP6wtIdqgD6DM5Lj4LA7FnlzH8Ocy6yp5agIZ7tdaiVh4E+Xb97KFsLgRin/o
|
|
|
e6583ae |
kTPCap5ub1TziurVW+1pbzwH+G3TNVeY+yJdYcAQRFzXXOrTa7s5zIJUtObrYVGCA2
|
|
|
e6583ae |
ctH5uaN1kjx1g==
|
|
|
e6583ae |
X-Nifty-SrcIP: [153.142.97.92]
|
|
|
e6583ae |
From: Masahiro Yamada <yamada.masahiro@socionext.com>
|
|
|
e6583ae |
To: linux-arm-kernel@lists.infradead.org,
|
|
|
e6583ae |
Russell King <rmk+kernel@armlinux.org.uk>
|
|
|
e6583ae |
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
|
|
|
e6583ae |
Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
|
|
|
e6583ae |
Nick Desaulniers <ndesaulniers@google.com>,
|
|
|
e6583ae |
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
|
|
|
e6583ae |
Masahiro Yamada <yamada.masahiro@socionext.com>,
|
|
|
e6583ae |
Julien Thierry <julien.thierry.kdev@gmail.com>,
|
|
|
e6583ae |
Russell King <linux@armlinux.org.uk>,
|
|
|
e6583ae |
Stefan Agner <stefan@agner.ch>,
|
|
|
e6583ae |
Thomas Gleixner <tglx@linutronix.de>,
|
|
|
e6583ae |
Vincent Whitchurch <vincent.whitchurch@axis.com>,
|
|
|
e6583ae |
linux-kernel@vger.kernel.org
|
|
|
e6583ae |
Subject: [PATCH] ARM: fix __get_user_check() in case uaccess_* calls are not
|
|
|
e6583ae |
inlined
|
|
|
e6583ae |
Date: Mon, 30 Sep 2019 14:59:25 +0900
|
|
|
e6583ae |
Message-Id: <20190930055925.25842-1-yamada.masahiro@socionext.com>
|
|
|
e6583ae |
X-Mailer: git-send-email 2.17.1
|
|
|
e6583ae |
Sender: linux-kernel-owner@vger.kernel.org
|
|
|
e6583ae |
Precedence: bulk
|
|
|
e6583ae |
List-ID: <linux-kernel.vger.kernel.org>
|
|
|
e6583ae |
X-Mailing-List: linux-kernel@vger.kernel.org
|
|
|
e6583ae |
|
|
|
e6583ae |
KernelCI reports that bcm2835_defconfig is no longer booting since
|
|
|
e6583ae |
commit ac7c3e4ff401 ("compiler: enable CONFIG_OPTIMIZE_INLINING
|
|
|
e6583ae |
forcibly"):
|
|
|
e6583ae |
|
|
|
e6583ae |
https://lkml.org/lkml/2019/9/26/825
|
|
|
e6583ae |
|
|
|
e6583ae |
I also received a regression report from Nicolas Saenz Julienne:
|
|
|
e6583ae |
|
|
|
e6583ae |
https://lkml.org/lkml/2019/9/27/263
|
|
|
e6583ae |
|
|
|
e6583ae |
This problem has cropped up on arch/arm/config/bcm2835_defconfig
|
|
|
e6583ae |
because it enables CONFIG_CC_OPTIMIZE_FOR_SIZE. The compiler tends
|
|
|
e6583ae |
to prefer not inlining functions with -Os. I was able to reproduce
|
|
|
e6583ae |
it with other boards and defconfig files by manually enabling
|
|
|
e6583ae |
CONFIG_CC_OPTIMIZE_FOR_SIZE.
|
|
|
e6583ae |
|
|
|
e6583ae |
The __get_user_check() specifically uses r0, r1, r2 registers.
|
|
|
e6583ae |
So, uaccess_save_and_enable() and uaccess_restore() must be inlined
|
|
|
e6583ae |
in order to avoid those registers being overwritten in the callees.
|
|
|
e6583ae |
|
|
|
e6583ae |
Prior to commit 9012d011660e ("compiler: allow all arches to enable
|
|
|
e6583ae |
CONFIG_OPTIMIZE_INLINING"), the 'inline' marker was always enough for
|
|
|
e6583ae |
inlining functions, except on x86.
|
|
|
e6583ae |
|
|
|
e6583ae |
Since that commit, all architectures can enable CONFIG_OPTIMIZE_INLINING.
|
|
|
e6583ae |
So, __always_inline is now the only guaranteed way of forcible inlining.
|
|
|
e6583ae |
|
|
|
e6583ae |
I want to keep as much compiler's freedom as possible about the inlining
|
|
|
e6583ae |
decision. So, I changed the function call order instead of adding
|
|
|
e6583ae |
__always_inline around.
|
|
|
e6583ae |
|
|
|
e6583ae |
Call uaccess_save_and_enable() before assigning the __p ("r0"), and
|
|
|
e6583ae |
uaccess_restore() after evacuating the __e ("r0").
|
|
|
e6583ae |
|
|
|
e6583ae |
Fixes: 9012d011660e ("compiler: allow all arches to enable CONFIG_OPTIMIZE_INLINING")
|
|
|
e6583ae |
Reported-by: "kernelci.org bot" <bot@kernelci.org>
|
|
|
e6583ae |
Reported-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
|
|
|
e6583ae |
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
|
|
|
e6583ae |
Acked-by: Arnd Bergmann <arnd@arndb.de>
|
|
|
e6583ae |
Tested-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
|
|
|
e6583ae |
Tested-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
|
|
|
e6583ae |
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
|
|
|
e6583ae |
---
|
|
|
e6583ae |
|
|
|
e6583ae |
arch/arm/include/asm/uaccess.h | 8 +++++---
|
|
|
e6583ae |
1 file changed, 5 insertions(+), 3 deletions(-)
|
|
|
e6583ae |
|
|
|
e6583ae |
diff --git a/arch/arm/include/asm/uaccess.h b/arch/arm/include/asm/uaccess.h
|
|
|
e6583ae |
index 303248e5b990..559f252d7e3c 100644
|
|
|
e6583ae |
--- a/arch/arm/include/asm/uaccess.h
|
|
|
e6583ae |
+++ b/arch/arm/include/asm/uaccess.h
|
|
|
e6583ae |
@@ -191,11 +191,12 @@ extern int __get_user_64t_4(void *);
|
|
|
e6583ae |
#define __get_user_check(x, p) \
|
|
|
e6583ae |
({ \
|
|
|
e6583ae |
unsigned long __limit = current_thread_info()->addr_limit - 1; \
|
|
|
e6583ae |
+ unsigned int __ua_flags = uaccess_save_and_enable(); \
|
|
|
e6583ae |
register typeof(*(p)) __user *__p asm("r0") = (p); \
|
|
|
e6583ae |
register __inttype(x) __r2 asm("r2"); \
|
|
|
e6583ae |
register unsigned long __l asm("r1") = __limit; \
|
|
|
e6583ae |
register int __e asm("r0"); \
|
|
|
e6583ae |
- unsigned int __ua_flags = uaccess_save_and_enable(); \
|
|
|
e6583ae |
+ unsigned int __err; \
|
|
|
e6583ae |
switch (sizeof(*(__p))) { \
|
|
|
e6583ae |
case 1: \
|
|
|
e6583ae |
if (sizeof((x)) >= 8) \
|
|
|
e6583ae |
@@ -223,9 +224,10 @@ extern int __get_user_64t_4(void *);
|
|
|
e6583ae |
break; \
|
|
|
e6583ae |
default: __e = __get_user_bad(); break; \
|
|
|
e6583ae |
} \
|
|
|
e6583ae |
- uaccess_restore(__ua_flags); \
|
|
|
e6583ae |
+ __err = __e; \
|
|
|
e6583ae |
x = (typeof(*(p))) __r2; \
|
|
|
e6583ae |
- __e; \
|
|
|
e6583ae |
+ uaccess_restore(__ua_flags); \
|
|
|
e6583ae |
+ __err; \
|
|
|
e6583ae |
})
|
|
|
e6583ae |
|
|
|
e6583ae |
#define get_user(x, p) \
|