lkundrak / rpms / chrony

Forked from rpms/chrony 4 years ago
Clone
8cd2de8
commit c6fdeeb6bb0b17dc28c19ae492c4a1c498e54ea3
8cd2de8
Author: Miroslav Lichvar <mlichvar@redhat.com>
8cd2de8
Date:   Wed Jul 31 15:02:09 2013 +0200
8cd2de8
8cd2de8
    Don't send uninitialized data in command replies
8cd2de8
    
8cd2de8
    The RPY_SUBNETS_ACCESSED and RPY_CLIENT_ACCESSES command replies can
8cd2de8
    contain uninitalized data from stack when the client logging is disabled
8cd2de8
    or a bad subnet is requested. These commands were never used by chronyc
8cd2de8
    and they require the client to be authenticated since version 1.25.
8cd2de8
8cd2de8
diff --git a/cmdmon.c b/cmdmon.c
8cd2de8
index e4f7349..6d6e32b 100644
8cd2de8
--- a/cmdmon.c
8cd2de8
+++ b/cmdmon.c
8cd2de8
@@ -1513,9 +1513,11 @@ handle_subnets_accessed(CMD_Request *rx_message, CMD_Reply *tx_message)
8cd2de8
         break;
8cd2de8
       case CLG_BADSUBNET:
8cd2de8
         tx_message->status = htons(STT_BADSUBNET);
8cd2de8
+        tx_message->data.subnets_accessed.n_subnets = htonl(0);
8cd2de8
         return;
8cd2de8
       case CLG_INACTIVE:
8cd2de8
         tx_message->status = htons(STT_INACTIVE);
8cd2de8
+        tx_message->data.subnets_accessed.n_subnets = htonl(0);
8cd2de8
         return;
8cd2de8
       default:
8cd2de8
         assert(0);
8cd2de8
@@ -1569,6 +1571,7 @@ handle_client_accesses(CMD_Request *rx_message, CMD_Reply *tx_message)
8cd2de8
         break;
8cd2de8
       case CLG_INACTIVE:
8cd2de8
         tx_message->status = htons(STT_INACTIVE);
8cd2de8
+        tx_message->data.client_accesses.n_clients = htonl(0);
8cd2de8
         return;
8cd2de8
       default:
8cd2de8
         assert(0);