ngompa / rpms / grub2

Forked from rpms/grub2 6 years ago
Clone
e30274a
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
e30274a
From: Peter Jones <pjones@redhat.com>
e30274a
Date: Fri, 14 Sep 2018 13:34:55 -0400
e30274a
Subject: [PATCH] x86-efi: Use bounce buffers for reading to addresses > 4GB
e30274a
e30274a
Lots of machines apparently can't DMA correctly above 4GB during UEFI,
e30274a
so use bounce buffers for the initramfs read.
e30274a
e30274a
Signed-off-by: Peter Jones <pjones@redhat.com>
e30274a
---
e30274a
 grub-core/loader/i386/efi/linux.c | 52 +++++++++++++++++++++++++++++++++------
e30274a
 1 file changed, 45 insertions(+), 7 deletions(-)
e30274a
e30274a
diff --git a/grub-core/loader/i386/efi/linux.c b/grub-core/loader/i386/efi/linux.c
e30274a
index 851bce77f12..06d19b9fc0e 100644
e30274a
--- a/grub-core/loader/i386/efi/linux.c
e30274a
+++ b/grub-core/loader/i386/efi/linux.c
e30274a
@@ -36,11 +36,16 @@ static grub_dl_t my_mod;
e30274a
 static int loaded;
e30274a
 static void *kernel_mem;
e30274a
 static grub_uint64_t kernel_size;
e30274a
-static grub_uint8_t *initrd_mem;
e30274a
+static void *initrd_mem;
e30274a
 static grub_uint32_t handover_offset;
e30274a
 struct linux_kernel_params *params;
e30274a
 static char *linux_cmdline;
e30274a
 
e30274a
+#define MIN(a, b) \
e30274a
+  ({ typeof (a) _a = (a); \
e30274a
+     typeof (b) _b = (b); \
e30274a
+     _a < _b ? _a : _b; })
e30274a
+
e30274a
 #define BYTES_TO_PAGES(bytes)   (((bytes) + 0xfff) >> 12)
e30274a
 
e30274a
 static grub_err_t
e30274a
@@ -74,6 +79,44 @@ grub_linuxefi_unload (void)
e30274a
   return GRUB_ERR_NONE;
e30274a
 }
e30274a
 
e30274a
+#define BOUNCE_BUFFER_MAX 0x10000000ull
e30274a
+
e30274a
+static grub_ssize_t
e30274a
+read(grub_file_t file, grub_uint8_t *bufp, grub_size_t len)
e30274a
+{
e30274a
+  grub_ssize_t bufpos = 0;
e30274a
+  static grub_size_t bbufsz = 0;
e30274a
+  static char *bbuf = NULL;
e30274a
+
e30274a
+  if (bbufsz == 0)
e30274a
+    bbufsz = MIN(BOUNCE_BUFFER_MAX, len);
e30274a
+
e30274a
+  while (!bbuf && bbufsz)
e30274a
+    {
e30274a
+      bbuf = grub_malloc(bbufsz);
e30274a
+      if (!bbuf)
e30274a
+	bbufsz >>= 1;
e30274a
+    }
e30274a
+  if (!bbuf)
e30274a
+    grub_error (GRUB_ERR_OUT_OF_MEMORY, N_("cannot allocate bounce buffer"));
e30274a
+
e30274a
+  while (bufpos < (long long)len)
e30274a
+    {
e30274a
+      grub_ssize_t sz;
e30274a
+
e30274a
+      sz = grub_file_read (file, bbuf, MIN(bbufsz, len - bufpos));
e30274a
+      if (sz < 0)
e30274a
+	return sz;
e30274a
+      if (sz == 0)
e30274a
+	break;
e30274a
+
e30274a
+      grub_memcpy(bufp + bufpos, bbuf, sz);
e30274a
+      bufpos += sz;
e30274a
+    }
e30274a
+
e30274a
+  return bufpos;
e30274a
+}
e30274a
+
e30274a
 static grub_err_t
e30274a
 grub_cmd_initrd (grub_command_t cmd __attribute__ ((unused)),
e30274a
                  int argc, char *argv[])
e30274a
@@ -128,7 +171,7 @@ grub_cmd_initrd (grub_command_t cmd __attribute__ ((unused)),
e30274a
   for (i = 0; i < nfiles; i++)
e30274a
     {
e30274a
       grub_ssize_t cursize = grub_file_size (files[i]);
e30274a
-      if (grub_file_read (files[i], ptr, cursize) != cursize)
e30274a
+      if (read (files[i], ptr, cursize) != cursize)
e30274a
         {
e30274a
           if (!grub_errno)
e30274a
             grub_error (GRUB_ERR_FILE_READ_ERROR, N_("premature end of file %s"),
e30274a
@@ -156,11 +199,6 @@ grub_cmd_initrd (grub_command_t cmd __attribute__ ((unused)),
e30274a
   return grub_errno;
e30274a
 }
e30274a
 
e30274a
-#define MIN(a, b) \
e30274a
-  ({ typeof (a) _a = (a); \
e30274a
-     typeof (b) _b = (b); \
e30274a
-     _a < _b ? _a : _b; })
e30274a
-
e30274a
 static grub_err_t
e30274a
 grub_cmd_linux (grub_command_t cmd __attribute__ ((unused)),
e30274a
 		int argc, char *argv[])