From 140ee1de89e2acc040562f28b0ff6a1669996725 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Dec 03 2019 12:00:36 +0000 Subject: brp-mangle-shebangs: do not stat / touch files needlessly Run "stat" to get mtime, and "touch -d $saved_mtime" only if we indeed modify file's shebang. Signed-off-by: Denys Vlasenko --- diff --git a/brp-mangle-shebangs b/brp-mangle-shebangs index 11809b4..98990c0 100755 --- a/brp-mangle-shebangs +++ b/brp-mangle-shebangs @@ -92,12 +92,12 @@ while IFS= read -r line; do echo "$path" | grep -q -E -f "$exclude_files_from" && continue fi - ts=$(stat -c %y "$f") read shebang_line < "$f" orig_shebang="${shebang_line#\#!}" if [ "$orig_shebang" = "$shebang_line" ]; then echo >&2 "*** WARNING: $f is executable but has no shebang, removing executable bit" + ts=$(stat -c %y "$f") chmod -x "$f" touch -d "$ts" "$f" continue @@ -114,6 +114,7 @@ while IFS= read -r line; do if [ -z "$shebang" ]; then echo >&2 "*** WARNING: $f is executable but has empty shebang, removing executable bit" + ts=$(stat -c %y "$f") chmod -x "$f" touch -d "$ts" "$f" continue @@ -145,11 +146,12 @@ while IFS= read -r line; do echo >&2 "*** ERROR: ambiguous python shebang in $path: #!$orig_shebang. Change it to python3 (or python2) explicitly." fail=1 elif [ "#!$shebang" != "#!$orig_shebang" ]; then - sed -i -e "1c #!$shebang" "$f" echo "mangling shebang in $path from $orig_shebang to #!$shebang" + ts=$(stat -c %y "$f") + sed -i -e "1c #!$shebang" "$f" + touch -d "$ts" "$f" fi - touch -d "$ts" "$f" done exit $fail