|
 |
4979be5 |
From 9b42fce32bff25e0569581f76f532b9d57865aef Mon Sep 17 00:00:00 2001
|
|
|
4979be5 |
From: =?UTF-8?q?V=C3=ADt=20Ondruch?= <vondruch@redhat.com>
|
|
|
4979be5 |
Date: Mon, 27 Jul 2020 14:56:05 +0200
|
|
|
4979be5 |
Subject: [PATCH] Timeout the test_bug_reporter_add witout raising error.
|
|
|
4979be5 |
|
|
|
4979be5 |
While timeouting the threads might be still good idea, it does not seems
|
|
|
4979be5 |
the timeout impacts the TestBugReporter#test_bug_reporter_add result,
|
|
|
4979be5 |
because the output of the child process has been already collected
|
|
|
4979be5 |
earlier.
|
|
|
4979be5 |
|
|
|
4979be5 |
It seems that when the system is under heavy load, the thread might not
|
|
|
4979be5 |
be sheduled to finish its processing. Even finishing the child process
|
|
|
4979be5 |
might take tens of seconds and therefore the test case finish might take
|
|
|
4979be5 |
a while.
|
|
|
4979be5 |
---
|
|
|
4979be5 |
test/-ext-/bug_reporter/test_bug_reporter.rb | 2 +-
|
|
|
4979be5 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
4979be5 |
|
|
|
4979be5 |
diff --git a/test/-ext-/bug_reporter/test_bug_reporter.rb b/test/-ext-/bug_reporter/test_bug_reporter.rb
|
|
|
4979be5 |
index 628fcd0340..2c677cc8a7 100644
|
|
|
4979be5 |
--- a/test/-ext-/bug_reporter/test_bug_reporter.rb
|
|
|
4979be5 |
+++ b/test/-ext-/bug_reporter/test_bug_reporter.rb
|
|
|
f2899ee |
@@ -28,7 +28,7 @@ def test_bug_reporter_add
|
|
|
4979be5 |
"-C", tmpdir]
|
|
|
f2899ee |
args.push("--yjit") if yjit_enabled? # We want the printed description to match this process's RUBY_DESCRIPTION
|
|
|
f2899ee |
stdin = "#{no_core}register_sample_bug_reporter(12345); Process.kill :SEGV, $$"
|
|
|
4979be5 |
- assert_in_out_err(args, stdin, [], expected_stderr, encoding: "ASCII-8BIT")
|
|
|
4979be5 |
+ assert_in_out_err(args, stdin, [], expected_stderr, encoding: "ASCII-8BIT", timeout_error: nil)
|
|
|
4979be5 |
ensure
|
|
|
4979be5 |
FileUtils.rm_rf(tmpdir) if tmpdir
|
|
|
4979be5 |
end
|