c2d5d21
From f1994bc91688889e4b7ffbca687739023f2a815b Mon Sep 17 00:00:00 2001
c2d5d21
From: Lee Duncan <lduncan@suse.com>
c2d5d21
Date: Fri, 8 Mar 2013 11:11:13 -0800
c2d5d21
Subject: iscsiadm: return error when login fails
c2d5d21
c2d5d21
When login fails because there are too many sessions we should be
c2d5d21
returning an error code so that userland is aware that something
c2d5d21
is amiss.
c2d5d21
c2d5d21
Signed-off-by: Hannes Reinecke <hare@suse.com>
c2d5d21
Signed-off-by: Lee Duncan <lduncan@suse.com>
c2d5d21
---
c2d5d21
 usr/session_mgmt.c | 4 ++--
c2d5d21
 1 file changed, 2 insertions(+), 2 deletions(-)
c2d5d21
c2d5d21
diff --git a/usr/session_mgmt.c b/usr/session_mgmt.c
c2d5d21
index ec1f43a..0b7373f 100644
c2d5d21
--- a/usr/session_mgmt.c
c2d5d21
+++ b/usr/session_mgmt.c
c2d5d21
@@ -178,12 +178,12 @@ int iscsi_login_portal(void *data, struct list_head *list, struct node_rec *rec)
c2d5d21
 		goto done;
c2d5d21
 	}
c2d5d21
 	if (session_count >= rec->session.nr_sessions) {
c2d5d21
-		log_debug(1, "%s: %d session%s requested, but %d "
c2d5d21
+		log_warning("%s: %d session%s requested, but %d "
c2d5d21
 			  "already present.",
c2d5d21
 			  rec->iface.name, rec->session.nr_sessions,
c2d5d21
 			  rec->session.nr_sessions == 1 ? "" : "s",
c2d5d21
 			  session_count);
c2d5d21
-		rc = 0;
c2d5d21
+		rc = ISCSI_ERR_SESS_EXISTS;
c2d5d21
 		goto done;
c2d5d21
 	}
c2d5d21
 
c2d5d21
-- 
c2d5d21
1.8.1.4
c2d5d21