|
 |
929689a |
From 1f7fd558c4da3c92bdae67646504eaec16e6081f Mon Sep 17 00:00:00 2001
|
|
|
929689a |
From: Chris Leech <cleech@redhat.com>
|
|
|
929689a |
Date: Thu, 12 Feb 2015 16:01:48 -0800
|
|
|
929689a |
Subject: [PATCH] honor all requested delays in iscsi_sched_ev_context
|
|
|
929689a |
|
|
|
929689a |
The session_conn_uio_poll function reschedules itself in the same was as
|
|
|
929689a |
session_conn_poll, by calling iscsi_sched_ev_context with a delay. That
|
|
|
929689a |
delay needs to not be ignored.
|
|
|
929689a |
|
|
|
929689a |
Actually, most all of the cases in iscsi_sched_ev_context can use
|
|
|
929689a |
actor_timer to ensure any passed delay argument is honored (even if most
|
|
|
929689a |
of them are passed as 0).
|
|
|
929689a |
|
|
|
929689a |
Signed-off-by: Chris Leech <cleech@redhat.com>
|
|
|
929689a |
---
|
|
|
929689a |
usr/initiator.c | 20 ++++++++------------
|
|
|
929689a |
1 file changed, 8 insertions(+), 12 deletions(-)
|
|
|
929689a |
|
|
|
929689a |
diff --git a/usr/initiator.c b/usr/initiator.c
|
|
|
929689a |
index 3b39c5d..93a3c27 100644
|
|
|
929689a |
--- a/usr/initiator.c
|
|
|
929689a |
+++ b/usr/initiator.c
|
|
|
929689a |
@@ -1800,9 +1800,8 @@ static int iscsi_sched_ev_context(struct iscsi_ev_context *ev_context,
|
|
|
929689a |
ev_context->conn = conn;
|
|
|
929689a |
switch (event) {
|
|
|
929689a |
case EV_CONN_RECV_PDU:
|
|
|
929689a |
- actor_init(&ev_context->actor, session_conn_recv_pdu,
|
|
|
929689a |
- ev_context);
|
|
|
929689a |
- actor_schedule(&ev_context->actor);
|
|
|
929689a |
+ actor_timer(&ev_context->actor, tmo,
|
|
|
929689a |
+ session_conn_recv_pdu, ev_context);
|
|
|
929689a |
break;
|
|
|
929689a |
case EV_CONN_ERROR:
|
|
|
929689a |
error = *(enum iscsi_err *)ev_context->data;
|
|
|
929689a |
@@ -1820,27 +1819,24 @@ static int iscsi_sched_ev_context(struct iscsi_ev_context *ev_context,
|
|
|
929689a |
actor_schedule(&ev_context->actor);
|
|
|
929689a |
break;
|
|
|
929689a |
case EV_CONN_LOGIN:
|
|
|
929689a |
- actor_init(&ev_context->actor, session_conn_process_login,
|
|
|
929689a |
- ev_context);
|
|
|
929689a |
- actor_schedule(&ev_context->actor);
|
|
|
929689a |
+ actor_timer(&ev_context->actor, tmo,
|
|
|
929689a |
+ session_conn_process_login, ev_context);
|
|
|
929689a |
break;
|
|
|
929689a |
case EV_CONN_POLL:
|
|
|
929689a |
actor_timer(&ev_context->actor, tmo,
|
|
|
929689a |
session_conn_poll, ev_context);
|
|
|
929689a |
break;
|
|
|
929689a |
case EV_UIO_POLL:
|
|
|
929689a |
- actor_init(&ev_context->actor, session_conn_uio_poll,
|
|
|
929689a |
- ev_context);
|
|
|
929689a |
- actor_schedule(&ev_context->actor);
|
|
|
929689a |
+ actor_timer(&ev_context->actor, tmo,
|
|
|
929689a |
+ session_conn_uio_poll, ev_context);
|
|
|
929689a |
break;
|
|
|
929689a |
case EV_CONN_LOGOUT_TIMER:
|
|
|
929689a |
actor_timer(&ev_context->actor, tmo,
|
|
|
929689a |
iscsi_logout_timedout, ev_context);
|
|
|
929689a |
break;
|
|
|
929689a |
case EV_CONN_STOP:
|
|
|
929689a |
- actor_init(&ev_context->actor, iscsi_stop,
|
|
|
929689a |
- ev_context);
|
|
|
929689a |
- actor_schedule(&ev_context->actor);
|
|
|
929689a |
+ actor_timer(&ev_context->actor, tmo,
|
|
|
929689a |
+ iscsi_stop, ev_context);
|
|
|
929689a |
break;
|
|
|
929689a |
default:
|
|
|
929689a |
log_error("Invalid event type %d.", event);
|
|
|
929689a |
--
|
|
|
929689a |
2.1.0
|
|
|
929689a |
|