Mike Christie 3949e15
diff -aurp open-iscsi-2.0-872-rc4-bnx2i.base/etc/iscsid.conf open-iscsi-2.0-872-rc4-bnx2i.build/etc/iscsid.conf
Mike Christie 3949e15
--- open-iscsi-2.0-872-rc4-bnx2i.base/etc/iscsid.conf	2011-08-14 16:33:53.000000000 -0500
Mike Christie 3949e15
+++ open-iscsi-2.0-872-rc4-bnx2i.build/etc/iscsid.conf	2011-08-14 16:37:47.000000000 -0500
5ebdd59
@@ -17,10 +17,10 @@
5ebdd59
 # maintainers.
5ebdd59
 #
5ebdd59
 # Default for Fedora and RHEL. (uncomment to activate).
5ebdd59
-# iscsid.startup = /etc/rc.d/init.d/iscsid force-start
5ebdd59
+iscsid.startup = /etc/rc.d/init.d/iscsid force-start
5ebdd59
 # 
5ebdd59
 # Default for upstream open-iscsi scripts (uncomment to activate).
5ebdd59
-iscsid.startup = /sbin/iscsid
5ebdd59
+# iscsid.startup = /sbin/iscsid
5ebdd59
 
5ebdd59
 
1c8eda8
 #############################
1c8eda8
@@ -36,8 +36,8 @@ iscsid.startup = /sbin/iscsid
5ebdd59
 # To request that the iscsi initd scripts startup a session set to "automatic".
5ebdd59
 # node.startup = automatic
5ebdd59
 #
5ebdd59
-# To manually startup the session set to "manual". The default is manual.
5ebdd59
-node.startup = manual
5ebdd59
+# To manually startup the session set to "manual". The default is automatic.
5ebdd59
+node.startup = automatic
5ebdd59
 
Mike Christie 3949e15
 # For "automatic" startup nodes, setting this to "Yes" will try logins on each
Mike Christie 3949e15
 # available iface until one succeeds, and then stop.  The default "No" will try
Mike Christie 3949e15
@@ -259,28 +259,27 @@ node.conn[0].iscsi.MaxXmitDataSegmentLen
5ebdd59
 discovery.sendtargets.iscsi.MaxRecvDataSegmentLength = 32768
5ebdd59
 
5ebdd59
 # To allow the targets to control the setting of the digest checking,
5ebdd59
-# with the initiator requesting a preference of enabling the checking, uncomment# one or both of the following lines:
5ebdd59
+# with the initiator requesting a preference of enabling the checking, uncomment
5ebdd59
+# the following lines (Data digests are not supported.):
5ebdd59
 #node.conn[0].iscsi.HeaderDigest = CRC32C,None
5ebdd59
-#node.conn[0].iscsi.DataDigest = CRC32C,None
Mike Christie 3949e15
+
5ebdd59
 #
5ebdd59
 # To allow the targets to control the setting of the digest checking,
5ebdd59
 # with the initiator requesting a preference of disabling the checking,
5ebdd59
-# uncomment one or both of the following lines:
Mike Christie 3949e15
+# uncomment the following line:
5ebdd59
 #node.conn[0].iscsi.HeaderDigest = None,CRC32C
5ebdd59
-#node.conn[0].iscsi.DataDigest = None,CRC32C
5ebdd59
 #
5ebdd59
 # To enable CRC32C digest checking for the header and/or data part of
5ebdd59
-# iSCSI PDUs, uncomment one or both of the following lines:
Mike Christie 3949e15
+# iSCSI PDUs, uncomment the following line:
5ebdd59
 #node.conn[0].iscsi.HeaderDigest = CRC32C
5ebdd59
-#node.conn[0].iscsi.DataDigest = CRC32C
5ebdd59
 #
5ebdd59
 # To disable digest checking for the header and/or data part of
5ebdd59
-# iSCSI PDUs, uncomment one or both of the following lines:
Mike Christie 3949e15
+# iSCSI PDUs, uncomment the following line:
5ebdd59
 #node.conn[0].iscsi.HeaderDigest = None
5ebdd59
-#node.conn[0].iscsi.DataDigest = None
5ebdd59
 #
5ebdd59
 # The default is to never use DataDigests or HeaderDigests.
5ebdd59
 #
5ebdd59
+node.conn[0].iscsi.HeaderDigest = None
5ebdd59
 
Mike Christie 3949e15
 # For multipath configurations, you may want more than one session to be
Mike Christie 3949e15
 # created on each iface record.  If node.session.nr_sessions is greater
Mike Christie 3949e15
diff -aurp open-iscsi-2.0-872-rc4-bnx2i.base/README open-iscsi-2.0-872-rc4-bnx2i.build/README
Mike Christie 3949e15
--- open-iscsi-2.0-872-rc4-bnx2i.base/README	2011-08-14 16:33:53.000000000 -0500
Mike Christie 3949e15
+++ open-iscsi-2.0-872-rc4-bnx2i.build/README	2011-08-14 16:34:12.000000000 -0500
1c8eda8
@@ -74,11 +74,6 @@ the cache sync command will fail.
1c8eda8
 - iscsiadm's -P 3 option will not print out scsi devices.
1c8eda8
 - iscsid will not automatically online devices.
1c8eda8
 
1c8eda8
-You need to enable "Cryptographic API" under "Cryptographic options" in the
1c8eda8
-kernel config. And you must enable "CRC32c CRC algorithm" even if
1c8eda8
-you do not use header or data digests. They are the kernel options,
1c8eda8
-CONFIG_CRYPTO and CONFIG_CRYPTO_CRC32C, respectively.
1c8eda8
-
1c8eda8
 By default the kernel source found at
1c8eda8
 /lib/modules/`uname -a`/build
1c8eda8
 will be used to compile the open-iscsi modules. To specify a different
Mike Christie 3949e15
@@ -975,7 +970,7 @@ Red Hat or Fedora:
1c8eda8
 -----------------
1c8eda8
 To start open-iscsi in Red Hat/Fedora you can do:
1c8eda8
 
1c8eda8
-	service open-iscsi start
1c8eda8
+	service iscsi start
1c8eda8
 
1c8eda8
 To get open-iscsi to automatically start at run time you may have to
1c8eda8
 run:
Mike Christie 3949e15
@@ -1183,6 +1178,8 @@ iscsid will only perform rediscovery whe
1c8eda8
 #   linux-isns (SLES's iSNS server) where it sometimes does not send SCN
1c8eda8
 #   events in the proper format, so they may not get handled.
1c8eda8
 
1c8eda8
+To set the startup value, so that nodes are not logged into automatically
1c8eda8
+use the value "manual".
1c8eda8
 
1c8eda8
 Example:
1c8eda8
 --------
Mike Christie 3949e15
diff -aurp open-iscsi-2.0-872-rc4-bnx2i.base/usr/idbm.c open-iscsi-2.0-872-rc4-bnx2i.build/usr/idbm.c
Mike Christie 3949e15
--- open-iscsi-2.0-872-rc4-bnx2i.base/usr/idbm.c	2011-08-14 16:33:53.000000000 -0500
Mike Christie 3949e15
+++ open-iscsi-2.0-872-rc4-bnx2i.build/usr/idbm.c	2011-08-14 16:34:12.000000000 -0500
Mike Christie 3949e15
@@ -373,9 +373,13 @@ idbm_recinfo_node(node_rec_t *r, recinfo
5ebdd59
 				 IDBM_SHOW, "None", "CRC32C", "CRC32C,None",
5ebdd59
 				 "None,CRC32C", num, 1);
5ebdd59
 		sprintf(key, CONN_DATA_DIGEST, i);
5ebdd59
+
5ebdd59
+#if 0
5ebdd59
+We do not support data digests
5ebdd59
 		__recinfo_int_o4(key, ri, r, conn[i].iscsi.DataDigest, IDBM_SHOW,
5ebdd59
 				 "None", "CRC32C", "CRC32C,None",
5ebdd59
 				 "None,CRC32C", num, 1);
5ebdd59
+#endif
5ebdd59
 		sprintf(key, CONN_IFMARKER, i);
5ebdd59
 		__recinfo_int_o2(key, ri, r, conn[i].iscsi.IFMarker, IDBM_SHOW,
5ebdd59
 				"No", "Yes", num, 1);