|
 |
c0971b7 |
From d332c8a0e7a4c7f0b3ee1b2110145a23cbd61c2a Mon Sep 17 00:00:00 2001
|
|
|
c0971b7 |
From: Sumit Bose <sbose@redhat.com>
|
|
|
c0971b7 |
Date: Fri, 7 Sep 2018 22:19:26 +0200
|
|
|
c0971b7 |
Subject: [PATCH 36/83] getsockopt_wrapper: add support for PAM clients
|
|
|
c0971b7 |
|
|
|
c0971b7 |
PAM clients expect that the private socket of the PAM responder is
|
|
|
c0971b7 |
handled by root. With this patch getsockopt_wrapper can return the
|
|
|
c0971b7 |
expected UID and GID to PAM clients.
|
|
|
c0971b7 |
|
|
|
c0971b7 |
Related to https://pagure.io/SSSD/sssd/issue/3500
|
|
|
c0971b7 |
|
|
|
c0971b7 |
Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
|
|
|
c0971b7 |
---
|
|
|
c0971b7 |
src/tests/intg/getsockopt_wrapper.c | 34 ++++++++++++++++++++++++++++++++++
|
|
|
c0971b7 |
1 file changed, 34 insertions(+)
|
|
|
c0971b7 |
|
|
|
c0971b7 |
diff --git a/src/tests/intg/getsockopt_wrapper.c b/src/tests/intg/getsockopt_wrapper.c
|
|
|
c0971b7 |
index 5109123..2f50889 100644
|
|
|
c0971b7 |
--- a/src/tests/intg/getsockopt_wrapper.c
|
|
|
c0971b7 |
+++ b/src/tests/intg/getsockopt_wrapper.c
|
|
|
c0971b7 |
@@ -45,6 +45,23 @@ static bool is_secrets_socket(int fd)
|
|
|
c0971b7 |
return NULL != strstr(unix_socket->sun_path, "secrets.socket");
|
|
|
c0971b7 |
}
|
|
|
c0971b7 |
|
|
|
c0971b7 |
+static bool peer_is_private_pam(int fd)
|
|
|
c0971b7 |
+{
|
|
|
c0971b7 |
+ int ret;
|
|
|
c0971b7 |
+ struct sockaddr_storage addr = { 0 };
|
|
|
c0971b7 |
+ socklen_t addrlen = sizeof(addr);
|
|
|
c0971b7 |
+ struct sockaddr_un *unix_socket;
|
|
|
c0971b7 |
+
|
|
|
c0971b7 |
+ ret = getpeername(fd, (struct sockaddr *)&addr, &addrlen);
|
|
|
c0971b7 |
+ if (ret != 0) return false;
|
|
|
c0971b7 |
+
|
|
|
c0971b7 |
+ if (addr.ss_family != AF_UNIX) return false;
|
|
|
c0971b7 |
+
|
|
|
c0971b7 |
+ unix_socket = (struct sockaddr_un *)&addr;
|
|
|
c0971b7 |
+
|
|
|
c0971b7 |
+ return NULL != strstr(unix_socket->sun_path, "private/pam");
|
|
|
c0971b7 |
+}
|
|
|
c0971b7 |
+
|
|
|
c0971b7 |
static uid_t fake_secret_peer(uid_t orig_id)
|
|
|
c0971b7 |
{
|
|
|
c0971b7 |
char *val;
|
|
|
c0971b7 |
@@ -57,6 +74,21 @@ static uid_t fake_secret_peer(uid_t orig_id)
|
|
|
c0971b7 |
return atoi(val);
|
|
|
c0971b7 |
}
|
|
|
c0971b7 |
|
|
|
c0971b7 |
+static void fake_peer_uid_gid(uid_t *uid, gid_t *gid)
|
|
|
c0971b7 |
+{
|
|
|
c0971b7 |
+ char *val;
|
|
|
c0971b7 |
+
|
|
|
c0971b7 |
+ val = getenv("SSSD_INTG_PEER_UID");
|
|
|
c0971b7 |
+ if (val != NULL) {
|
|
|
c0971b7 |
+ *uid = atoi(val);
|
|
|
c0971b7 |
+ }
|
|
|
c0971b7 |
+
|
|
|
c0971b7 |
+ val = getenv("SSSD_INTG_PEER_GID");
|
|
|
c0971b7 |
+ if (val != NULL) {
|
|
|
c0971b7 |
+ *gid = atoi(val);
|
|
|
c0971b7 |
+ }
|
|
|
c0971b7 |
+}
|
|
|
c0971b7 |
+
|
|
|
c0971b7 |
typedef typeof(getsockopt) getsockopt_fn_t;
|
|
|
c0971b7 |
|
|
|
c0971b7 |
static getsockopt_fn_t *orig_getsockopt = NULL;
|
|
|
c0971b7 |
@@ -84,6 +116,8 @@ int getsockopt(int sockfd, int level, int optname,
|
|
|
c0971b7 |
cr->uid = 0;
|
|
|
c0971b7 |
} else if (is_secrets_socket(sockfd)) {
|
|
|
c0971b7 |
cr->uid = fake_secret_peer(cr->uid);
|
|
|
c0971b7 |
+ } else if (peer_is_private_pam(sockfd)) {
|
|
|
c0971b7 |
+ fake_peer_uid_gid(&cr->uid, &cr->gid);
|
|
|
c0971b7 |
}
|
|
|
c0971b7 |
}
|
|
|
c0971b7 |
|
|
|
c0971b7 |
--
|
|
|
c0971b7 |
2.9.5
|
|
|
c0971b7 |
|