#2 improve thread contention using appropriate config
Closed 3 days ago by mooninite. Opened 2 months ago by pbrady.
https://github.com/pixelb/ImageMagick-rpm master  into  master

improve thread contention using appropriate config
Pádraig Brady • 2 months ago  
ImageMagick.spec
file modified
+8 -1

@@ -10,7 +10,7 @@

  Epoch:		0

  %endif

  Version:	%{VER}.%{Patchlevel}

- Release:	3%{?dist}

+ Release:	4%{?dist}

  Summary:	An X application for displaying and manipulating images

  

  License:	ImageMagick

@@ -158,6 +158,10 @@

  

  %build

  autoconf -f -i

+ 

+ # Reduce thread contention

+ export CFLAGS="%{optflags} -DIMPNG_SETJMP_IS_THREAD_SAFE"

+ 

  %configure \

  	--enable-shared \

  	--disable-static \

@@ -317,6 +321,9 @@

  %doc PerlMagick/demo/ PerlMagick/Changelog PerlMagick/README.txt

  

  %changelog

+ * Wed Jul 10 2019 Pádraig Brady <P@draigBrady.com> - 0:6.9.10.28-4

+ - Improve thread contention with configuration appropriate for Linux

+ 

  * Thu May 30 2019 Jitka Plesnikova <jplesnik@redhat.com> - 1:6.9.10.28-3

  - Perl 5.30 rebuild

  

no initial comment

This builds ImageMagick rpm with -DIMPNG_SETJMP_IS_THREAD_SAFE which removes
redundant thread locking, which was only needed on Solaris2
(where setjmp is not thread safe). Note GraphicsMagick already has this
set appropriately in the upstream configure script.

we use this on a large internal service where CPU went from 85% idle to 15% idle

I don't have any opinions about the patch, but if you are relying on ImageMagick, would you like to co-maintain the package?

Also, note that simple-koji-ci seems to have failed on a number of non-x86 arches. Can you take a look at that, please?

Should export CFLAGS="%{optflags} -DIMPNG_SETJMP_IS_THREAD_SAFE" to honor default Fedora build options

rebased onto 7cc02d9

2 months ago

I'll review this as soon as I can. A general package update is needed for this, too. Any co-maintainers are welcome to review, too.

I've applied the CFLAG. Thanks.

Pull-Request has been closed by mooninite

3 days ago