#5 Disable automatic .la file removal
Merged 2 years ago by sergiomb. Opened 2 years ago by tbaeder.
rpms/ tbaeder/ImageMagick rawhide  into  rawhide

file modified
+7 -1
@@ -1,5 +1,7 @@ 

  %global VER 6.9.12

  %global Patchlevel 32

+ # Disable automatic .la file removal

+ %global __brp_remove_la_files %nil

  

  Name:		ImageMagick

  %if 0%{?fedora} >= 27
@@ -10,7 +12,7 @@ 

  Epoch:		0

  %endif

  Version:	%{VER}.%{Patchlevel}

- Release:	2%{?dist}

+ Release:	3%{?dist}

  Summary:	An X application for displaying and manipulating images

  

  License:	ImageMagick
@@ -323,6 +325,10 @@ 

  %doc PerlMagick/demo/ PerlMagick/Changelog PerlMagick/README.txt

  

  %changelog

+ * Mon Jan 24 2022 Timm Bäder <tbaeder@redhat.com> - 1:6.9.12.32-3

+ - Disable automatic .la file removal

+ - https://fedoraproject.org/wiki/Changes/RemoveLaFiles

+ 

  * Wed Jan 19 2022 Fedora Release Engineering <releng@fedoraproject.org> - 1:6.9.12.32-2

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild

  

Hello,
Why you want que .la files ? do we need it ?

Thank you

@sergiomb yes, the library needs the .la files of the coders.

Example, from strace output of display some_image.jpg

readlink("/usr/lib64/ImageMagick-7.1.0/modules-Q16HDRI/coders/jpeg.la", 0x7ffd475557a0, 1023) = -1 EINVAL (Argument invalide)
newfstatat(AT_FDCWD, "/usr/lib64/ImageMagick-7.1.0/modules-Q16HDRI/coders/jpeg.la", {st_mode=S_IFREG|0644, st_size=1111, ...}, 0) = 0
access("/usr/lib64/ImageMagick-7.1.0/modules-Q16HDRI/coders/jpeg.la", F_OK) = 0
openat(AT_FDCWD, "/usr/lib64/ImageMagick-7.1.0/modules-Q16HDRI/coders/jpeg.la", O_RDONLY) = 4
openat(AT_FDCWD, "/usr/lib64/ImageMagick-7.1.0/modules-Q16HDRI/coders/jpeg.so", O_RDONLY|O_CLOEXEC) = 4

And if the jpeg.la file is missing, image is not displayed

This is not forbiden by Guidelines

Libtool archives, foo.la files, SHOULD NOT be included. 

This is not a must ;)
ImageMagick is obviously an exception, because really required and used

Pull-Request has been merged by sergiomb

2 years ago
Metadata