rpms / NetworkManager

Clone
Source Code
GIT

#9 Fix building without PPP
Closed a year ago by thaller. Opened 2 years ago by trawets.
https://github.com/stewartsmith/pkg-fedora-NetworkManager.git fix-build-without-ppp  into  rawhide

Fix building without ppp
Stewart Smith • 2 years ago  
65684ee
NetworkManager.spec
file modified
+4 
@@ -716,6 +716,8 @@
 

  %if %{with ppp}
 

  	-Dpppd_plugin_dir=%{_libdir}/pppd/%{ppp_version} \
 

  	-Dppp=true \
 

+ %else
 

+ 	-Dppp=false \
 

  %endif
 

  %if %{with firewalld_zone}
 

  	-Dfirewalld_zone=true \
 
@@ -858,6 +860,8 @@
 

  %if %{with ppp}
 

  	--with-pppd-plugin-dir=%{_libdir}/pppd/%{ppp_version} \
 

  	--enable-ppp=yes \
 

+ %else
 

+ 	--enable-ppp=no \
 

  %endif
 

  %if %{with firewalld_zone}
 

  	--enable-firewalld-zone \

no initial comment

The configure scripts default to PPP being enabled, so the "%if %{with ppp}" conditions currently do not work. This fixes that.

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

rebased onto 65684ee
2 years ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

@trawets Sorry for the long non-responsiveness.

I took your patch, and merged it to our upstream spec file ([1]). Actually, I messed up, and had to fix it afterwards ([2]).

Anyway, so this patch is now in the upstream spec file, from there it finds it way to Fedora. It's also now on in Fedora 38 (commit 9aa462c).

Closing this as fixed. Thank you!!

[1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/2598ec3a1fd231793e9dd243db3d8d633e1782aa
[2] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/06dc84a563af95d87a5fa3634ec98a9e98f9635d

Pull-Request has been closed by thaller
a year ago
Metadata
None
No Tags
Changes Summary 1
+4 -0
file changed
NetworkManager.spec
Powered by Pagure 5.13.3
Documentation • File an Issue • About this Instance • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.