PR#15: abrt-dbus: Fix SIGSEGV with glib2 >= 2.69.2 - rpms/abrt

Michal Srb • 2 years ago

ec34e31

file added

+35

		`@@ -0,0 +1,35 @@`
		`+ From 564c1050e150a083a7d80cbfdd7ede7620e5124f Mon Sep 17 00:00:00 2001`
		`+ From: Michal Srb <michal@redhat.com>`
		`+ Date: Tue, 5 Oct 2021 18:43:27 +0200`
		`+ Subject: [PATCH] abrt-dbus: do not try to free session data twice`
		`+`
		`+ We free session data in on_g_signal() function, which is also`
		`+ invoked when client disappears. Therefore, we don't need to register the`
		`+ same free function in g_bus_watch_name_on_connection().`
		`+`
		`+ glib2 2.69.2 changed (fixed?) how/when g_bus_watch_name_on_connection()`
		`+ calls the provided free function and it uncovered this problem in abrt-dbus.`
		`+`
		`+ See rhbz#1997315 for more details.`
		`+`
		`+ Signed-off-by: Michal Srb <michal@redhat.com>`
		`+ ---`
		`+ src/dbus/abrt_problems2_service.c \| 2 +-`
		`+ 1 file changed, 1 insertion(+), 1 deletion(-)`
		`+`
		`+ diff --git a/src/dbus/abrt_problems2_service.c b/src/dbus/abrt_problems2_service.c`
		`+ index 8d543f44..004c7aeb 100644`
		`+ --- a/src/dbus/abrt_problems2_service.c`
		`+ +++ b/src/dbus/abrt_problems2_service.c`
		`+ @@ -571,7 +571,7 @@ static AbrtP2Object session_object_register(AbrtP2Service service,`
		`+ obj->owner_watcher_id = g_bus_watch_name_on_connection(connection, caller,`
		`+ G_BUS_NAME_WATCHER_FLAGS_NONE,`
		`+ NULL, abrt_p2_service_on_session_owner_vanished,`
		`+ - obj, (GDestroyNotify)abrt_p2_object_destroy);`
		`+ + obj, NULL);`
		`+`
		`+ return obj;`
		`+ }`
		`+ --`
		`+ 2.31.1`
		`+`

abrt.spec

file modified

+5 -1

		`@@ -49,7 +49,7 @@`
		`Summary: Automatic bug detection and reporting tool`
		`Name: abrt`
		`Version: 2.14.6`
		`- Release: 8%{?dist}`
		`+ Release: 9%{?dist}`
		`License: GPLv2+`
		`URL: https://abrt.readthedocs.org/`
		`Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz`
		`@@ -137,6 +137,7 @@`
		`%endif`

		`Patch0: 0001-Use-lazy-imports-in-abrt_exception_handler3.patch`
		`+ Patch2: 0002-abrt-dbus-do-not-try-to-free-session-data-twice.patch`

		`%description`
		`%{name} is a tool to help users to detect defects in applications and`
		`@@ -1003,6 +1004,9 @@`
		`%config(noreplace) %{_sysconfdir}/profile.d/abrt-console-notification.sh`

		`%changelog`
		`+ * Tue Oct 05 2021 Michal Srb <michal@redhat.com> - 2.14.6-9`
		`+ - abrt-dbus: Fix SIGSEGV with glib2 >= 2.69.2 (rhbz#1997315)`
		`+`
		`* Mon Sep 27 2021 Matěj Grabovský <mgrabovs@redhat.com> - 2.14.6-8`
		`- Use lazy import in the Python exception handler to avoid slowdown in Python`
		`startup (rhbz#2007664)`