#1 Update ansible-collection-community-general.spec
Closed 2 years ago by kevin. Opened 2 years ago by sshnaidm.
rpms/ sshnaidm/ansible-collection-community-general rawhide  into  rawhide

@@ -26,7 +26,7 @@ 

  rm -vr .github .azure-pipelines

  find -type f ! -executable -name '*.py' -print -exec sed -i -e '1{\@^#!.*@d}' '{}' +

  find -type f -name '.gitignore' -print -delete

- sed -i -e 's|env python$|env python3|' scripts/inventory/*.py scripts/vault/*.py

+ test -d scripts && sed -i -e 's|env python$|env python3|' scripts/inventory/*.py scripts/vault/*.py || echo "nothing to do"

  

  %build

  %ansible_collection_build

Make sed to check for scripts directory since it doesn't exist in community-general anymore.

rebased onto 40bf714

2 years ago

rebased onto 28c00ef

2 years ago

If it doesn't matter in the latest version, might as well just delete it?

It's deleted in commit https://github.com/ansible-collections/community.general/commit/08f7ad06bea1fc71c675550db0f0dc46b1f45224 and I don't see it's released. Shouldn't we wait till 3.4.0 tag? Otherwise I'd delete it

Pull-Request has been closed by kevin

2 years ago

Sorry, I'm not sure I understood - what is the solution here?

Just to wait until 3.4.0 is out and when it is, as part of that update to remove that line?

I can add a comment when I upgrade to 3.3.1...

Metadata