#1 Update arc-theme.spec
Closed a month ago by thesupergeek. Opened a month ago by thesupergeek.

file modified
+28 -67

@@ -1,63 +1,37 @@

- %global common_configure --disable-unity --with-gnome-shell=3.30 --srcdir=..

+ %global common_configure --disable-unity --with-gnome-shell=3.32 --srcdir=..

  

- %global common_desc							\

- Arc is a flat theme with transparent elements for GTK 3, GTK 2 and	\

- Gnome-Shell which supports GTK 3 and GTK 2 based desktop environments	\

- like Gnome, Cinnamon, Budgie, Pantheon, XFCE, Mate, etc.

+ Name:           arc-theme

+ Version:        20190330

+ Release:        1%{?dist}

+ Summary:        Flat theme with transparent elements

  

+ License:        GPLv3+

+ URL:            https://github.com/NicoHood/%{name}

+ Source0:        %{url}/archive/%{version}.tar.gz

Please do not change the naming scheme of the source tarball.

  

- Name:		arc-theme

- Version:	20181022

- Release:	2%{?dist}

- Summary:	Flat theme with transparent elements

+ BuildArch:      noarch

  

- License:	GPLv3+

- URL:		https://github.com/NicoHood/%{name}

- Source0:	%{url}/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz

- Patch0:		fix-OSD.patch

- Patch1:		support_xed.patch

+ BuildRequires:  autoconf

+ BuildRequires:  automake

+ BuildRequires:  sassc

+ BuildRequires:  pkgconfig

If the the latest upstream release introduces pkgconfig as a build dependency, it would be good to mention in the changelog. Refactoring out the whitespace-only changes into their own patch as suggested by @sgallagh will help make it more clear that this is a change to the build process. Thanks!

+ BuildRequires:  optipng

+ BuildRequires:  inkscape

+ BuildRequires:  gtk3-devel

  

- BuildArch:	noarch

+ Requires:       filesystem

+ Requires:       gnome-themes-extra

+ Requires:       gtk-murrine-engine

  

- BuildRequires:	autoconf

- BuildRequires:	automake

- BuildRequires:	fdupes

- BuildRequires:	gtk3-devel

- BuildRequires:	gtk-murrine-engine

- BuildRequires:	inkscape

- BuildRequires:	optipng

- BuildRequires:	sassc

- 

- Requires:	filesystem

- Requires:	gnome-themes-standard

- Requires:	gtk-murrine-engine

+ Obsoletes:      arc-theme-plank

Don't drop the plank sub-package, as the installation location does not work out of the box for plank.

  

  %description

- %{common_desc}

- 

- 

- %package plank

- Summary:	Arc-theme for Plank dock

- 

- Requires:	%{name}	== %{version}-%{release}

- 

- %if 0%{?fedora}

- Requires:	plank

- 

- Supplements:	(%{name} and plank)

- %endif

- 

- %description plank

- %{common_desc}

- 

- This package contains the %{summary}.

- 

+ Arc is a flat theme with transparent elements for GTK 3, GTK 2 and Gnome-Shell which supports GTK 3 and GTK 2 based desktop environments like Gnome, Cinnamon, Budgie, Pantheon, XFCE, Mate, etc.

  

  %prep

- %autosetup -p 1

+ %autosetup

  %{_bindir}/autoreconf -fiv

  

- 

  %build

  %{__mkdir} -p regular solid

  pushd regular

@@ -68,37 +42,24 @@

  %{__ln_s} -f ../configure configure

  %configure --disable-transparency %{common_configure}

  popd

- %make_build -C regular

+ %make_build -C regular	

  %make_build -C solid

  

- 

  %install

  %make_install -C regular

  %make_install -C solid

  

- # Install Plank-theme.

- %{__mkdir} -p %{buildroot}/%{_datadir}/plank/themes/Arc

- %{__install} -pm 0644 extra/Arc-Plank/dock.theme	\

- 	%{buildroot}/%{_datadir}/plank/themes/Arc

- 

- # Link duplicate files.

- %fdupes -s %{buildroot}%{_datadir}

- 

- 

  %files

  %license AUTHORS COPYING

  %doc README.md

  %{_datadir}/themes/*

  

- %files plank

- %if 0%{?fedora}

- %{_datadir}/plank/themes/*

- %else

- %{_datadir}/plank

- %endif

- 

  

  %changelog

+ * Sat Apr 20 2019 Martin GRUDLER <martin@grudler.eu> - 20190330-1

+ - New upstream release

+ - Removed plank instructions, already included into the build process

+ 

  * Thu Jan 31 2019 Fedora Release Engineering <releng@fedoraproject.org> - 20181022-2

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild

  

@@ -153,4 +114,4 @@

  - Add plank-subpkg and require Plank (rhbz#1411438)

  

  * Mon Jan 09 2017 Björn Esser <bjoern.esser@gmail.com> - 20161119-0.1

- - Initial package (rhbz#1411438)

+ - Initial package (rhbz#1411438) 

\ No newline at end of file

Trying to update the package, i'm new packager.
Helped by @besser82 and @sgallagh .

Changes :
- New upstream release
- Removed plank instructions, already included into the build process

Metadata Update from @besser82:
- Request assigned

a month ago

There are a lot of whitespace-only changes here. Can you eliminate those (or, if they're important, separate them into a different patch) so that the review is easier? Right now, it looks like you've changed every line.

Please do not change the naming scheme of the source tarball.

Don't drop the plank sub-package, as the installation location does not work out of the box for plank.

Don't drop the plank sub-package, as the installation location does not work out of the box for plank.

Well, if you do drop it, make sure that the package that Obsoletes: it (probably the main package) puts it in the same location.

Don't drop the plank sub-package, as the installation location does not work out of the box for plank.

Well, if you do drop it, make sure that the package that Obsoletes: it (probably the main package) puts it in the same location.

Then we would need to have Requires: plank in the main package for proper directory ownership, which is not desireable.

Don't drop the plank sub-package, as the installation location does not work out of the box for plank.
Well, if you do drop it, make sure that the package that Obsoletes: it (probably the main package) puts it in the same location.

Then we would need to have Requires: plank in the main package for proper directory ownership, which is not desireable.

Ah, I missed that. Agreed: please restore the plank subpackage.

Anyways, please split the whole set of changes (de-tabyfying, etc.) in logically seperate commits.

Also, I disagree with removing the xed patch, as I prefer xed over gedit. It should be updated to work with gtk-3.22…

If the the latest upstream release introduces pkgconfig as a build dependency, it would be good to mention in the changelog. Refactoring out the whitespace-only changes into their own patch as suggested by @sgallagh will help make it more clear that this is a change to the build process. Thanks!

Removing %fdupes also increases the installation size drastically, as many files are the same between the version with transparency and the solid one.

Pull-Request has been closed by thesupergeek

a month ago