PR#1: Obsolete ardour2 on Fedora 29+. - rpms/ardour5

rpms / ardour5

#1 Obsolete ardour2 on Fedora 29+.

Merged 5 years ago by nphilipp. Opened 5 years ago by qulogic.

Unknown source ardour2 into master

Elliott Sales de Andrade • 5 years ago

5a12b25

ardour5.spec

file modified

		`@@ -139,6 +139,11 @@`
		`Obsoletes: ardour4`
		`Conflicts: ardour4`
		`%endif`
		`+ # Ardour 2 is no longer available in Fedora 29.`
		`+ %if 0%{?fedora} >= 29 \|\| 0%{?rhel} >= 8`
		`+ Obsoletes: ardour2 < 2.8.16-30`
		`+ Conflicts: ardour2 < 2.8.16-30`
		`+ %endif`

		`%description`
		`Ardour is a multi-channel digital audio workstation, allowing users to record,`
		`@@ -325,6 +330,9 @@`
		`%{_mandir}//man1/%{name}.1`

		`%changelog`
		`+ * Tue Jan 08 2019 Elliott Sales de Andrade <quantum.analyst@gmail.com> - 5.12.0-10`
		`+ - Obsolete ardour2 on Fedora 29+`
		`+`
		`* Fri Nov 09 2018 Nils Philippsen <nils@tiptoe.de> - 5.12.0-9`
		`- set LC_ALL=C.UTF-8 to only require minimal glibc langpacks`

qulogic commented 5 years ago

ardour2's README says it's obsoleted by ardour5, but this package doesn't actually say so.

Would fix https://bugzilla.redhat.com/show_bug.cgi?id=1657558 (i.e., 28 -> 29 upgrades breaking) if applied to Fedora 29.

nphilipp commented 5 years ago

Hmm, there was a reason why I didn't obsolete ardour2 with ardour5 and I think it went like this:

While ardour3/4/5 can read ardour2 sessions and convert them to the new format, some information is lost in this process. Versions 3, 4, 5 are fully backwards-compatible between them, though (4 with 3, 5 with 3 & 4).
If ardour5 obsoletes/conflicts with ardour2, people can't keep the old version around (if they need to access their old sessions).

However, now that ardour2 is retired, adding this to ensure a smooth upgrade looks sensible to me. I'm not sure about the version you obsoleted/conflicted with, I think it should rather be ardour2 < 2.8.16-30 because 2.8.16-29 < 2.8.16-29.fc28 (the last version/release built) for RPM:

nils@gibraltar:~> rpmdev-vercmp 2.8.16-29 2.8.16-29.fc28
2.8.16-29 < 2.8.16-29.fc28

nphilipp commented 5 years ago

rebased onto 5a12b25

5 years ago

qulogic commented 5 years ago

Updated the Obsoletes.

nphilipp commented 5 years ago

Thanks!

Pull-Request has been merged by nphilipp

5 years ago

Metadata

Assignee

None

Tags

No Tags

Changes Summary 1

+8 -0

file changed

ardour5.spec

rpms / ardour5

Source Code

#1 Obsolete ardour2 on Fedora 29+. Merged 5 years ago by nphilipp. Opened 5 years ago by qulogic. Unknown source ardour2 into master

Metadata

Changes Summary 1

#1 Obsolete ardour2 on Fedora 29+.

Merged 5 years ago by nphilipp. Opened 5 years ago by qulogic.

Unknown source ardour2 into master