#3 Build against FlexiBLAS
Merged 3 years ago by decathorpe. Opened 3 years ago by iucar.
rpms/ iucar/arpack master  into  master

file modified
+16 -1
@@ -11,12 +11,16 @@ 

  %endif

  %endif

  

+ %if 0%{?fedora} >= 33

+ %bcond_without flexiblas

+ %endif

+ 

  # We are linking FORTRAN symbols.  Thus we cannot link --as-needed.

  %undefine _ld_as_needed

  

  Name:		arpack

  Version:	3.7.0

- Release:	7%{dist}

+ Release:	8%{dist}

  Summary:	Fortran 77 subroutines for solving large scale eigenvalue problems

  

  License:	BSD
@@ -29,11 +33,15 @@ 

  

  BuildRequires:	gcc-c++

  BuildRequires:	gcc-gfortran

+ %if %{with flexiblas}

+ BuildRequires:  pkgconfig(flexiblas)

+ %else

  %if %{with atlas}

  BuildRequires:	atlas-devel

  %else

  BuildRequires:	openblas-devel

  %endif

+ %endif

  BuildRequires:	libtool >= 2.4.2

  Provides:	arpack-ng = %{version}-%{release}

  Provides:	arpack-ng%{?_isa} = %{version}-%{release}
@@ -97,6 +105,9 @@ 

  

  

  %build

+ %if %{with flexiblas}

+ %global blaslib -lflexiblas

+ %else

  %if %{with atlas}

  %if 0%{?fedora} || 0%{?rhel} >= 7

  %global blaslib -L%{_libdir}/atlas -ltatlas
@@ -106,6 +117,7 @@ 

  %else

  %global blaslib -lopenblasp

  %endif

+ %endif

  pushd src

  %configure --enable-shared --enable-static \

      --with-blas="%{blaslib}" \
@@ -183,6 +195,9 @@ 

  

  

  %changelog

+ * Fri Aug 07 2020 Iñaki Úcar <iucar@fedoraproject.org> - 3.7.0-8

+ - https://fedoraproject.org/wiki/Changes/FlexiBLAS_as_BLAS/LAPACK_manager

+ 

  * Mon Jul 27 2020 Fedora Release Engineering <releng@fedoraproject.org> - 3.7.0-7

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild

  

This PR is part of a F33 System-Wide Change Proposal that aims to set FlexiBLAS
as the default BLAS/LAPACK manager for all consumers of these APIs. For further
information, see https://fedoraproject.org/wiki/Changes/FlexiBLAS_as_BLAS/LAPACK_manager

You'll find a successful scratch build for this PR in
https://koji.fedoraproject.org/koji/taskinfo?taskID=47823482

I kindly ask you to merge this PR and build the package in rawhide. Please,
report any issues you may found in https://bugzilla.redhat.com/show_bug.cgi?id=1860504

Note that CI build failures may happen for aarch64 due to
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/FNOL635TXCZ2AUEJ7VS6GZHLMPTHMYWO/,
nothing to do with this PR.

Could you use a conditional consistent with the rest of the spec file? I mean %bcond_*_foo and %{with foo}.

1 new commit added

  • use bcond instead of global
3 years ago

Thanks. Sorry for the trouble, but can you rebase against current rawhide? It looks like there are merge conflicts.

rebased onto 69f26f0

3 years ago

No, not done, I lost the changes... damn!

I don't understand... the files are ok in my fork, the changes are there, but they are not shown in the "files changed" tab in this PR (I manually merged changes in master instead of running git rebase). Is this a bug in Pagure? Or did I something wrong?

rebased onto c4463c2

3 years ago

Forced update, clean commit.

Processing as provenpackager according to this request for help:
https://pagure.io/fesco/issue/2443#comment-669930

Diff looks good, simple-koji-ci passed. I'll merge and build.

Pull-Request has been merged by decathorpe

3 years ago