Blame chromium-47.0.2526.80-nacl-ignore-broken-fd-counter.patch
|
 |
f66ad85 |
diff -up chromium-47.0.2526.80/components/nacl/loader/sandbox_linux/nacl_sandbox_linux.cc.ignore-fd-count chromium-47.0.2526.80/components/nacl/loader/sandbox_linux/nacl_sandbox_linux.cc
|
|
|
f66ad85 |
--- chromium-47.0.2526.80/components/nacl/loader/sandbox_linux/nacl_sandbox_linux.cc.ignore-fd-count 2015-12-15 14:48:07.119011866 -0500
|
|
|
f66ad85 |
+++ chromium-47.0.2526.80/components/nacl/loader/sandbox_linux/nacl_sandbox_linux.cc 2015-12-15 14:48:14.151850055 -0500
|
|
|
f66ad85 |
@@ -153,6 +153,14 @@ void NaClSandbox::InitializeLayerOneSand
|
|
|
f66ad85 |
}
|
|
|
f66ad85 |
|
|
|
f66ad85 |
void NaClSandbox::CheckForExpectedNumberOfOpenFds() {
|
|
|
f66ad85 |
+ // Whatever logic this code is using is wrong more often than it is right.
|
|
|
f66ad85 |
+ // If you set expected_num_fds to 6, it finds 7.
|
|
|
f66ad85 |
+ // If you set expected_num_fds to 7, it finds 6.
|
|
|
f66ad85 |
+ // Code like this makes a packager drink. And not the good stuff either.
|
|
|
f66ad85 |
+ // Instead, we're just going to smile and tell it to never care about the
|
|
|
f66ad85 |
+ // number of FDs open. Stupid code. We hates it.
|
|
|
f66ad85 |
+
|
|
|
f66ad85 |
+#if 0
|
|
|
f66ad85 |
// We expect to have the following FDs open:
|
|
|
f66ad85 |
// 1-3) stdin, stdout, stderr.
|
|
|
f66ad85 |
// 4) The /dev/urandom FD used by base::GetUrandomFD().
|
|
|
f66ad85 |
@@ -171,6 +179,8 @@ void NaClSandbox::CheckForExpectedNumber
|
|
|
f66ad85 |
}
|
|
|
f66ad85 |
|
|
|
f66ad85 |
CHECK_EQ(expected_num_fds, sandbox::ProcUtil::CountOpenFds(proc_fd_.get()));
|
|
|
f66ad85 |
+#endif
|
|
|
f66ad85 |
+
|
|
|
f66ad85 |
}
|
|
|
f66ad85 |
|
|
|
f66ad85 |
void NaClSandbox::InitializeLayerTwoSandbox(bool uses_nonsfi_mode) {
|