PR#120: Fix: RPM build errors: absolute symlink - rpms/clang

rpms / clang

#120 Fix: RPM build errors: absolute symlink

Opened 8 months ago by kkleine. Modified an hour ago

rpms/ kkleine/clang fix-abs-symlink into rawhide

Fix: RPM build errors: absolute symlink

Konrad Kleine • 8 months ago

cee0b38

clang.spec

file modified

+5 -2

		`@@ -68,7 +68,7 @@`

		`Name: %pkg_name`
		`Version: %{clang_version}%{?rc_ver:~rc%{rc_ver}}`
		`- Release: 1%{?dist}`
		`+ Release: 2%{?dist}`
		`Summary: A C language family front-end for LLVM`

		`License: NCSA`
		`@@ -442,7 +442,7 @@`

		`%if %{without compat_build}`
		`# Add a symlink in /usr/bin to clang-format-diff`
		`- ln -s %{_datadir}/clang/clang-format-diff.py %{buildroot}%{_bindir}/clang-format-diff`
		`+ ln -sr %{_datadir}/clang/clang-format-diff.py %{buildroot}%{_bindir}/clang-format-diff`
		`%endif`

		`%check`
		`@@ -548,6 +548,9 @@`

		`%endif`
		`%changelog`
		`+ * Fri Sep 10 2021 Konrad Kleine <kkleine@redhat.com> - 13.0.0~rc1-2`
		`+ - Fix: RPM build errors: absolute symlink for clang-format-diff`
		`+`
		`* Fri Aug 06 2021 Tom Stellard <tstellar@redhat.com> - 13.0.0~rc1-1`
		`- 13.0.0-rc1 Release`

kkleine commented 8 months ago

/usr/bin/clang-format-diff -> /usr/share/clang/clang-format-diff.py

Make it a relative link instead.

zuul commented 8 months ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

check-for-arches : SUCCESS in 1m 46s
rpm-scratch-build : SUCCESS in 2h 27m 17s
rpm-scratch-build-s390x : SUCCESS in 2h 51m 19s (non-voting)
rpm-scratch-build-ppc64le : SUCCESS in 1h 18m 49s (non-voting)
rpm-scratch-build-i686 : SUCCESS in 1h 15m 08s (non-voting)
rpm-scratch-build-armv7hl : SUCCESS in 2h 46m 25s (non-voting)
rpm-scratch-build-aarch64 : SUCCESS in 4h 39m 30s (non-voting)
rpm-linter : FAILURE in 5m 18s
rpm-rpminspect : POST_FAILURE in 9m 20s (non-voting)
check-for-tests : SUCCESS in 2m 21s
check-for-fmf-tests : SUCCESS in 2m 23s
rpm-install-test : SKIPPED
rpm-test : FAILURE in 34m 53s
rpm-tmt-test : SKIPPED

tstellar commented 8 months ago

rpm-linter is complaining about the new symlinks:

clang-tools-extra.x86_64: E: symlink-has-too-many-up-segments /usr/bin/clang-format-diff ../../../../../../usr/share/clang/clang-format-diff.py
clang-tools-extra.x86_64: E: symlink-contains-up-and-down-segments /usr/bin/clang-format-diff ../../../../../../usr/share/clang/clang-format-diff.py
clang-tools-extra.x86_64: E: symlink-contains-up-and-down-segments /usr/bin/clang-format-diff ../../../../../../usr/share/clang/clang-format-diff.py

Edited 8 months ago by tstellar

tstellar commented an hour ago

Do we still need this?