PR#197: Test a fix for the IEEE 128-bit fp error - rpms/clang

rpms / clang

#197 Test a fix for the IEEE 128-bit fp error

Closed a year ago by tuliom. Opened a year ago by tuliom.

rpms/ tuliom/clang fix-ieee128-cross into upstream-snapshot

Tulio Magno Quites Machado Filho • a year ago

83ab8aa

clang.spec

file modified

		`@@ -562,6 +562,7 @@`
		`%endif`

		`%files resource-filesystem`
		`+ %dir %{pkg_libdir}/clang/`
		`%dir %{pkg_libdir}/clang/%{maj_ver}/`
		`%dir %{pkg_libdir}/clang/%{maj_ver}/include/`
		`%dir %{pkg_libdir}/clang/%{maj_ver}/lib/`

tuliom commented a year ago

Test if this will fix the error when running ppc64le tests on a cross
compiler.

nikic commented a year ago

Is there an upstream review for this patch?

nikic commented a year ago

recheck

nikic commented a year ago

Ah, I now see that this is against upstream-snapshot, not rawhide, so probably CI doesn't work.

kkleine commented a year ago

Ah, I now see that this is against upstream-snapshot, not rawhide, so probably CI doesn't work.

I AM CI :muscle: :grinning:

rebased onto 27a322d55a6d08dedeeb95e42fe1cb2001ce6250

a year ago

tuliom commented a year ago

I fixed an issue with the patch.
It had an unintentional file removal.

rebased onto 76056c06cb24656b773c479295d505577b43d92d

a year ago

tuliom commented a year ago

In this update, I added more changes allowing to fully build the clang packages.
There is still a warning about clang-format-diff though.

kkleine commented a year ago

@tuliom can you please rebase again? I think there's nothing in this PR that I haven't already applied. It simply was too much in one PR for me. I've had some patch removal changes in already as well.

rebased onto 83ab8aa

a year ago

tuliom commented a year ago

@kkleine Done. There is a single line that I believe is missing.
See in the commit here.

tuliom commented a year ago

This PR is not needed anymore.
I'm closing it.

Pull-Request has been closed by tuliom

a year ago