#64 Add symlink to %%{_libdir}/clang/%%{maj_ver}
Closed 3 years ago by tstellar. Opened 3 years ago by defolos.
rpms/ defolos/clang master  into  master

file modified
+13 -1
@@ -4,7 +4,7 @@ 

  %global min_ver 0

  %global patch_ver 0

  #%%global rc_ver 6

- %global baserelease 1

+ %global baserelease 2

  

  %global clang_tools_binaries \

  	%{_bindir}/clang-apply-replacements \
@@ -384,6 +384,15 @@ 

  # Fix permission

  chmod u-x %{buildroot}%{_mandir}/man1/scan-build.1*

  

+ # create a link to clang's resource directory that is "constant" across minor

+ # version bumps

+ # this is required for packages like ccls that hardcode the link to clang's

+ # resource directory to not require rebuilds on minor version bumps

+ # Fix for bugs like rhbz#1807574

+ pushd %{buildroot}%{_libdir}/clang/

+ ln -s %{version} %{maj_ver}

+ popd

+ 

  %endif

  

  %check
@@ -469,6 +478,9 @@ 

  

  %endif

  %changelog

+ * Tue May  5 2020 Dan Čermák <dan.cermak@cgc-instruments.com> - 10.0.0-2

+ - Add symlink to %%{_libdir}/clang/%%{maj_ver} for persistent access to the resource directory accross minor version bumps

+ 

  * Thu Mar 26 2020 sguelton@redhat.com - 10.0.0-1

  - 10.0.0 final

  

This is required for packages like ccls that hardcode the link to clang's resource directory to not require rebuilds on minor version bumps (required to fix issues like rhbz#1807574).

Will you need to patch ccls to use this symlink dir?

Will you need to patch ccls to use this symlink dir?

Not really, I'll only have to add an argument to cmake and that should be it.

I'm OK with this, but I want to figure out why the CI tests fail.

Pull-Request has been closed by tstellar

3 years ago