PR#1: Build against FlexiBLAS - rpms/clblast

rpms / clblast

#1 Build against FlexiBLAS

Merged 3 years ago by jjames. Opened 3 years ago by iucar.

rpms/ iucar/clblast master into master

https://fedoraproject.org/wiki/Changes/FlexiBLAS_as_BLAS/LAPACK_manager

Iñaki Úcar • 3 years ago

5afd095

clblast.spec

file modified

+8 -2

		`@@ -12,7 +12,7 @@`

		`Name: clblast`
		`Version: 1.5.1`
		`- Release: 3%{?dist}`
		`+ Release: 4%{?dist}`
		`Summary: Tuned OpenCL BLAS routines`

		`License: ASL 2.0`
		`@@ -25,7 +25,7 @@`
		`BuildRequires: gcc`
		`BuildRequires: gcc-c++`
		`BuildRequires: ocl-icd-devel`
		`- BuildRequires: openblas-devel`
		`+ BuildRequires: pkgconfig(flexiblas)`
		`%ifarch %{ix86} x86_64`
		`BuildRequires: pocl-devel`
		`# Work around bz 1734850`
		`@@ -66,6 +66,9 @@`

		`# Fix the path to the openblas headers`
		`sed -i 's,openblas/include,include/openblas,' cmake/Modules/FindCBLAS.cmake`
		`+ # Add paths for FlexiBLAS`
		`+ sed -i 's,include/openblas,include/openblas include/flexiblas,' cmake/Modules/FindCBLAS.cmake`
		`+ sed -i 's,NAMES cblas blas,NAMES cblas blas flexiblas,' cmake/Modules/FindCBLAS.cmake`

		`%build`
		`%cmake -DTESTS:BOOL=ON`
		`@@ -96,6 +99,9 @@`
		`%{_bindir}/*`

		`%changelog`
		`+ * Fri Aug 07 2020 Iñaki Úcar <iucar@fedoraproject.org> - 1.5.1-4`
		`+ - https://fedoraproject.org/wiki/Changes/FlexiBLAS_as_BLAS/LAPACK_manager`
		`+`
		`* Sat Aug 01 2020 Fedora Release Engineering <releng@fedoraproject.org> - 1.5.1-3`
		`- Second attempt - Rebuilt for`
		`https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild`

iucar commented 3 years ago

This PR is part of a F33 System-Wide Change Proposal that aims to set FlexiBLAS
as the default BLAS/LAPACK manager for all consumers of these APIs. For further
information, see https://fedoraproject.org/wiki/Changes/FlexiBLAS_as_BLAS/LAPACK_manager

You'll find a successful scratch build for this PR in
https://koji.fedoraproject.org/koji/taskinfo?taskID=47832918

I kindly ask you to merge this PR and build the package in rawhide. Please,
report any issues you may found in https://bugzilla.redhat.com/show_bug.cgi?id=1860504

Please note that, currently, build failures may happen for aarch64 due to
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/FNOL635TXCZ2AUEJ7VS6GZHLMPTHMYWO/,
nothing to do with this PR.

rebased onto 95972e7

3 years ago

rebased onto 5afd095

3 years ago

Pull-Request has been merged by jjames

3 years ago

iucar commented 3 years ago

Thanks! I'm curious about why tests succeeded in the scratch build as well as in yesterday's build, but failed in the simple-koji-ci build with a segfault (a couple of tests segfaulted). Quite strange...

jjames commented 3 years ago

I don't know what happened there. Yesterday's build was actually the second of two. The first build also had segfaulting tests. After I did multiple local mock builds without reproducing the problem, I decided to try a koji build again, and that one succeeded. I'll investigate further if I can get the segfaults to happen locally.

iucar commented 3 years ago

Thanks. My guess is that it may have something to do with the linking order (maybe with LTO?), but I didn't manage to reproduce the segfaults locally either. I also forwarded the log to the FlexiBLAS' author, but he is on vacation right now. I'll let you know any news.