PR#36: Fix dist-git tests - rpms/cockpit

		`@@ -48,10 +48,16 @@`
		`# TestUpdates: we can't run rebooting tests`
		`TESTS="$TESTS`
		`TestAutoUpdates`
		`- TestMachines`
		`TestStorage`
		`TestUpdates.testBasic`
		`TestUpdates.testSecurityOnly"`
		`+`
		`+ # Fedora gating tests are running on infra without /dev/kvm; Machines tests are too darn slow there`
		`+ if [ -w /dev/kvm ]; then`
		`+ TESTS="$TESTS TestMachines"`
		`+ else`
		`+ TESTS="$TESTS TestMachinesCreate.testCreateImportDisk"`
		`+ fi`
		`fi`

		`if [ -n "$test_basic" ]; then`
		`@@ -60,6 +66,7 @@`

		`# TODO: fix for CI environment`
		`EXCLUDES="$EXCLUDES TestLogin.testTally"`
		`+ EXCLUDES="$EXCLUDES TestLogin.testServer"`
		`EXCLUDES="$EXCLUDES TestAccounts.testBasic"`

		`# PCI devices list is not predictable`
		`@@ -91,12 +98,12 @@`
		`done`

		`# execute run-tests`
		`- test/common/run-tests --test-dir test/verify --trace --verbose --nondestructive $exclude_options \`
		`+ test/common/run-tests --test-dir test/verify --nondestructive $exclude_options \`
		`--machine localhost:22 --browser localhost:9090 $TESTS \|\| RC=$?`

		`# check-menu is not @nondestructive yet, keep it last`
		`if [ -n "$test_basic" ]; then`
		`- test/verify/check-menu -tv --machine localhost:22 --browser localhost:9090 \|\| RC=$?`
		`+ test/verify/check-menu --machine localhost:22 --browser localhost:9090 \|\| RC=$?`
		`fi`

		`echo $RC > "$LOGS/exitcode"`

tests/verify.sh

file modified

+20 -9

		`@@ -1,20 +1,31 @@`
		`#!/bin/sh`
		`set -eux`

		`- # from standard-test-source`
		`- SOURCE="$(pwd)/source"`
		`+ TESTS="$(realpath $(dirname "$0"))"`
		`+ if [ -d source ]; then`
		`+ # path for standard-test-source`
		`+ SOURCE="$(pwd)/source"`
		`+ else`
		`+ SOURCE="$(realpath $TESTS/..)"`
		`+ fi`
		`LOGS="$(pwd)/logs"`
		`- TESTS="$(pwd)/tests"`
		`mkdir -p "$LOGS"`
		`chmod a+w "$LOGS"`

		`# install browser; on RHEL, use chromium from epel`
		`- if ! rpm -q chromium-headless; then`
		`- if grep -q 'ID=.*rhel' /etc/os-release; then`
		`- dnf install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-8.noarch.rpm`
		`- dnf config-manager --enable epel`
		`- fi`
		`- dnf install -y chromium-headless`
		`+ # HACK: chromium 88 crashes with some keyDown commands: https://bugs.chromium.org/p/chromium/issues/detail?id=1170634`
		`+ if rpm -q chromium-headless; then`
		`+ dnf remove -y chromium-headless`
		`+ fi`
		`+`
		`+ if grep -q 'ID=.*rhel' /etc/os-release; then`
		`+ dnf install -y \`
		`+ https://kojipkgs.fedoraproject.org//packages/chromium/87.0.4280.141/1.el8/x86_64/chromium-common-87.0.4280.141-1.el8.x86_64.rpm \`
		`+ https://kojipkgs.fedoraproject.org//packages/chromium/87.0.4280.141/1.el8/x86_64/chromium-headless-87.0.4280.141-1.el8.x86_64.rpm`
		`+ else`
		`+ dnf install -y \`
		`+ https://kojipkgs.fedoraproject.org//packages/chromium/87.0.4280.141/1.fc33/x86_64/chromium-common-87.0.4280.141-1.fc33.x86_64.rpm \`
		`+ https://kojipkgs.fedoraproject.org//packages/chromium/87.0.4280.141/1.fc33/x86_64/chromium-headless-87.0.4280.141-1.fc33.x86_64.rpm`
		`fi`

		`# make libpwquality less aggressive, so that our "foobar" password works`

no initial comment

3 new commits added

tests: Enable TestTuned.testBasic
test: Exclude TestLogin.testServer
Run tests less verbosely

3 years ago

martinpitt commented 3 years ago

These commits worked in the sense that chromium 87 gets used and there are no browser crashes any more. There are still tons of failures, though. Unfortunately artifacts were not saved, so it is a bit hard to see why e.g. testServer failed. I'll try and exclude it for now.

martinpitt commented 3 years ago

The tests have run for 5:30 hours now. I was talking to @mvadkert , he got me access to the running instance. The machines tests are just dog slow due to not having /dev/kvm:

# 1 TEST PASSED [212s on ip-172-31-23-135]
ok 6 test/verify/check-machines-create TestMachinesCreate.testCreateImportDisk [ND@0]

and since so many of them fail, they are being retried three times, so altogether they sum up to $insanely_long time. I'm afraid on the current Fedora infra we have to dial these down.

5 new commits added