rpms / community-mysql

Clone
Source Code
GIT

#8 ignore udf_example.so in badfuncs check
Merged 2 years ago by mschorm. Opened 2 years ago by zmiklank.
rpms/ zmiklank/community-mysql ignore_udf_example_in_badfuncs_check  into  rawhide

file added
+5 
@@ -0,0 +1,5 @@ 
 

+ badfuncs:
 

+   ignore:
 

+     # udf_example.so can be ignored, as it is an example of how to write loadable functions
 

+     # Loadable functions were formerly know as UDF (User Defined Functions).
 

+     - /usr/lib64/mysql/plugin/udf_example.so

Resolves: #2047868

udf_example.so contains following deprecated functions:
gethostbyaddr
gethostbyname
inet_addr
inet_ntoa

The udf_example.so can be ignored from badfuncs check, because it is an
exemplary file, showing users how to write own loadable functions. Even
though code from this .so can be used in mysql server, it needs to be
manually loaded by the user.

Deprecated functions have been reported upstream [1].

[1] https://bugs.mysql.com/bug.php?id=106797

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

I'd love to get this comment extended a little so it is more straightforward to understand.

... as it is an exemplary file for UDF
This *.so file is only an example of how UDF (User Defined Functions) can be compiled and used in MySQL server.

If possible, I'd also advise to move the comment near the rule itself, so it won't be confusing once more rules are added

   ignore:
      # Comment to rule 1
     - /usr/lib64/mysql/plugin/udf_example.so
      # Comment to rule 2
     - /usr/...rule_2
     ...

rebased onto af0f2ea
2 years ago

Thanks for the note, because UDF is not a proper naming of those functions anymore[1] and I had it written incorrectly.
I updated the PR. Hope the comment is now more understandable.

[1] https://dev.mysql.com/doc/extending-mysql/8.0/en/adding-functions.html

Thanks for the note, because UDF is not a proper naming of those functions anymore[1]

That is an interesting piece of information.
I'd like not to lose it. Would you please extend the comment with it ?

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

rebased onto db25bd6
2 years ago

That is an interesting piece of information.
I'd like not to lose it. Would you please extend the comment with it ?

Yes, updated.

Perfect, thanks !

Pull-Request has been merged by mschorm
2 years ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
Metadata
None
No Tags
Changes Summary 1
+5
file added
rpminspect.yaml
Powered by Pagure 5.13.3
Documentation • File an Issue • About this Instance • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.