|
|
da2616f |
From 4bc8b4ec9579e7c015a6ad5b41031c850596e0fb Mon Sep 17 00:00:00 2001
|
|
|
0898a53 |
From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= <zbyszek@in.waw.pl>
|
|
|
0898a53 |
Date: Fri, 21 Sep 2018 10:23:39 +0200
|
|
|
0898a53 |
Subject: [PATCH] Fix failing tests in test_api.py
|
|
|
0898a53 |
MIME-Version: 1.0
|
|
|
0898a53 |
Content-Type: text/plain; charset=UTF-8
|
|
|
0898a53 |
Content-Transfer-Encoding: 8bit
|
|
|
0898a53 |
|
|
|
0898a53 |
Based on commit 0722e2edc93ae818bddd18f23be5b18c3a2a1d55 by
|
|
|
0898a53 |
Kale Franz <kfranz@continuum.io>.
|
|
|
0898a53 |
|
|
|
0898a53 |
Signed-off-by: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
|
|
|
0898a53 |
---
|
|
|
da2616f |
tests/test_api.py | 17 +++++++++--------
|
|
|
da2616f |
1 file changed, 9 insertions(+), 8 deletions(-)
|
|
|
0898a53 |
|
|
|
0898a53 |
diff --git a/tests/test_api.py b/tests/test_api.py
|
|
|
da2616f |
index 3ca97be734..e866e82fd3 100644
|
|
|
0898a53 |
--- a/tests/test_api.py
|
|
|
0898a53 |
+++ b/tests/test_api.py
|
|
|
da2616f |
@@ -224,7 +224,7 @@ def test_PackageCacheData_return_value_contract():
|
|
|
da2616f |
assert all(isinstance(pcrec, PackageCacheRecord) for pcrec in iter_records_result)
|
|
|
0898a53 |
|
|
|
da2616f |
is_writable_result = pc.is_writable
|
|
|
da2616f |
- assert is_writable_result is True or is_writable_result is False
|
|
|
da2616f |
+ assert is_writable_result in {True, False, None}
|
|
|
0898a53 |
|
|
|
da2616f |
first_writable_result = PackageCacheData.first_writable()
|
|
|
da2616f |
assert isinstance(first_writable_result, PackageCacheData)
|
|
|
da2616f |
@@ -269,20 +269,21 @@ def test_PrefixData_contract():
|
|
|
0898a53 |
def test_PrefixData_return_value_contract():
|
|
|
0898a53 |
pd = PrefixData(context.conda_prefix)
|
|
|
0898a53 |
|
|
|
0898a53 |
- single_prefix_rec = next(pd.iter_records())
|
|
|
da2616f |
- get_result = pd.get(PackageRecord.from_objects(single_prefix_rec))
|
|
|
0898a53 |
- assert isinstance(get_result, PrefixRecord)
|
|
|
0898a53 |
+ single_prefix_rec = next(pd.iter_records(), None)
|
|
|
0898a53 |
+ if single_prefix_rec:
|
|
|
da2616f |
+ get_result = pd.get(PackageRecord.from_objects(single_prefix_rec))
|
|
|
0898a53 |
+ assert isinstance(get_result, PrefixRecord)
|
|
|
0898a53 |
|
|
|
0898a53 |
- query_result = pd.query('openssl')
|
|
|
0898a53 |
- assert isinstance(query_result, tuple)
|
|
|
0898a53 |
- assert all(isinstance(prefix_rec, PrefixRecord) for prefix_rec in query_result)
|
|
|
0898a53 |
+ query_result = pd.query('openssl')
|
|
|
0898a53 |
+ assert isinstance(query_result, tuple)
|
|
|
0898a53 |
+ assert all(isinstance(prefix_rec, PrefixRecord) for prefix_rec in query_result)
|
|
|
0898a53 |
|
|
|
0898a53 |
iter_records_result = pd.iter_records()
|
|
|
0898a53 |
assert isiterable(iter_records_result)
|
|
|
0898a53 |
assert all(isinstance(prefix_rec, PrefixRecord) for prefix_rec in iter_records_result)
|
|
|
0898a53 |
|
|
|
0898a53 |
is_writable_result = pd.is_writable
|
|
|
0898a53 |
- assert is_writable_result is True or is_writable_result is False
|
|
|
0898a53 |
+ assert is_writable_result in {True, False, None}
|
|
|
0898a53 |
|
|
|
0898a53 |
reload_result = pd.reload()
|
|
|
0898a53 |
assert isinstance(reload_result, PrefixData)
|
|
|
0898a53 |
--
|
|
|
da2616f |
2.19.2
|
|
|
0898a53 |
|