#1 Update certwatch.c
Opened 2 months ago by senderek. Modified 2 months ago
rpms/ senderek/crypto-utils master  into  master

file modified
+1 -1

@@ -243,7 +243,7 @@ 

  

      if (!name) return -1;

  

-     namelen = strlen(name);

+     namelen = strnlen(name, bufsiz-1);

      if (bufsiz < namelen+1) return -1;

  

      strncpy(buf, name, namelen);

The package failed to build due to a warning about a output string being truncated. Using strnlen instead of strlen resolves this issue.

FYI - I have orphaned crypto-utils, if you want to take it please feel free but I'd be happy letting the package die in peace.

Well, I submitted the patch as a secure way to make this package build again, but I've decided against taking the package, because having looked at the source, it seemed that certwatch itself isn't the major problem but the genkey program relies on an ancient crypto library that is very much inaccessible to me. I'm of the opinion that in order to bring this package forward too much of it has to be rewritten. Or - leave it as it is - with no commitment for future code changes. Both options are not too attractive to me.

Metadata