#2 Remove obsolete boost-python3-devel build dependency (#2100748)
Closed a year ago by kdudka. Opened a year ago by jwakely.
rpms/ jwakely/csdiff rawhide  into  rawhide

file modified
+6 -4
@@ -10,7 +10,7 @@ 

  

  Name:       csdiff

  Version:    2.6.0

- Release:    1%{?dist}

+ Release:    2%{?dist}

  Summary:    Non-interactive tools for processing code scan results in plain-text

  

  License:    GPLv3+
@@ -44,9 +44,6 @@ 

  %if %{with python2}

  %package -n python2-%{name}

  Summary:        Python interface to csdiff for Python 2

- %if 0%{?fedora}

- BuildRequires:  boost-python2-devel

- %endif

  BuildRequires:  python2-devel

  %{?python_provide:%python_provide python2-%{name}}

  
@@ -59,12 +56,14 @@ 

  %package -n python3-%{name}

  Summary:        Python interface to csdiff for Python 3

  

+ %if 0%{?rhel} <= 8

  # this packages redefines %%{python3_pkgversion} to 36 because there is

  # no boost-python3-devel in epel-7 buildroot, only boost-python36-devel

  %if 0%{?rhel} == 7

  BuildRequires:  epel-rpm-macros

  %endif

  BuildRequires:  boost-python%{python3_pkgversion}-devel

You could probably simplify this by just requiring boost-python36-devel on rhel7 and boost-python3-devel on rhel8, without using the epel-rpm-macros package and the python3_pkgversion macro.

+ %endif

  BuildRequires:  python3-devel

  %{?python_provide:%python_provide python3-%{name}}

  
@@ -144,6 +143,9 @@ 

  %endif

  

  %changelog

+ * Fri Jun 24 2022 Jonathan Wakely <jwakely@redhat.com> - 2.6.0-2

+ - Remove obsolete boost-python3-devel build dependency (#2100748)

+ 

  * Tue Jun 21 2022 Kamil Dudka <kdudka@redhat.com> 2.6.0-1

  - update to latest upstream release

  

The boost-python3-devel package was removed for Fedora 33, you should just use boost-devel in Fedora and RHEL 9.

The with_python2 support doesn't need to care about fedora, because there is no Python2 in Fedora.

rebased onto 3a3b8f3

a year ago

You could probably simplify this by just requiring boost-python36-devel on rhel7 and boost-python3-devel on rhel8, without using the epel-rpm-macros package and the python3_pkgversion macro.

Thanks for heads up! @lzaoral already fixed it upstream yesterday via https://github.com/csutils/csdiff/pull/60 I will cherry-pick the fix from there.

Pull-Request has been closed by kdudka

a year ago
Metadata