611cccd
diff -up cups-1.6.1/notifier/dbus.c.dbus-utf8 cups-1.6.1/notifier/dbus.c
611cccd
--- cups-1.6.1/notifier/dbus.c.dbus-utf8	2012-01-20 19:00:32.000000000 +0000
65ecaf3
+++ cups-1.6.1/notifier/dbus.c	2012-10-31 11:04:47.686973616 +0000
65ecaf3
@@ -31,6 +31,9 @@
611cccd
 #include <sys/stat.h>
611cccd
 #include <sys/types.h>
611cccd
 #include <unistd.h>
611cccd
+#include <assert.h>
65ecaf3
+#include <locale.h>
611cccd
+#include <wchar.h>
611cccd
 
611cccd
 #ifdef HAVE_DBUS
611cccd
 #  include <dbus/dbus.h>
65ecaf3
@@ -157,10 +160,82 @@ enum
611cccd
  * Local functions...
611cccd
  */
611cccd
 
611cccd
-static int	acquire_lock(int *fd, char *lockfile, size_t locksize);
611cccd
+static int		acquire_lock(int *fd, char *lockfile, size_t locksize);
611cccd
+static const char	*validate_utf8(const char *str);
611cccd
 
611cccd
 
611cccd
 /*
611cccd
+ * 'validate_utf8()' - Convert to valid UTF-8
611cccd
+ */
611cccd
+
611cccd
+static const char *
611cccd
+validate_utf8 (const char *str)
611cccd
+{
611cccd
+  static char *buffer = NULL;
611cccd
+  static size_t buflen = 0;
611cccd
+  char *p;
611cccd
+  size_t str_len;
611cccd
+  unsigned int i;
611cccd
+  mbstate_t instate, outstate;
611cccd
+
611cccd
+  if (str == NULL)
611cccd
+  {
611cccd
+    free (buffer);
611cccd
+    return (NULL);
611cccd
+  }
611cccd
+
611cccd
+  /* Is it already valid? */
611cccd
+  if (mbstowcs (NULL, str, 0) != (size_t) -1)
611cccd
+    return str;
611cccd
+
611cccd
+  /* Make sure our buffer is at least as large as the input string */
611cccd
+  str_len = strlen (str);
611cccd
+  if (str_len > buflen)
611cccd
+  {
65ecaf3
+    if (buffer == NULL)
65ecaf3
+      /* Set encoding type to UTF-8 the first time we need to */
65ecaf3
+      setlocale (LC_CTYPE, "en_US.UTF-8");
65ecaf3
+
611cccd
+    buflen = str_len + 1;
611cccd
+    buffer = realloc (buffer, buflen);
611cccd
+  }
611cccd
+
611cccd
+  memset (&instate, '\0', sizeof (mbstate_t));
611cccd
+  memset (&outstate, '\0', sizeof (mbstate_t));
611cccd
+  p = buffer;
611cccd
+  i = 0;
611cccd
+  while (i < str_len)
611cccd
+  {
611cccd
+    wchar_t wc;
611cccd
+    size_t used, written;
611cccd
+    mbstate_t orig_instate = instate;
611cccd
+    used = mbrtowc (&wc, str + i, str_len - i, &instate);
611cccd
+    switch (used)
611cccd
+    {
611cccd
+    case (size_t) -2:
611cccd
+    case (size_t) -1:
611cccd
+      wc = L'?'; /* so replacement is never longer than original char */
611cccd
+      instate = orig_instate;
611cccd
+      /* fallthru */
611cccd
+    case 0:
611cccd
+      used = 1;
611cccd
+    }
611cccd
+
611cccd
+    written = wcrtomb (p, wc, &outstate);
611cccd
+    if (written != -1)
611cccd
+    {
611cccd
+      p += written;
611cccd
+      assert (p - buffer < buflen);
611cccd
+    }
611cccd
+
611cccd
+    i += used;
611cccd
+  }
611cccd
+
611cccd
+  *p = '\0';
65ecaf3
+  return buffer;
611cccd
+}
611cccd
+
611cccd
+/*
611cccd
  * 'main()' - Read events and send DBUS notifications.
611cccd
  */
611cccd
 
65ecaf3
@@ -366,7 +441,7 @@ main(int  argc,				/* I - Number of comm
611cccd
     attr = ippFindAttribute(msg, "notify-text", IPP_TAG_TEXT);
611cccd
     if (attr)
611cccd
     {
611cccd
-      const char *val = ippGetString(attr, 0, NULL);
611cccd
+      const char *val = validate_utf8 (ippGetString(attr, 0, NULL));
611cccd
       if (!dbus_message_iter_append_string(&iter, &val))
611cccd
         goto bail;
611cccd
     }
65ecaf3
@@ -530,7 +605,7 @@ main(int  argc,				/* I - Number of comm
611cccd
       attr = ippFindAttribute(msg, "job-name", IPP_TAG_NAME);
611cccd
       if (attr)
611cccd
       {
611cccd
-        const char *val = ippGetString(attr, 0, NULL);
611cccd
+        const char *val = validate_utf8 (ippGetString(attr, 0, NULL));
611cccd
         if (!dbus_message_iter_append_string(&iter, &val))
611cccd
           goto bail;
611cccd
       }