#2 Check if group/user "dbus" exists instead of the id (81).
Closed 4 years ago by jbrielmaier. Opened 4 years ago by jbrielmaier.
Unknown source master  into  master

file modified
+2 -2
@@ -56,11 +56,11 @@

  

  %pre

  # create dbus user and group

- getent group %{dbus_user_id} >/dev/null || \

+ getent group dbus >/dev/null || \

          /usr/sbin/groupadd \

                  -g %{dbus_user_id} \

                  -r dbus

- getent passwd %{dbus_user_id} >/dev/null || \

+ getent passwd dbus >/dev/null || \

          /usr/sbin/useradd \

                  -c 'System message bus' \

                  -u %{dbus_user_id} \

This is a workaround for #1717925 and tested succesfull with Fedora Rawhide on the OpenBuildService.

If you have a better idea how to fix this issue, I'm open to drop this PR :)

Somehow I couldn't push to my fork so I created this commit in the WebUI :P

I think there might be a problem with the scriptlet as a whole. The version that exists in dbus-daemon looks different:

%pre daemon
# Add the "dbus" user and group
getent group dbus >/dev/null || groupadd -f -g %{dbus_user_uid} -r dbus
if ! getent passwd dbus >/dev/null ; then
    if ! getent passwd %{dbus_user_uid} >/dev/null ; then
      useradd -r -u %{dbus_user_uid} -g %{dbus_user_uid} -d '/' -s /sbin/nologin -c "System message bus" dbus
    else
      useradd -r -g %{dbus_user_uid} -d '/' -s /sbin/nologin -c "System message bus" dbus
    fi
fi
exit 0

I think there might be a problem with the scriptlet as a whole. The version that exists in dbus-daemon looks different:
[...]

This version also resolves the issue, I tested it. Should I update the PR to this variant?

I'm not tight to any solution, I just wanna see this issue fixed :)

Yeah, update this PR to this variant.

@jbrielmaier Please amend the commit to use the proposed scriptlet.

@jbrielmaier As for how to push to your own fork while being not being a packager, there's some special instructions: https://fedoraproject.org/wiki/Infrastructure/HTTPS-commits

Closing in favour of https://src.fedoraproject.org/rpms/dbus-broker/pull-request/3.

@ngompa There is no fedpkg on openSUSE, so I did it again over the WebUI :P

Pull-Request has been closed by jbrielmaier

4 years ago
Metadata