|
|
7b69e54 |
diff -up dhcp-4.3.1b1/client/dhc6.c.mRfpsB dhcp-4.3.1b1/client/dhc6.c
|
|
|
7b69e54 |
--- dhcp-4.3.1b1/client/dhc6.c.mRfpsB 2014-07-10 17:48:03.779424870 +0200
|
|
|
7b69e54 |
+++ dhcp-4.3.1b1/client/dhc6.c 2014-07-10 17:48:03.795424644 +0200
|
|
|
7b69e54 |
@@ -5088,7 +5088,8 @@ make_client6_options(struct client_state
|
|
|
e83fb19 |
*/
|
|
|
e83fb19 |
if ((oc = lookup_option(&dhcpv6_universe, *op,
|
|
|
e83fb19 |
D6O_CLIENTID)) == NULL) {
|
|
|
e83fb19 |
- if (!option_cache(&oc, &default_duid, NULL, clientid_option,
|
|
|
e83fb19 |
+ if (default_duid.len == 0 ||
|
|
|
e83fb19 |
+ !option_cache(&oc, &default_duid, NULL, clientid_option,
|
|
|
e83fb19 |
MDL))
|
|
|
e83fb19 |
log_fatal("Failure assembling a DUID.");
|
|
|
e83fb19 |
|
|
|
7b69e54 |
diff -up dhcp-4.3.1b1/client/dhclient.c.mRfpsB dhcp-4.3.1b1/client/dhclient.c
|
|
|
7b69e54 |
--- dhcp-4.3.1b1/client/dhclient.c.mRfpsB 2014-07-10 17:39:25.853763858 +0200
|
|
|
7b69e54 |
+++ dhcp-4.3.1b1/client/dhclient.c 2014-07-10 17:49:49.882925843 +0200
|
|
|
7b69e54 |
@@ -948,8 +948,8 @@ main(int argc, char **argv) {
|
|
|
e83fb19 |
if (default_duid.buffer != NULL)
|
|
|
e83fb19 |
data_string_forget(&default_duid, MDL);
|
|
|
e83fb19 |
|
|
|
e83fb19 |
- form_duid(&default_duid, MDL);
|
|
|
e83fb19 |
- write_duid(&default_duid);
|
|
|
e83fb19 |
+ if (form_duid(&default_duid, MDL) == ISC_R_SUCCESS)
|
|
|
e83fb19 |
+ write_duid(&default_duid);
|
|
|
e83fb19 |
}
|
|
|
e83fb19 |
}
|
|
|
e83fb19 |
|
|
|
7b69e54 |
@@ -3267,7 +3267,7 @@ write_options(struct client_state *clien
|
|
|
76c2a1e |
* is not how it is intended. Upcoming rearchitecting the client should
|
|
|
76c2a1e |
* address this "one daemon model."
|
|
|
76c2a1e |
*/
|
|
|
76c2a1e |
-void
|
|
|
76c2a1e |
+isc_result_t
|
|
|
76c2a1e |
form_duid(struct data_string *duid, const char *file, int line)
|
|
|
76c2a1e |
{
|
|
|
76c2a1e |
struct interface_info *ip;
|
|
|
7b69e54 |
@@ -3280,6 +3280,15 @@ form_duid(struct data_string *duid, cons
|
|
|
76c2a1e |
if (ip == NULL)
|
|
|
76c2a1e |
log_fatal("Impossible condition at %s:%d.", MDL);
|
|
|
76c2a1e |
|
|
|
76c2a1e |
+ while (ip && ip->hw_address.hbuf[0] == HTYPE_RESERVED) {
|
|
|
76c2a1e |
+ /* Try the other interfaces */
|
|
|
76c2a1e |
+ log_debug("Cannot form default DUID from interface %s.", ip->name);
|
|
|
76c2a1e |
+ ip = ip->next;
|
|
|
76c2a1e |
+ }
|
|
|
76c2a1e |
+ if (ip == NULL) {
|
|
|
76c2a1e |
+ return ISC_R_UNEXPECTED;
|
|
|
76c2a1e |
+ }
|
|
|
76c2a1e |
+
|
|
|
76c2a1e |
if ((ip->hw_address.hlen == 0) ||
|
|
|
76c2a1e |
(ip->hw_address.hlen > sizeof(ip->hw_address.hbuf)))
|
|
|
76c2a1e |
log_fatal("Impossible hardware address length at %s:%d.", MDL);
|
|
|
7b69e54 |
@@ -3323,6 +3332,8 @@ form_duid(struct data_string *duid, cons
|
|
|
7b69e54 |
log_info("Created duid %s.", str);
|
|
|
7b69e54 |
dfree(str, MDL);
|
|
|
76c2a1e |
}
|
|
|
e83fb19 |
+
|
|
|
76c2a1e |
+ return ISC_R_SUCCESS;
|
|
|
76c2a1e |
}
|
|
|
76c2a1e |
|
|
|
e83fb19 |
/* Write the default DUID to the lease store. */
|
|
|
7b69e54 |
diff -up dhcp-4.3.1b1/common/bpf.c.mRfpsB dhcp-4.3.1b1/common/bpf.c
|
|
|
7b69e54 |
--- dhcp-4.3.1b1/common/bpf.c.mRfpsB 2014-07-10 17:39:25.797764653 +0200
|
|
|
7b69e54 |
+++ dhcp-4.3.1b1/common/bpf.c 2014-07-10 17:48:03.797424616 +0200
|
|
|
7b69e54 |
@@ -600,6 +600,22 @@ get_hw_addr(const char *name, struct har
|
|
|
76c2a1e |
memcpy(&hw->hbuf[1], LLADDR(sa), sa->sdl_alen);
|
|
|
76c2a1e |
break;
|
|
|
76c2a1e |
#endif /* IFT_FDDI */
|
|
|
76c2a1e |
+#if defined(IFT_PPP)
|
|
|
76c2a1e |
+ case IFT_PPP:
|
|
|
76c2a1e |
+ if (local_family != AF_INET6)
|
|
|
76c2a1e |
+ log_fatal("Unsupported device type %d for \"%s\"",
|
|
|
76c2a1e |
+ sa->sdl_type, name);
|
|
|
76c2a1e |
+ hw->hlen = 0;
|
|
|
76c2a1e |
+ hw->hbuf[0] = HTYPE_RESERVED;
|
|
|
76c2a1e |
+ /* 0xdeadbeef should never occur on the wire,
|
|
|
76c2a1e |
+ * and is a signature that something went wrong.
|
|
|
76c2a1e |
+ */
|
|
|
76c2a1e |
+ hw->hbuf[1] = 0xde;
|
|
|
76c2a1e |
+ hw->hbuf[2] = 0xad;
|
|
|
76c2a1e |
+ hw->hbuf[3] = 0xbe;
|
|
|
76c2a1e |
+ hw->hbuf[4] = 0xef;
|
|
|
76c2a1e |
+ break;
|
|
|
76c2a1e |
+#endif
|
|
|
76c2a1e |
default:
|
|
|
76c2a1e |
log_fatal("Unsupported device type %d for \"%s\"",
|
|
|
76c2a1e |
sa->sdl_type, name);
|
|
|
7b69e54 |
diff -up dhcp-4.3.1b1/common/lpf.c.mRfpsB dhcp-4.3.1b1/common/lpf.c
|
|
|
7b69e54 |
--- dhcp-4.3.1b1/common/lpf.c.mRfpsB 2014-07-10 17:39:25.744765404 +0200
|
|
|
7b69e54 |
+++ dhcp-4.3.1b1/common/lpf.c 2014-07-10 17:48:03.797424616 +0200
|
|
|
e83fb19 |
@@ -511,6 +511,22 @@ get_hw_addr(const char *name, struct har
|
|
|
76c2a1e |
hw->hbuf[0] = HTYPE_FDDI;
|
|
|
c72a792 |
memcpy(&hw->hbuf[1], sa->sa_data, 6);
|
|
|
76c2a1e |
break;
|
|
|
76c2a1e |
+#if defined(ARPHRD_PPP)
|
|
|
76c2a1e |
+ case ARPHRD_PPP:
|
|
|
76c2a1e |
+ if (local_family != AF_INET6)
|
|
|
76c2a1e |
+ log_fatal("Unsupported device type %d for \"%s\"",
|
|
|
76c2a1e |
+ sa->sa_family, name);
|
|
|
76c2a1e |
+ hw->hlen = 0;
|
|
|
76c2a1e |
+ hw->hbuf[0] = HTYPE_RESERVED;
|
|
|
76c2a1e |
+ /* 0xdeadbeef should never occur on the wire,
|
|
|
76c2a1e |
+ * and is a signature that something went wrong.
|
|
|
76c2a1e |
+ */
|
|
|
76c2a1e |
+ hw->hbuf[1] = 0xde;
|
|
|
76c2a1e |
+ hw->hbuf[2] = 0xad;
|
|
|
76c2a1e |
+ hw->hbuf[3] = 0xbe;
|
|
|
76c2a1e |
+ hw->hbuf[4] = 0xef;
|
|
|
76c2a1e |
+ break;
|
|
|
76c2a1e |
+#endif
|
|
|
76c2a1e |
default:
|
|
|
76c2a1e |
log_fatal("Unsupported device type %ld for \"%s\"",
|
|
|
76c2a1e |
(long int)sa->sa_family, name);
|
|
|
7b69e54 |
diff -up dhcp-4.3.1b1/includes/dhcpd.h.mRfpsB dhcp-4.3.1b1/includes/dhcpd.h
|
|
|
7b69e54 |
--- dhcp-4.3.1b1/includes/dhcpd.h.mRfpsB 2014-07-10 17:48:03.761425124 +0200
|
|
|
7b69e54 |
+++ dhcp-4.3.1b1/includes/dhcpd.h 2014-07-10 17:48:03.798424601 +0200
|
|
|
7b69e54 |
@@ -2839,7 +2839,7 @@ void client_dns_remove(struct client_sta
|
|
|
e83fb19 |
|
|
|
e83fb19 |
void dhcpv4_client_assignments(void);
|
|
|
e83fb19 |
void dhcpv6_client_assignments(void);
|
|
|
e83fb19 |
-void form_duid(struct data_string *duid, const char *file, int line);
|
|
|
e83fb19 |
+isc_result_t form_duid(struct data_string *duid, const char *file, int line);
|
|
|
e83fb19 |
|
|
|
e83fb19 |
/* dhc6.c */
|
|
|
e83fb19 |
void dhc6_lease_destroy(struct dhc6_lease **src, const char *file, int line);
|
|
|
7b69e54 |
diff -up dhcp-4.3.1b1/includes/dhcp.h.mRfpsB dhcp-4.3.1b1/includes/dhcp.h
|
|
|
7b69e54 |
--- dhcp-4.3.1b1/includes/dhcp.h.mRfpsB 2014-07-10 17:48:03.761425124 +0200
|
|
|
7b69e54 |
+++ dhcp-4.3.1b1/includes/dhcp.h 2014-07-10 17:48:03.798424601 +0200
|
|
|
7b69e54 |
@@ -81,6 +81,8 @@ struct dhcp_packet {
|
|
|
7b69e54 |
* is no standard for this so we
|
|
|
7b69e54 |
* just steal a type */
|
|
|
7b69e54 |
|
|
|
7b69e54 |
+#define HTYPE_RESERVED 0 /* RFC 5494 */
|
|
|
7b69e54 |
+
|
|
|
7b69e54 |
/* Magic cookie validating dhcp options field (and bootp vendor
|
|
|
7b69e54 |
extensions field). */
|
|
|
7b69e54 |
#define DHCP_OPTIONS_COOKIE "\143\202\123\143"
|
|
|
7b69e54 |
diff -up dhcp-4.3.1b1/server/dhcpv6.c.mRfpsB dhcp-4.3.1b1/server/dhcpv6.c
|
|
|
7b69e54 |
--- dhcp-4.3.1b1/server/dhcpv6.c.mRfpsB 2014-07-10 17:47:31.464881409 +0200
|
|
|
7b69e54 |
+++ dhcp-4.3.1b1/server/dhcpv6.c 2014-07-10 17:48:03.800424573 +0200
|
|
|
7b69e54 |
@@ -330,6 +330,9 @@ generate_new_server_duid(void) {
|
|
|
76c2a1e |
if (p->hw_address.hlen > 0) {
|
|
|
76c2a1e |
break;
|
|
|
76c2a1e |
}
|
|
|
76c2a1e |
+ if (p->next == NULL && p->hw_address.hbuf[0] == HTYPE_RESERVED) {
|
|
|
76c2a1e |
+ log_error("Can not generate DUID from interfaces which do not have hardware addresses, please configure server-duid!");
|
|
|
76c2a1e |
+ }
|
|
|
76c2a1e |
}
|
|
|
76c2a1e |
if (p == NULL) {
|
|
|
76c2a1e |
return ISC_R_UNEXPECTED;
|