PR#1: Remove unnecessary dependencies - rpms/dialect

rpms / dialect

#1 Remove unnecessary dependencies

Merged 2 years ago by lyessaadi. Opened 2 years ago by xfgusta.

rpms/ xfgusta/dialect rawhide into rawhide

Update spec

Gustavo Costa • 2 years ago

a51c963

Remove unnecessary dependencies

Gustavo Costa • 2 years ago

e28315d

dialect.spec

file modified

+4 -5

		`@@ -3,7 +3,7 @@`

		`Name: dialect`
		`Version: 1.3.0`
		`- Release: 1%{?dist}`
		`+ Release: 2%{?dist}`
		`Summary: A translation app for GNOME based on Google Translate`

		`%global tag %{version}`
		`@@ -23,10 +23,6 @@`
		`BuildRequires: libhandy1-devel`
		`BuildRequires: python3-devel`
		`BuildRequires: python3-gobject-devel`
		`- BuildRequires: python3dist(dbus-python)`
		`- BuildRequires: python3dist(googletrans)`
		`- BuildRequires: python3dist(gtts)`
		`- BuildRequires: python3dist(httpx)`

		`Requires: hicolor-icon-theme`
		`Requires: gstreamer1-plugins-base`
		`@@ -83,6 +79,9 @@`


		`%changelog`
		`+ * Tue Jul 06 2021 Gustavo Costa <xfgusta@fedoraproject.org> - 1.3.0-2`
		`+ - Remove unnecessary dependencies`
		`+`
		`* Sat May 08 2021 Lyes Saadi <fedora@lyes.eu> - 1.3.0-1`
		`- Updating to 1.3.0 (Fix #1958511)`

xfgusta commented 2 years ago

The dbus-python, googletrans, gtts, and httpx are runtime dependencies. They are not necessary to build dialect. Also, libhandy1 is a library and is not required (library dependencies are managed automatically).

lyessaadi commented 2 years ago

They are not necessary to build dialect.

Good point, they are necessary for python packages with some sort of testing, but I guess here it is unnecessary. I guess it also helps by preventing broken versions of dialect to build due to dependency issues, but there's also other ways to check that (by testing the installation process for example, which I always do anyway).

Also, libhandy1 is a library and is not required (library dependencies are managed automatically).

This does not work with python packages (and noarch in general). The automatic dependencies are generated from the symbols of a binary IIRC. Python, by not generating compiled binaries, and using an interpreter, can not do that.

You can check that by getting the rpm generated by koji and doing:

rpm -q --requires dialect-1.3.0-2.fc35.noarch.rpm

You will see that libhandy1 is indeed missing.

I will happily merge this PR if you can remove the libhandy1 change :smile: !

Thank you for this contribution!

1 new commit added

Update spec

2 years ago

xfgusta commented 2 years ago

Hi Lyes. Thank you for clarifying about the libhandy1. At least I learned something :blush:

lyessaadi commented 2 years ago

Thank you for this merge request!

I won't build it yet, though, as it only affects build dependencies. But in the next dialect update (which is coming soon), your contribution will be there :tada:!