#14 Optimize systemd dependency for containers
Closed 3 years ago by amatej. Opened 4 years ago by bogdando.
https://github.com/bogdando/rpms-dnf.git bz/1671362  into  master

Optimize systemd dependency for containers
Bogdan Dobrelya • 4 years ago  
file modified
+7 -3
@@ -73,7 +73,7 @@


  Name:           dnf

  Version:        4.0.10

- Release:        1%{?dist}

+ Release:        2%{?dist}

  Summary:        %{pkg_summary}

  # For a breakdown of the licensing, see PACKAGE-LICENSING

  License:        GPLv2+ and GPLv2 and GPL
@@ -102,7 +102,7 @@


  Recommends:     (%{_bindir}/sqlite3 if bash-completion)


- %{?systemd_requires}

+ %{?systemd_ordering}

  Provides:       dnf-command(alias)

  Provides:       dnf-command(autoremove)

  Provides:       dnf-command(check-update)
@@ -256,7 +256,7 @@

  Summary:        %{pkg_summary} - automated upgrades

  BuildRequires:  systemd

  Requires:       %{name} = %{version}-%{release}

- %{?systemd_requires}

+ %{?systemd_ordering}


  %description automatic

  Systemd units that can periodically download package upgrades and apply them.
@@ -499,6 +499,10 @@




+ * Thu Jan 31 2019 Bogdan Dobrelia <bdobreli@redhat.com> - 4.0.10-2

+ - Use %%systemd_ordering

+ - Resolves: rhbz#1671362


  * Wed Dec 12 2018 Jaroslav Mracek <jmracek@redhat.com> - 4.0.10-1

  - Update to 4.0.10

  - Updated difference YUM vs. DNF for yum-updateonboot

no initial comment

According to https://fedoraproject.org/wiki/Packaging:Scriptlets:
If a package is suitable for installation without systemd (in a
container image, for example) and does not require any of the
systemd mechanisms such as tmpfiles.d, then the systemd_ordering macro
MAY be used instead of the systemd_requires macro.

That is exactly the case we want to address for container images
when installing packages in it.

I believe this PR is no longer relevant for several reasons.

Mainly the %{?systemd_requires} have since been removed and are only present in the dnf-automatic package. But also in addition this PR was made in upstream as well https://github.com/rpm-software-management/dnf/pull/1315 where it was decided the changes are not desired.


Pull-Request has been closed by amatej

3 years ago