PR#17: Drop %systemd_requires from main package - rpms/dnf

rpms / dnf

#17 Drop %systemd_requires from main package

Merged 3 years ago by dmach. Opened 3 years ago by ignatenkobrain.

rpms/ ignatenkobrain/dnf systemd into master

Drop %systemd_requires from main package

Igor Gnatenko • 3 years ago

faa199f

dnf.spec

file modified

+4 -2

		`@@ -80,7 +80,7 @@`

		`Name: dnf`
		`Version: 4.2.7`
		`- Release: 3%{?dist}`
		`+ Release: 4%{?dist}`
		`Summary: %{pkg_summary}`
		`# For a breakdown of the licensing, see PACKAGE-LICENSING`
		`License: GPLv2+ and GPLv2 and GPL`
		`@@ -122,7 +122,6 @@`
		`%endif`
		`Recommends: (%{_bindir}/sqlite3 if bash-completion)`
		`%endif`
		`- %{?systemd_requires}`
		`Provides: dnf-command(alias)`
		`Provides: dnf-command(autoremove)`
		`Provides: dnf-command(check-update)`
		`@@ -514,6 +513,9 @@`
		`%endif`

		`%changelog`
		`+ * Mon Aug 12 2019 Igor Gnatenko <ignatenkobrain@fedoraproject.org> - 4.2.7-4`
		`+ - Drop %%systemd_requires from main package`
		`+`
		`* Wed Jul 24 2019 Fedora Release Engineering <releng@fedoraproject.org> - 4.2.7-3`
		`- Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild`

ignatenkobrain commented 3 years ago

DNF can work just fine without systemd, even though there are some
services (dnf-makecache.{service,timer}) which enhance DNF.

Signed-off-by: Igor Gnatenko ignatenkobrain@fedoraproject.org

rebased onto d941127

3 years ago

rebased onto 67379ac

3 years ago

rebased onto faa199f

3 years ago

ignatenkobrain commented 3 years ago

cc @cverna @zbyszek

zbyszek commented 3 years ago

LGTM.

dmach commented 3 years ago

@ignatenkobrain what's the reason behind the change?
Is it a change in packaging that %systemd_requires is no longer necessary?
Or are you suggesting to drop the dependency and if systemd is not present, dnf-makecache.{service,timer} will not work?

ignatenkobrain commented 3 years ago

Is it a change in packaging that %systemd_requires is no longer necessary?

@zbyszek has done this some time ago, yes.

Or are you suggesting to drop the dependency and if systemd is not present, dnf-makecache.{service,timer} will not work?

This too. Basically if you don't have systemd, nothing would start dnf-makecache. But that is not making any bad user experience since DNF can run without it.

dmach commented 3 years ago

Thanks for the details. This makes sense. We don't need systemd in chroots, containers etc. and if a user wants it, he must install it explicitly.