PR#22: Disable deltarpm support in default configuration for Changes/Drop_Delta_RPMs - rpms/dnf

rpms / dnf

#22 Disable deltarpm support in default configuration for Changes/Drop_Delta_RPMs

Merged 3 months ago by jkolarik. Opened 3 months ago by decathorpe.

Unknown source rawhide into rawhide

Disable deltarpm support in default configuration for Changes/Drop_Delta_RPMs

Fabio Valentini • 3 months ago

1512e08

0001-disable-deltarpm-support-in-default-configuration.patch

file added

+21

		`@@ -0,0 +1,21 @@`
		`+ From 910f913185545841bbcf66e695c91532eb2535dc Mon Sep 17 00:00:00 2001`
		`+ From: Fabio Valentini <decathorpe@gmail.com>`
		`+ Date: Sat, 20 Jan 2024 22:28:55 +0100`
		`+ Subject: [PATCH] disable deltarpm support in default configuration`
		`+`
		`+ ---`
		`+ etc/dnf/dnf.conf \| 1 +`
		`+ 1 file changed, 1 insertion(+)`
		`+`
		`+ diff --git a/etc/dnf/dnf.conf b/etc/dnf/dnf.conf`
		`+ index bc665d2..7eecb08 100644`
		`+ --- a/etc/dnf/dnf.conf`
		`+ +++ b/etc/dnf/dnf.conf`
		`+ @@ -6,3 +6,4 @@ installonly_limit=3`
		`+ clean_requirements_on_remove=True`
		`+ best=False`
		`+ skip_if_unavailable=True`
		`+ +deltarpm=False`
		`+ --`
		`+ 2.43.0`
		`+`

dnf.spec

file modified

		`@@ -74,6 +74,10 @@`
		`License: GPL-2.0-or-later AND GPL-1.0-only`
		`URL: https://github.com/rpm-software-management/dnf`
		`Source0: %{url}/archive/%{version}/%{name}-%{version}.tar.gz`
		`+`
		`+ # https://fedoraproject.org/wiki/Changes/Drop_Delta_RPMs`
		`+ Patch: 0001-disable-deltarpm-support-in-default-configuration.patch`
		`+`
		`BuildArch: noarch`
		`BuildRequires: cmake`
		`BuildRequires: gettext`

decathorpe commented 3 months ago

jkolarik commented 3 months ago

Thanks for the patch! The failing test doesn't seem related to this change. I'll check when doing the release.

jkolarik commented 3 months ago

Oh, there is a conflict due to the another recent rebuild. Could you please revisit the PR please? You can drop the version bump as I'll be most probably joining this piece with the upstream changes for the following release where there should be bump to 4.20.

rebased onto 1512e08

3 months ago

decathorpe commented 3 months ago

Thanks, rebased, and dropped the changelog message.