PR#5: Updated to version 4.3.4 - rpms/electrum

rpms / electrum

#5 Updated to version 4.3.4

Merged 2 years ago by js. Opened 2 years ago by xvitaly.

Unknown source new-version into rawhide

Vitaly Zaitsev • 2 years ago

d65b6bb

.gitignore

file modified

		`@@ -60,3 +60,5 @@`
		`/Electrum-4.3.2.tar.gz.asc`
		`/Electrum-4.3.3.tar.gz`
		`/Electrum-4.3.3.tar.gz.asc`
		`+ /Electrum-4.3.4.tar.gz`
		`+ /Electrum-4.3.4.tar.gz.asc`

electrum.spec

file modified

+5 -2

		`@@ -1,6 +1,6 @@`
		`Name: electrum`
		`- Version: 4.3.3`
		`- Release: 2%{?dist}`
		`+ Version: 4.3.4`
		`+ Release: 1%{?dist}`
		`Summary: A lightweight Bitcoin Client`

		`License: MIT`
		`@@ -89,6 +89,9 @@`
		`%{_metainfodir}/%{name}.metainfo.xml`

		`%changelog`
		`+ * Wed Mar 01 2023 Vitaly Zaitsev <vitaly@easycoding.org> - 4.3.4-1`
		`+ - Updated to version 4.3.4.`
		`+`
		`* Thu Jan 19 2023 Fedora Release Engineering <releng@fedoraproject.org> - 4.3.3-2`
		`- Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild`

sources

file modified

+2 -2

		`@@ -1,3 +1,3 @@`
		`SHA512 (gpgkey-electrum.gpg) = 87799a6fcc1adcbae151f0a004f22a1955492e5b6ee68e97682284f6cdab89aa04b48ca118955c427d480e333126fbf05ba0790fd56832eeeb0d6803e7bc0930`
		`- SHA512 (Electrum-4.3.3.tar.gz) = 7238db2a1885f02e272b0c0f8c0311ded256f54353255fd1322ba23d52eda55b965b3cc4a1825538c545aa791f2dc6c9471d0c81b37d66b9afa68c30a13d268e`
		`- SHA512 (Electrum-4.3.3.tar.gz.asc) = 6f69c3239c162d0669c49c3ae16ef9fd487daf6bb940f7ad5e318093c4c9a6c1c45bcf190f9700002df17672cd0d291409a005ec98aa188e835ff205d229f276`
		`+ SHA512 (Electrum-4.3.4.tar.gz) = 000a60d20391bbb348e967173f33b6340a4588d144ce61f02ca8f1f040ecee25a6f297726c8b22e29b0b02dd8d8acdb93fb5606b816fd4c93f5a0d4abeadc9ad`
		`+ SHA512 (Electrum-4.3.4.tar.gz.asc) = 7413be556f02a18b0c825a67cb106c05dd1a0151f414f5da98ef733fb9babb52730a6e9a940c89d2933dc105fc982fcd2e2b23878e33c14f492cdb776dc7af9f`

xvitaly commented 2 years ago

Updated to version 4.3.4.

Please build for all Fedora releases.

js commented 2 years ago

Newer releases of Electrum have questionable copyright (which even the release notes say - tl;dr: has AI-generated code), so this has intentionally not been packaged. This needs to go through Fedora legal. Frankly, since the changes so far were very small, I didn't bother involving Fedora legal yet, though.

xvitaly commented 2 years ago

which even the release notes say - tl;dr: has AI-generated code), so this has intentionally not been packaged

A lot of projects have generated code. As long as they publish such code under the same license, it's not a problem.

js commented 2 years ago

It's definitely not a lot of projects. See https://www.theverge.com/2022/11/8/23446821/microsoft-openai-github-copilot-class-action-lawsuit-ai-copyright-violation-training-data why this is legally problematic. I am sure Red Hat legal has opinions on something where there is an ongoing lawsuit right now.

xvitaly commented 2 years ago

why this is legally problematic

Indeed, but only for proprietary code, because CoPilot was trained on OSS projects and can easily copy-paste snippets under the GPL license. It's not a problem for OSS projects.

xvitaly commented 2 years ago

Posted to Fedora Legal: https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/thread/EYA7TZIZVN43JKFW5M3DSYDHJ7CZK2C2/

js commented 2 years ago

Even if it were from GPL'd code, it would still violate copyright, as GPL requires to mention copyright.

But in this case, it wasn't CoPilot, but ChatGPT. Digging out some more context from IRC logs:

https://twitter.com/salvatoshi/status/1616792476257247233
https://github.com/spesmilo/electrum-http/commit/bde9d3b5fbf34623ca04c14eb6b0db6676c5ec52

I expect this to only become more in the future and not just those 15 lines.

I'll see about adding more context on the fedora legal thread later.

xvitaly commented 2 years ago

@js We're now allowed to push this update.

Please merge and build for all Fedora releases.

js commented 2 years ago