src/

2005-06-09  Roland McGrath  <roland@redhat.com>

	* readelf.c (handle_dynamic, handle_symtab): Check for bogus sh_link.

	(handle_verneed, handle_verdef, handle_versym, handle_hash): Likewise.

	(handle_scngrp): Check for bogus sh_info.

	* strip.c (handle_elf): Check for bogus values in sh_link, sh_info,

	st_shndx, e_shstrndx, and SHT_GROUP or SHT_SYMTAB_SHNDX data.

	Don't use assert on input values, instead bail with "illformed" error.

2005-05-17  Jakub Jelinek  <jakub@redhat.com>

libelf/

	* elf32_getphdr.c (elfw2(LIBELFBITS,getphdr)): Check if program header

	table fits into object's bounds.

	* elf_getshstrndx.c (elf_getshstrndx): Add elf->start_offset to

	elf->map_address.  Check if first section header fits into object's

	bounds.

	* elf32_getshdr.c (elfw2(LIBELFBITS,getshdr)):

	Check if section header table fits into object's bounds.

	* elf_begin.c (get_shnum): Ensure section headers fits into

	object's bounds.

	(file_read_elf): Make sure scncnt is small enough to allocate both

	ElfXX_Shdr and Elf_Scn array.  Make sure section and program header

	tables fit into object's bounds.  Avoid memory leak on failure.

src/

	* elflint.c (check_hash): Don't check entries beyond end of section.

	(check_note): Don't crash if gelf_rawchunk fails.

	(section_name): Return <invalid> if gelf_getshdr returns NULL.

2005-05-14  Jakub Jelinek  <jakub@redhat.com>

libelf/

	* libelfP.h (INVALID_NDX): Define.

	* gelf_getdyn.c (gelf_getdyn): Use it.  Remove ndx < 0 test if any.

	* gelf_getlib.c (gelf_getlib): Likewise.

	* gelf_getmove.c (gelf_getmove): Likewise.

	* gelf_getrel.c (gelf_getrel): Likewise.

	* gelf_getrela.c (gelf_getrela): Likewise.

	* gelf_getsym.c (gelf_getsym): Likewise.

	* gelf_getsyminfo.c (gelf_getsyminfo): Likewise.

	* gelf_getsymshndx.c (gelf_getsymshndx): Likewise.

	* gelf_getversym.c (gelf_getversym): Likewise.

	* gelf_update_dyn.c (gelf_update_dyn): Likewise.

	* gelf_update_lib.c (gelf_update_lib): Likewise.

	* gelf_update_move.c (gelf_update_move): Likewise.

	* gelf_update_rel.c (gelf_update_rel): Likewise.

	* gelf_update_rela.c (gelf_update_rela): Likewise.

	* gelf_update_sym.c (gelf_update_sym): Likewise.

	* gelf_update_syminfo.c (gelf_update_syminfo): Likewise.

	* gelf_update_symshndx.c (gelf_update_symshndx): Likewise.

	* gelf_update_versym.c (gelf_update_versym): Likewise.

	* elf_newscn.c (elf_newscn): Check for overflow.

	* elf32_updatefile.c (__elfw2(LIBELFBITS,updatemmap)): Likewise.

	(__elfw2(LIBELFBITS,updatefile)): Likewise.

	* elf_begin.c (file_read_elf): Likewise.

	* elf32_newphdr.c (elfw2(LIBELFBITS,newphdr)): Likewise.

	* elf_getarsym.c (elf_getarsym): Likewise.

	* elf32_getshdr.c (elfw2(LIBELFBITS,getshdr)): Likewise.

src/

	* elflint.c (section_name): Return "<invalid>" instead of

	crashing on invalid section name.

	(check_symtab, is_rel_dyn, check_rela, check_rel, check_dynamic,

	check_symtab_shndx, check_hash, check_versym): Robustify.

--- elfutils-0.132/src/elflint.c.robustify

+++ elfutils-0.132/src/elflint.c

@@ -126,6 +126,9 @@ static uint32_t shstrndx;

 /* Array to count references in section groups.  */

 static int *scnref;

+/* Number of sections.  */

+static unsigned int shnum;

+

 int

 main (int argc, char *argv[])

@@ -315,10 +318,19 @@ section_name (Ebl *ebl, int idx)

 {

   GElf_Shdr shdr_mem;

   GElf_Shdr *shdr;

+  const char *ret;

+

+  if ((unsigned int) idx > shnum)

+    return "<invalid>";

   shdr = gelf_getshdr (elf_getscn (ebl->elf, idx), &shdr_mem);

+  if (shdr == NULL)

+    return "<invalid>";

-  return elf_strptr (ebl->elf, shstrndx, shdr->sh_name);

+  ret = elf_strptr (ebl->elf, shstrndx, shdr->sh_name);

+  if (ret == NULL)

+    return "<invalid>";

+  return ret;

 }

@@ -340,10 +352,6 @@ static const int valid_e_machine[] =

   (sizeof (valid_e_machine) / sizeof (valid_e_machine[0]))

-/* Number of sections.  */

-static unsigned int shnum;

-

-

 static void

 check_elf_header (Ebl *ebl, GElf_Ehdr *ehdr, size_t size)

 {

@@ -605,7 +613,8 @@ section [%2d] '%s': symbol table cannot 

 	  }

       }

-  if (shdr->sh_entsize != gelf_fsize (ebl->elf, ELF_T_SYM, 1, EV_CURRENT))

+  size_t sh_entsize = gelf_fsize (ebl->elf, ELF_T_SYM, 1, EV_CURRENT);

+  if (shdr->sh_entsize != sh_entsize)

     ERROR (gettext ("\

 section [%2u] '%s': entry size is does not match ElfXX_Sym\n"),

 	   idx, section_name (ebl, idx));

@@ -643,7 +652,7 @@ section [%2d] '%s': XINDEX for zeroth en

 	       xndxscnidx, section_name (ebl, xndxscnidx));

     }

-  for (size_t cnt = 1; cnt < shdr->sh_size / shdr->sh_entsize; ++cnt)

+  for (size_t cnt = 1; cnt < shdr->sh_size / sh_entsize; ++cnt)

     {

       sym = gelf_getsymshndx (data, xndxdata, cnt, &sym_mem, &xndx);

       if (sym == NULL)

@@ -661,7 +670,8 @@ section [%2d] '%s': symbol %zu: invalid 

       else

 	{

 	  name = elf_strptr (ebl->elf, shdr->sh_link, sym->st_name);

-	  assert (name != NULL);

+	  assert (name != NULL

+		  || strshdr->sh_type != SHT_STRTAB);

 	}

       if (sym->st_shndx == SHN_XINDEX)

@@ -991,9 +1001,11 @@ is_rel_dyn (Ebl *ebl, const GElf_Ehdr *e

     {

       GElf_Shdr rcshdr_mem;

       const GElf_Shdr *rcshdr = gelf_getshdr (scn, &rcshdr_mem);

-      assert (rcshdr != NULL);

-      if (rcshdr->sh_type == SHT_DYNAMIC)

+      if (rcshdr == NULL)

+	break;

+

+      if (rcshdr->sh_type == SHT_DYNAMIC && rcshdr->sh_entsize)

 	{

 	  /* Found the dynamic section.  Look through it.  */

 	  Elf_Data *d = elf_getdata (scn, NULL);

@@ -1003,7 +1015,9 @@ is_rel_dyn (Ebl *ebl, const GElf_Ehdr *e

 	    {

 	      GElf_Dyn dyn_mem;

 	      GElf_Dyn *dyn = gelf_getdyn (d, cnt, &dyn_mem);

-	      assert (dyn != NULL);

+

+	      if (dyn == NULL)

+		break;

 	      if (dyn->d_tag == DT_RELCOUNT)

 		{

@@ -1017,7 +1031,9 @@ section [%2d] '%s': DT_RELCOUNT used for

 		      /* Does the number specified number of relative

 			 relocations exceed the total number of

 			 relocations?  */

-		      if (dyn->d_un.d_val > shdr->sh_size / shdr->sh_entsize)

+		      if (shdr->sh_entsize != 0

+			  && dyn->d_un.d_val > (shdr->sh_size

+						/ shdr->sh_entsize))

 			ERROR (gettext ("\

 section [%2d] '%s': DT_RELCOUNT value %d too high for this section\n"),

 			       idx, section_name (ebl, idx),

@@ -1177,7 +1193,8 @@ section [%2d] '%s': no relocations for m

 	}

     }

-  if (shdr->sh_entsize != gelf_fsize (ebl->elf, reltype, 1, EV_CURRENT))

+  size_t sh_entsize = gelf_fsize (ebl->elf, reltype, 1, EV_CURRENT);

+  if (shdr->sh_entsize != sh_entsize)

     ERROR (gettext (reltype == ELF_T_RELA ? "\

 section [%2d] '%s': section entry size does not match ElfXX_Rela\n" : "\

 section [%2d] '%s': section entry size does not match ElfXX_Rel\n"),

@@ -1400,7 +1417,8 @@ check_rela (Ebl *ebl, GElf_Ehdr *ehdr, G

   Elf_Data *symdata = elf_getdata (symscn, NULL);

   enum load_state state = state_undecided;

-  for (size_t cnt = 0; cnt < shdr->sh_size / shdr->sh_entsize; ++cnt)

+  size_t sh_entsize = gelf_fsize (ebl->elf, ELF_T_RELA, 1, EV_CURRENT);

+  for (size_t cnt = 0; cnt < shdr->sh_size / sh_entsize; ++cnt)

     {

       GElf_Rela rela_mem;

       GElf_Rela *rela = gelf_getrela (data, cnt, &rela_mem);

@@ -1450,7 +1468,8 @@ check_rel (Ebl *ebl, GElf_Ehdr *ehdr, GE

   Elf_Data *symdata = elf_getdata (symscn, NULL);

   enum load_state state = state_undecided;

-  for (size_t cnt = 0; cnt < shdr->sh_size / shdr->sh_entsize; ++cnt)

+  size_t sh_entsize = gelf_fsize (ebl->elf, ELF_T_REL, 1, EV_CURRENT);

+  for (size_t cnt = 0; cnt < shdr->sh_size / sh_entsize; ++cnt)

     {

       GElf_Rel rel_mem;

       GElf_Rel *rel = gelf_getrel (data, cnt, &rel_mem);

@@ -1553,7 +1572,8 @@ section [%2d] '%s': referenced as string

 	   shdr->sh_link, section_name (ebl, shdr->sh_link),

 	   idx, section_name (ebl, idx));

-  if (shdr->sh_entsize != gelf_fsize (ebl->elf, ELF_T_DYN, 1, EV_CURRENT))

+  size_t sh_entsize = gelf_fsize (ebl->elf, ELF_T_DYN, 1, EV_CURRENT);

+  if (shdr->sh_entsize != sh_entsize)

     ERROR (gettext ("\

 section [%2d] '%s': section entry size does not match ElfXX_Dyn\n"),

 	   idx, section_name (ebl, idx));

@@ -1563,7 +1583,7 @@ section [%2d] '%s': section entry size d

 	   idx, section_name (ebl, idx));

   bool non_null_warned = false;

-  for (cnt = 0; cnt < shdr->sh_size / shdr->sh_entsize; ++cnt)

+  for (cnt = 0; cnt < shdr->sh_size / sh_entsize; ++cnt)

     {

       GElf_Dyn dyn_mem;

       GElf_Dyn *dyn = gelf_getdyn (data, cnt, &dyn_mem);

@@ -1844,6 +1864,8 @@ section [%2d] '%s': entry size does not 

 	   idx, section_name (ebl, idx));

   if (symshdr != NULL

+      && shdr->sh_entsize

+      && symshdr->sh_entsize

       && (shdr->sh_size / shdr->sh_entsize

 	  < symshdr->sh_size / symshdr->sh_entsize))

     ERROR (gettext ("\

@@ -1870,6 +1892,12 @@ section [%2d] '%s': extended section ind

     }

   Elf_Data *data = elf_getdata (elf_getscn (ebl->elf, idx), NULL);

+  if (data == NULL)

+    {

+      ERROR (gettext ("section [%2d] '%s': cannot get section data\n"),

+ 	     idx, section_name (ebl, idx));

+      return;

+    }

   if (*((Elf32_Word *) data->d_buf) != 0)

     ERROR (gettext ("symbol 0 should have zero extended section index\n"));

@@ -1912,7 +1940,7 @@ section [%2d] '%s': hash table section i

   size_t maxidx = nchain;

-  if (symshdr != NULL)

+  if (symshdr != NULL && symshdr->sh_entsize != 0)

     {

       size_t symsize = symshdr->sh_size / symshdr->sh_entsize;

@@ -1923,18 +1951,28 @@ section [%2d] '%s': hash table section i

       maxidx = symsize;

     }

+  Elf32_Word *buf = (Elf32_Word *) data->d_buf;

+  Elf32_Word *end = (Elf32_Word *) ((char *) data->d_buf + shdr->sh_size);

   size_t cnt;

   for (cnt = 2; cnt < 2 + nbucket; ++cnt)

-    if (((Elf32_Word *) data->d_buf)[cnt] >= maxidx)

+    {

+      if (buf + cnt >= end)

+	break;

+      else if (buf[cnt] >= maxidx)

       ERROR (gettext ("\

 section [%2d] '%s': hash bucket reference %zu out of bounds\n"),

 	     idx, section_name (ebl, idx), cnt - 2);

+    }

   for (; cnt < 2 + nbucket + nchain; ++cnt)

-    if (((Elf32_Word *) data->d_buf)[cnt] >= maxidx)

+    {

+      if (buf + cnt >= end)

+	break;

+      else if (buf[cnt] >= maxidx)

       ERROR (gettext ("\

 section [%2d] '%s': hash chain reference %zu out of bounds\n"),

 	     idx, section_name (ebl, idx), cnt - 2 - nbucket);

+    }

 }

@@ -1964,18 +2002,28 @@ section [%2d] '%s': hash table section i

       maxidx = symsize;

     }

+  Elf64_Xword *buf = (Elf64_Xword *) data->d_buf;

+  Elf64_Xword *end = (Elf64_Xword *) ((char *) data->d_buf + shdr->sh_size);

   size_t cnt;

   for (cnt = 2; cnt < 2 + nbucket; ++cnt)

-    if (((Elf64_Xword *) data->d_buf)[cnt] >= maxidx)

+    {

+      if (buf + cnt >= end)

+	break;

+      else if (buf[cnt] >= maxidx)

       ERROR (gettext ("\

 section [%2d] '%s': hash bucket reference %zu out of bounds\n"),

 	     idx, section_name (ebl, idx), cnt - 2);

+    }

   for (; cnt < 2 + nbucket + nchain; ++cnt)

-    if (((Elf64_Xword *) data->d_buf)[cnt] >= maxidx)

+    {

+      if (buf + cnt >= end)

+	break;

+      else if (buf[cnt] >= maxidx)

       ERROR (gettext ("\

 section [%2d] '%s': hash chain reference %" PRIu64 " out of bounds\n"),

-	     idx, section_name (ebl, idx), (uint64_t) (cnt - 2 - nbucket));

+	       idx, section_name (ebl, idx), (uint64_t) cnt - 2 - nbucket);

+    }

 }

@@ -2000,7 +2048,7 @@ section [%2d] '%s': bitmask size not pow

   if (shdr->sh_size < (4 + bitmask_words + nbuckets) * sizeof (Elf32_Word))

     {

       ERROR (gettext ("\

-section [%2d] '%s': hash table section is too small (is %ld, expected at least%ld)\n"),

+section [%2d] '%s': hash table section is too small (is %ld, expected at least %ld)\n"),

 	     idx, section_name (ebl, idx), (long int) shdr->sh_size,

 	     (long int) ((4 + bitmask_words + nbuckets) * sizeof (Elf32_Word)));

       return;

@@ -2657,8 +2705,9 @@ section [%2d] '%s' refers in sh_link to 

   /* The number of elements in the version symbol table must be the

      same as the number of symbols.  */

-  if (shdr->sh_size / shdr->sh_entsize

-      != symshdr->sh_size / symshdr->sh_entsize)

+  if (shdr->sh_entsize && symshdr->sh_entsize

+      && (shdr->sh_size / shdr->sh_entsize

+	  != symshdr->sh_size / symshdr->sh_entsize))

     ERROR (gettext ("\

 section [%2d] '%s' has different number of entries than symbol table [%2d] '%s'\n"),

 	   idx, section_name (ebl, idx),

--- elfutils-0.132/src/readelf.c.robustify

+++ elfutils-0.132/src/readelf.c

@@ -1107,6 +1107,8 @@ handle_scngrp (Ebl *ebl, Elf_Scn *scn, G

   Elf32_Word *grpref = (Elf32_Word *) data->d_buf;

   GElf_Sym sym_mem;

+  GElf_Sym *sym = gelf_getsym (symdata, shdr->sh_info, &sym_mem);

+

   printf ((grpref[0] & GRP_COMDAT)

 	  ? ngettext ("\

 \nCOMDAT section group [%2zu] '%s' with signature '%s' contains %zu entry:\n",

@@ -1119,8 +1121,8 @@ handle_scngrp (Ebl *ebl, Elf_Scn *scn, G

 		      data->d_size / sizeof (Elf32_Word) - 1),

 	  elf_ndxscn (scn),

 	  elf_strptr (ebl->elf, shstrndx, shdr->sh_name),

-	  elf_strptr (ebl->elf, symshdr->sh_link,

-		      gelf_getsym (symdata, shdr->sh_info, &sym_mem)->st_name)

+	  (sym == NULL ? NULL

+	   : elf_strptr (ebl->elf, symshdr->sh_link, sym->st_name))

 	  ?: gettext ("<INVALID SYMBOL>"),

 	  data->d_size / sizeof (Elf32_Word) - 1);

@@ -1271,7 +1273,8 @@ static void

 handle_dynamic (Ebl *ebl, Elf_Scn *scn, GElf_Shdr *shdr)

 {

   int class = gelf_getclass (ebl->elf);

-  GElf_Shdr glink;

+  GElf_Shdr glink_mem;

+  GElf_Shdr *glink;

   Elf_Data *data;

   size_t cnt;

   size_t shstrndx;

@@ -1286,6 +1289,11 @@ handle_dynamic (Ebl *ebl, Elf_Scn *scn, 

     error (EXIT_FAILURE, 0,

 	   gettext ("cannot get section header string table index"));

+  glink = gelf_getshdr (elf_getscn (ebl->elf, shdr->sh_link), &glink_mem);

+  if (glink == NULL)

+    error (EXIT_FAILURE, 0, gettext ("invalid sh_link value in section %Zu"),

+	   elf_ndxscn (scn));

+

   printf (ngettext ("\

 \nDynamic segment contains %lu entry:\n Addr: %#0*" PRIx64 "  Offset: %#08" PRIx64 "  Link to section: [%2u] '%s'\n",

 		    "\

@@ -1295,9 +1303,7 @@ handle_dynamic (Ebl *ebl, Elf_Scn *scn, 

 	  class == ELFCLASS32 ? 10 : 18, shdr->sh_addr,

 	  shdr->sh_offset,

 	  (int) shdr->sh_link,

-	  elf_strptr (ebl->elf, shstrndx,

-		      gelf_getshdr (elf_getscn (ebl->elf, shdr->sh_link),

-				    &glink)->sh_name));

+	  elf_strptr (ebl->elf, shstrndx, glink->sh_name));

   fputs_unlocked (gettext ("  Type              Value\n"), stdout);

   for (cnt = 0; cnt < shdr->sh_size / shdr->sh_entsize; ++cnt)

@@ -1797,6 +1803,13 @@ handle_symtab (Ebl *ebl, Elf_Scn *scn, G

     error (EXIT_FAILURE, 0,

 	   gettext ("cannot get section header string table index"));

+  GElf_Shdr glink_mem;

+  GElf_Shdr *glink = gelf_getshdr (elf_getscn (ebl->elf, shdr->sh_link),

+				   &glink_mem);

+  if (glink == NULL)

+    error (EXIT_FAILURE, 0, gettext ("invalid sh_link value in section %Zu"),

+	   elf_ndxscn (scn));

+

   /* Now we can compute the number of entries in the section.  */

   unsigned int nsyms = data->d_size / (class == ELFCLASS32

 				       ? sizeof (Elf32_Sym)

@@ -1807,15 +1820,12 @@ handle_symtab (Ebl *ebl, Elf_Scn *scn, G

 		    nsyms),

 	  (unsigned int) elf_ndxscn (scn),

 	  elf_strptr (ebl->elf, shstrndx, shdr->sh_name), nsyms);

-  GElf_Shdr glink;

   printf (ngettext (" %lu local symbol  String table: [%2u] '%s'\n",

 		    " %lu local symbols  String table: [%2u] '%s'\n",

 		    shdr->sh_info),

 	  (unsigned long int) shdr->sh_info,

 	  (unsigned int) shdr->sh_link,

-	  elf_strptr (ebl->elf, shstrndx,

-		      gelf_getshdr (elf_getscn (ebl->elf, shdr->sh_link),

-				    &glink)->sh_name));

+	  elf_strptr (ebl->elf, shstrndx, glink->sh_name));

   fputs_unlocked (class == ELFCLASS32

 		  ? gettext ("\

@@ -2051,7 +2061,13 @@ handle_verneed (Ebl *ebl, Elf_Scn *scn, 

     error (EXIT_FAILURE, 0,

 	   gettext ("cannot get section header string table index"));

-  GElf_Shdr glink;

+  GElf_Shdr glink_mem;

+  GElf_Shdr *glink = gelf_getshdr (elf_getscn (ebl->elf, shdr->sh_link),

+				   &glink_mem);

+  if (glink == NULL)

+    error (EXIT_FAILURE, 0, gettext ("invalid sh_link value in section %Zu"),

+	   elf_ndxscn (scn));

+

   printf (ngettext ("\

 \nVersion needs section [%2u] '%s' contains %d entry:\n Addr: %#0*" PRIx64 "  Offset: %#08" PRIx64 "  Link to section: [%2u] '%s'\n",

 		    "\

@@ -2062,9 +2078,7 @@ handle_verneed (Ebl *ebl, Elf_Scn *scn, 

 	  class == ELFCLASS32 ? 10 : 18, shdr->sh_addr,

 	  shdr->sh_offset,

 	  (unsigned int) shdr->sh_link,

-	  elf_strptr (ebl->elf, shstrndx,

-		      gelf_getshdr (elf_getscn (ebl->elf, shdr->sh_link),

-				    &glink)->sh_name));

+	  elf_strptr (ebl->elf, shstrndx, glink->sh_name));

   unsigned int offset = 0;

   for (int cnt = shdr->sh_info; --cnt >= 0; )

@@ -2117,8 +2131,14 @@ handle_verdef (Ebl *ebl, Elf_Scn *scn, G

     error (EXIT_FAILURE, 0,

 	   gettext ("cannot get section header string table index"));

+  GElf_Shdr glink_mem;

+  GElf_Shdr *glink = gelf_getshdr (elf_getscn (ebl->elf, shdr->sh_link),

+				   &glink_mem);

+  if (glink == NULL)

+    error (EXIT_FAILURE, 0, gettext ("invalid sh_link value in section %Zu"),

+	   elf_ndxscn (scn));

+

   int class = gelf_getclass (ebl->elf);

-  GElf_Shdr glink;

   printf (ngettext ("\

 \nVersion definition section [%2u] '%s' contains %d entry:\n Addr: %#0*" PRIx64 "  Offset: %#08" PRIx64 "  Link to section: [%2u] '%s'\n",

 		    "\

@@ -2130,9 +2150,7 @@ handle_verdef (Ebl *ebl, Elf_Scn *scn, G

 	  class == ELFCLASS32 ? 10 : 18, shdr->sh_addr,

 	  shdr->sh_offset,

 	  (unsigned int) shdr->sh_link,

-	  elf_strptr (ebl->elf, shstrndx,

-		      gelf_getshdr (elf_getscn (ebl->elf, shdr->sh_link),

-				    &glink)->sh_name));

+	  elf_strptr (ebl->elf, shstrndx, glink->sh_name));

   unsigned int offset = 0;

   for (int cnt = shdr->sh_info; --cnt >= 0; )

@@ -2394,8 +2412,14 @@ handle_versym (Ebl *ebl, Elf_Scn *scn, G

       filename = NULL;

     }

+  GElf_Shdr glink_mem;

+  GElf_Shdr *glink = gelf_getshdr (elf_getscn (ebl->elf, shdr->sh_link),

+				   &glink_mem);

+  if (glink == NULL)

+    error (EXIT_FAILURE, 0, gettext ("invalid sh_link value in section %Zu"),

+	   elf_ndxscn (scn));

+

   /* Print the header.  */

-  GElf_Shdr glink;

   printf (ngettext ("\

 \nVersion symbols section [%2u] '%s' contains %d entry:\n Addr: %#0*" PRIx64 "  Offset: %#08" PRIx64 "  Link to section: [%2u] '%s'",

 		    "\

@@ -2407,9 +2431,7 @@ handle_versym (Ebl *ebl, Elf_Scn *scn, G

 	  class == ELFCLASS32 ? 10 : 18, shdr->sh_addr,

 	  shdr->sh_offset,

 	  (unsigned int) shdr->sh_link,

-	  elf_strptr (ebl->elf, shstrndx,

-		      gelf_getshdr (elf_getscn (ebl->elf, shdr->sh_link),

-				    &glink)->sh_name));

+	  elf_strptr (ebl->elf, shstrndx, glink->sh_name));

   /* Now we can finally look at the actual contents of this section.  */

   for (unsigned int cnt = 0; cnt < shdr->sh_size / shdr->sh_entsize; ++cnt)

@@ -2461,7 +2483,17 @@ print_hash_info (Ebl *ebl, Elf_Scn *scn,

   for (Elf32_Word cnt = 0; cnt < nbucket; ++cnt)

     ++counts[lengths[cnt]];

-  GElf_Shdr glink;

+  GElf_Shdr glink_mem;

+  GElf_Shdr *glink = gelf_getshdr (elf_getscn (ebl->elf,

+					       shdr->sh_link),

+				   &glink_mem);

+  if (glink == NULL)

+    {

+      error (0, 0, gettext ("invalid sh_link value in section %Zu"),

+	     elf_ndxscn (scn));

+      return;

+    }

+

   printf (ngettext ("\

 \nHistogram for bucket list length in section [%2u] '%s' (total of %d bucket):\n Addr: %#0*" PRIx64 "  Offset: %#08" PRIx64 "  Link to section: [%2u] '%s'\n",

 		    "\

@@ -2474,9 +2506,7 @@ print_hash_info (Ebl *ebl, Elf_Scn *scn,

 	  shdr->sh_addr,

 	  shdr->sh_offset,

 	  (unsigned int) shdr->sh_link,

-	  elf_strptr (ebl->elf, shstrndx,

-		      gelf_getshdr (elf_getscn (ebl->elf, shdr->sh_link),

-				    &glink)->sh_name));

+	  elf_strptr (ebl->elf, shstrndx, glink->sh_name));

   if (extrastr != NULL)

     fputs (extrastr, stdout);

@@ -3875,6 +3905,16 @@ print_debug_aranges_section (Dwfl_Module

       return;

     }

+  GElf_Shdr glink_mem;

+  GElf_Shdr *glink;

+  glink = gelf_getshdr (elf_getscn (ebl->elf, shdr->sh_link), &glink_mem);

+  if (glink == NULL)

+    {

+      error (0, 0, gettext ("invalid sh_link value in section %Zu"),

+	     elf_ndxscn (scn));

+      return;

+    }

+

   printf (ngettext ("\

 \nDWARF section '%s' at offset %#" PRIx64 " contains %zu entry:\n",

 		    "\

--- elfutils-0.132/src/strip.c.robustify

+++ elfutils-0.132/src/strip.c

@@ -543,6 +543,11 @@ handle_elf (int fd, Elf *elf, const char

       goto fail_close;

     }

+  if (shstrndx >= shnum)

+    goto illformed;

+

+#define elf_assert(test) do { if (!(test)) goto illformed; } while (0)

+

   /* Storage for section information.  We leave room for two more

      entries since we unconditionally create a section header string

      table.  Maybe some weird tool created an ELF file without one.

@@ -564,7 +569,7 @@ handle_elf (int fd, Elf *elf, const char

     {

       /* This should always be true (i.e., there should not be any

 	 holes in the numbering).  */

-      assert (elf_ndxscn (scn) == cnt);

+      elf_assert (elf_ndxscn (scn) == cnt);

       shdr_info[cnt].scn = scn;

@@ -577,6 +582,7 @@ handle_elf (int fd, Elf *elf, const char

 					shdr_info[cnt].shdr.sh_name);

       if (shdr_info[cnt].name == NULL)

 	{

+	illformed:

 	  error (0, 0, gettext ("illformed file '%s'"), fname);

 	  goto fail_close;

 	}

@@ -586,6 +592,8 @@ handle_elf (int fd, Elf *elf, const char

       /* Remember the shdr.sh_link value.  */

       shdr_info[cnt].old_sh_link = shdr_info[cnt].shdr.sh_link;

+      if (shdr_info[cnt].old_sh_link >= shnum)

+	goto illformed;

       /* Sections in files other than relocatable object files which

 	 are not loaded can be freely moved by us.  In relocatable

@@ -598,7 +606,7 @@ handle_elf (int fd, Elf *elf, const char

 	 appropriate reference.  */

       if (unlikely (shdr_info[cnt].shdr.sh_type == SHT_SYMTAB_SHNDX))

 	{

-	  assert (shdr_info[shdr_info[cnt].shdr.sh_link].symtab_idx == 0);

+	  elf_assert (shdr_info[shdr_info[cnt].shdr.sh_link].symtab_idx == 0);

 	  shdr_info[shdr_info[cnt].shdr.sh_link].symtab_idx = cnt;

 	}

       else if (unlikely (shdr_info[cnt].shdr.sh_type == SHT_GROUP))

@@ -615,7 +623,12 @@ handle_elf (int fd, Elf *elf, const char

 	  for (inner = 1;

 	       inner < shdr_info[cnt].data->d_size / sizeof (Elf32_Word);

 	       ++inner)

+	    {

+	      if (grpref[inner] < shnum)

 	    shdr_info[grpref[inner]].group_idx = cnt;

+	      else

+		goto illformed;

+	    }

 	  if (inner == 1 || (inner == 2 && (grpref[0] & GRP_COMDAT) == 0))

 	    /* If the section group contains only one element and this

@@ -626,7 +639,7 @@ handle_elf (int fd, Elf *elf, const char

 	}

       else if (unlikely (shdr_info[cnt].shdr.sh_type == SHT_GNU_versym))

 	{

-	  assert (shdr_info[shdr_info[cnt].shdr.sh_link].version_idx == 0);

+	  elf_assert (shdr_info[shdr_info[cnt].shdr.sh_link].version_idx == 0);

 	  shdr_info[shdr_info[cnt].shdr.sh_link].version_idx = cnt;

 	}

@@ -634,7 +647,7 @@ handle_elf (int fd, Elf *elf, const char

 	 discarded right away.  */

       if ((shdr_info[cnt].shdr.sh_flags & SHF_GROUP) != 0)

 	{

-	  assert (shdr_info[cnt].group_idx != 0);

+	  elf_assert (shdr_info[cnt].group_idx != 0);

 	  if (shdr_info[shdr_info[cnt].group_idx].idx == 0)

 	    {

@@ -709,11 +722,15 @@ handle_elf (int fd, Elf *elf, const char

 	    {

 	      /* If a relocation section is marked as being removed make

 		 sure the section it is relocating is removed, too.  */

-	      if ((shdr_info[cnt].shdr.sh_type == SHT_REL

+	      if (shdr_info[cnt].shdr.sh_type == SHT_REL

 		   || shdr_info[cnt].shdr.sh_type == SHT_RELA)

-		  && shdr_info[shdr_info[cnt].shdr.sh_info].idx != 0)

+		{

+		  if (shdr_info[cnt].shdr.sh_info >= shnum)

+		    goto illformed;

+		  else if (shdr_info[shdr_info[cnt].shdr.sh_info].idx != 0)

 		shdr_info[cnt].idx = 1;

 	    }

+	    }

 	  if (shdr_info[cnt].idx == 1)

 	    {

@@ -738,7 +755,7 @@ handle_elf (int fd, Elf *elf, const char

 		  if (shdr_info[cnt].symtab_idx != 0

 		      && shdr_info[shdr_info[cnt].symtab_idx].data == NULL)

 		    {

-		      assert (shdr_info[cnt].shdr.sh_type == SHT_SYMTAB);

+		      elf_assert (shdr_info[cnt].shdr.sh_type == SHT_SYMTAB);

 		      shdr_info[shdr_info[cnt].symtab_idx].data

 			= elf_getdata (shdr_info[shdr_info[cnt].symtab_idx].scn,

@@ -778,6 +795,9 @@ handle_elf (int fd, Elf *elf, const char

 		      else if (scnidx == SHN_XINDEX)

 			scnidx = xndx;

+		      if (scnidx >= shnum)

+			goto illformed;

+

 		      if (shdr_info[scnidx].idx == 0)

 			{

 			  /* Mark this section as used.  */

@@ -809,12 +829,16 @@ handle_elf (int fd, Elf *elf, const char

 		}

 	      /* Handle references through sh_info.  */

-	      if (SH_INFO_LINK_P (&shdr_info[cnt].shdr)

-		  && shdr_info[shdr_info[cnt].shdr.sh_info].idx == 0)

+	      if (SH_INFO_LINK_P (&shdr_info[cnt].shdr))

+		{

+		  if (shdr_info[cnt].shdr.sh_info >= shnum)

+		    goto illformed;

+		  else if ( shdr_info[shdr_info[cnt].shdr.sh_info].idx == 0)

 		{

 		  shdr_info[shdr_info[cnt].shdr.sh_info].idx = 1;

 		  changes |= shdr_info[cnt].shdr.sh_info < cnt;

 		}

+		}

 	      /* Mark the section as investigated.  */

 	      shdr_info[cnt].idx = 2;

@@ -914,7 +938,7 @@ handle_elf (int fd, Elf *elf, const char

 	  error (EXIT_FAILURE, 0, gettext ("while generating output file: %s"),

 		 elf_errmsg (-1));

-	assert (elf_ndxscn (shdr_info[cnt].newscn) == shdr_info[cnt].idx);

+	elf_assert (elf_ndxscn (shdr_info[cnt].newscn) == shdr_info[cnt].idx);

 	/* Add this name to the section header string table.  */

 	shdr_info[cnt].se = ebl_strtabadd (shst, shdr_info[cnt].name, 0);

@@ -951,7 +975,7 @@ handle_elf (int fd, Elf *elf, const char

 	error (EXIT_FAILURE, 0,

 	       gettext ("while create section header section: %s"),

 	       elf_errmsg (-1));

-      assert (elf_ndxscn (shdr_info[cnt].newscn) == shdr_info[cnt].idx);

+      elf_assert (elf_ndxscn (shdr_info[cnt].newscn) == shdr_info[cnt].idx);

       shdr_info[cnt].data = elf_newdata (shdr_info[cnt].newscn);

       if (shdr_info[cnt].data == NULL)

@@ -1007,7 +1031,7 @@ handle_elf (int fd, Elf *elf, const char

     error (EXIT_FAILURE, 0,

 	   gettext ("while create section header section: %s"),

 	   elf_errmsg (-1));

-  assert (elf_ndxscn (shdr_info[cnt].newscn) == idx);

+  elf_assert (elf_ndxscn (shdr_info[cnt].newscn) == idx);

   /* Finalize the string table and fill in the correct indices in the

      section headers.  */

@@ -1097,20 +1121,20 @@ handle_elf (int fd, Elf *elf, const char