#1 Remove unused python3-mock test dependency
Opened 2 months ago by salimma. Modified 2 months ago
rpms/ salimma/enki rm-python-mock  into  rawhide

file modified
+4 -2
@@ -4,7 +4,7 @@ 

  

  Name:           enki

  Version:        22.08.0

- Release:        6%{?dist}

+ Release:        7%{?dist}

  Summary:        Text editor for programmers

  

  License:        GPLv2+
@@ -35,7 +35,6 @@ 

  

  # FIXME add more optional dependencies to enable specific tests

  BuildRequires:  python3-markdown

- BuildRequires:  python3-mock

  BuildRequires:  python3-regex

  

  # runtime
@@ -148,6 +147,9 @@ 

  %doc html/

  

  %changelog

+ * Wed Feb 14 2024 Michel Lind <salimma@fedoraproject.org> - 22.08.0-7

+ - Remove unused python3-mock test dependency

+ 

  * Wed Jan 24 2024 Fedora Release Engineering <releng@fedoraproject.org> - 22.08.0-6

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild

  

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/c745698d23ff4efa813aeb4f3a7ef34d

Could you please not fold unrelated changes to a commit that clearly says "Remove unused python3-mock test dependency" in the subject?

rebased onto 505796a

2 months ago

Could you please not fold unrelated changes to a commit that clearly says "Remove unused python3-mock test dependency" in the subject?

apologies! the SPDX change has been removed

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/c4937a3bb3804f46a504424f49f3ac50

Right now, the specfile disables Python tests entirely. Did you check the test files and confirm that they actually don't need mock?

mock as dependency is a relict from python2 times and wrongly migrated to python3 package that's now useless. See commit 7fa1b0d v15.11.2 pre1 .

BTW why does rpmlinter fail? Tests should run as best as possible.

enki.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/enki/main.py 644 /usr/bin/env python3

That's unrelated to this change and should be addressed in a separate PR.

Metadata