#2 SPEC file: Update Dependencies, introduce optional deps
Merged 2 months ago by genodeftest. Opened 2 months ago by genodeftest.
rpms/ genodeftest/exaile master-update-deps  into  master

file modified
+56 -12

@@ -4,32 +4,73 @@ 

  

  Name:           exaile

  Version:        4.0.0

- Release:        1%{?dist}

+ Release:        2%{?dist}

  Summary:        Simple but powerful Amarok-style music player for GTK users

  License:        GPLv2+

  URL:            http://www.exaile.org

  Source0:        https://github.com/exaile/exaile/archive/%{version}/%{name}-%{version}.tar.gz

  BuildArch:      noarch

  

- BuildRequires:  desktop-file-utils

+ 

  BuildRequires:  /usr/bin/pathfix.py

+ 

+ # Dependencies:

+ # see also https://github.com/exaile/exaile/blob/master/DEPS

+ 

+ BuildRequires:  desktop-file-utils

  BuildRequires:  gettext

  BuildRequires:  help2man

  BuildRequires:  libappstream-glib

- BuildRequires:  pygobject3-devel >= 2.18

+ BuildRequires:  pygobject3-devel >= 3.13.2

  BuildRequires:  gobject-introspection

  

- # Warning for the future releases:

- # gstreamer 1.x transition required.

- # RPM weak dependencies support.

- Requires:       python2-dbus

- Requires:       gstreamer1-plugins-good

+ Requires:       python2

+ Requires:       gtk3 >= 3.10

  Requires:       python2-gstreamer1 >= 1.4

- Requires:       librsvg2

- Requires:       pygobject3 >= 2.18

- Requires:       python2-cddb

+ Requires:       gstreamer1-plugins-good >= 1.6

+ Requires:       gstreamer1-plugins-base >= 1.4

  Requires:       python2-mutagen >= 1.10

- Requires:       udisks2

+ Requires:       python2-dbus

+ Requires:       pygobject3 >= 3.13.2

+ Requires:       python2-cairo

+ Requires:       cairo-gobject

+ Requires:       python2-gobject

+ 

+ # Device detection:

+ Recommends:     libudisks2

+ # CD info:

+ Recommends:     python2-cddb

+ # DAAP plugins (daapserver and daapclient):

+ #Not packaged for Fedora

+ #Recommends:     spydaap

+ # Last.FM integration:

+ Recommends:     python2-pylast

+ # Lyrics from lyricsmania.com (lyricsmania):

+ Recommends:     python2-lxml

+ # Lyrics from lyrics.wikia.com (lyricwiki):

+ Recommends:     python2-beautifulsoup4

+ # Musicbrainz covers:

+ Recommends:     python2-musicbrainzngs

+ # Podcast plugin:

+ #Not packaged for Fedora

+ #Recommends:     python2-feedparser

+ # Wikipedia info:

+ Recommends:     webkit2gtk3

+ # Xlib-based hotkeys:

+ Recommends:     keybinder3

+ # Scalable icons:

+ Recommends:     librsvg2

+ # Native Notifications:

+ Recommends:     libnotify

+ # Recording streams:

+ Recommends:     streamripper

+ # Moodbar plugin:

+ #FTBFS on Fedora 30+, may be dropped soon

+ #Recommends:     moodbar

+ # BPM Counter plugin:

+ #Not packaged for Fedora

+ #* bpmdetect from gstreamer1-plugins-bad

+ 

  

  %description

  Exaile is a music player with a simple interface and powerful music

@@ -89,6 +130,9 @@ 

  %{_mandir}/man1/exaile*.1*

  

  %changelog

+ * Sat Jun 22 2019 Christian Stadelmann <genodeftest@fedoraproject.org> - 4.0.0-2

+ - Update dependencies, add plugin dependencies as optional

+ 

  * Thu Jun 20 2019 Leigh Scott <leigh123linux@googlemail.com> - 4.0.0-1

  - Update to 4.0.0

  

Can you remove moodbar as the fedora package is too old, exaile requires it's own fork of moodbar

https://github.com/exaile/moodbar

It requires gstreamer and gstreamer-tools, moodbar is ftbfs and is likely to be removed from f31 repo.
I see that you are aware of it's state.

https://bugzilla.redhat.com/show_bug.cgi?id=1551316

Please update the changelog with the changes.

Thank you for your feedback!

Please note that the new fork of moodbar is compatible with the old version.

I hope that moodbar won't be dropped. Is there any negative side-effect when keeping moodbar in the Recommends: list?

Would you want to do a new release? I.e. should I increase the number to 4.0.0-2?

Would you want to do a new release? I.e. should I increase the number to 4.0.0-2?

Yes, I have granted commit rights so feel free to build it as well :-)

rebased onto d7d91fd

2 months ago

I hope I did everything right ;)

Yes, I have granted commit rights so feel free to build it as well :-)

I don't really know how to do that. Something with fedpkg build? Does that mean I am some kind of package co-maintainer?

Btw: Are you interested in helping with the moodbar package as (co-)maintainer?

Pull-Request has been merged by genodeftest

2 months ago

Shall I also git push from master to the other (f30, f29) branches?

Here's a guide for fedpkg

https://fedoraproject.org/wiki/Package_maintenance_guide#Installing_fedpkg_and_doing_initial_setup

There is no obligation to co-maintain, you seem to have an interest so I thought I would offer you the choice.

Yes to merging to the other branches, thanks

fedpkg switch-branch f30
git merge master
git push
fedpkg switch-branch f29
git merge master
git push

Here's a guide for fedpkg
https://fedoraproject.org/wiki/Package_maintenance_guide#Installing_fedpkg_and_doing_initial_setup

Thanks!

There is no obligation to co-maintain, you seem to have an interest so I thought I would offer you the choice.

My question was more like "did you just (mis-)understand me that I wanted to co-maintain?". If you're interested in a tiny bit of help, yes, but I'm not too keen on it.

Yes to merging to the other branches, thanks
fedpkg switch-branch f30
git merge master
git push
fedpkg switch-branch f29
git merge master
git push

Thanks for the quick introduction! I already managed to start the builds!

It looks like I don't have permission to do the build though. This is what I get:

$ fedpkg switch-branch f30
Switched to branch 'f30
$ fedpkg update 
Password: 
Could not execute update: Could not generate update request: Build does not exist: exaile-4.0.0-2.fc30
You may not specify an empty list of builds.
ACL validation mechanism was unable to determine ACLs.

The builds have shown up on https://koji.fedoraproject.org for a short while but they are not listed on https://apps.fedoraproject.org/packages/exaile/builds/.

Looks like there is nothing more to do for me.

It looks like you forgot to clone without the -a option, it needs to be

fedpkg co exaile

To gain authentication you need to run this before submitting the build

kinit genodeftest@FEDORAPROJECT.ORG

Then enter your FAS password.

P.S Any help is welcomed

Thanks for the hint! Yes, it looks like I've created the repo with git clone instead of fedpkg co, that's probably the cause for this issue. Works fine now.

The f29 build now failed and I don't understand why so I'm just retrying it.

My commit to fix the python shebangs had a missing buildrequires for python macro in f29

https://src.fedoraproject.org/rpms/exaile/c/b695bed928fd4c485ff59990c4a1ee6e201c3ad9?branch=master

I pushed that change to all branches

Oh, nice catch! I'll just retry the f29 build again ;)

Is there any need to retry the other builds too or do we just leave them as is and update them at a later time?

The other branches can wait till next time.

Ok, thanks! Enough learned for today ;)