PR#1: Add gprinstall flags into macros.gnat - rpms/fedora-gnat-project-common

rpms / fedora-gnat-project-common

#1 Add gprinstall flags into macros.gnat

Merged 3 years ago by rombobeorn. Opened 3 years ago by landgraf.

rpms/ landgraf/fedora-gnat-project-common gptinstall into master

Add gprinstall flags into macros.gnat

Pavel Zhukov • 3 years ago

23a0f1c

fedora-gnat-project-common.spec

file modified

+5 -2

		`@@ -1,6 +1,6 @@`
		`Name: fedora-gnat-project-common`
		`- Version: 3.14`
		`- Release: 2%{?dist}`
		`+ Version: 3.15`
		`+ Release: 1%{?dist}`
		`Summary: Files shared by Ada libraries`
		`Summary(sv): Gemensamma filer för adabibliotek`

		`@@ -59,6 +59,9 @@`


		`%changelog`
		`+ * Wed Dec 2 2020 Pavel Zhukov <pzhukov@redhat.com> - 3.15-1`
		`+ - Add flags for gprinstall into macros.gnat`
		`+`
		`* Mon Jul 27 2020 Fedora Release Engineering <releng@fedoraproject.org> - 3.14-2`
		`- Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild`

macros.gnat.in

file modified

+11

		`@@ -81,3 +81,14 @@`
		`# Comfignat. It passes the standard parameters for the build tools, the`
		`# directories project and the installation pathnames to Make. A goal for Make`
		`# may be appended on the command line.`
		`+`
		`+ %Gprinstall_flags --create-missing-dirs \\\`
		`+ --sources-subdir=%{buildroot}/%{_includedir}/%{name} \\\`
		`+ --project-subdir=%{buildroot}/%_GNAT_project_dir \\\`
		`+ --exec-subdir=%{buildroot}/%{_bindir} \\\`
		`+ --ali-subdir=%{buildroot}/%{_libdir}/%{name} \\\`
		`+ --lib-subdir=%{buildroot}/%{_libdir} \\\`
		`+ --link-lib-subdir=%{buildroot}/%{_libdir}`
		`+`
		`+ # Gprinstall_flags contains standard path for package installation is Fedora`
		`+ # It deprecates usage of directories.gpr in case if project uses gprinstall properly`

landgraf commented 3 years ago

Modern ada applicatios don't use makefile too much but gprinstall.
It makes easier installation into buildroot but requires long list of
arguments to be passed into. The list is identical for almost all packages
thus can be placed into macros file.

rebased onto 8572d5d

3 years ago

rebased onto e09454b

3 years ago

rombobeorn commented 3 years ago

We can have this macro, but its name should be "GPRinstall_flags" to be consistent with the other macros.

Can we use the self-documenting "--create-missing-dirs" instead of the cryptic "-p"?

The comment needs improving. I don't understand the part about deprecating usage of directories. Directories aren't going anywhere, and the macro is all about specifying directories to install in.

rebased onto 23a0f1c

3 years ago

landgraf commented 3 years ago

We can have this macro, but its name should be "GPRinstall_flags" to be consistent with the other macros.

Can we use the self-documenting "--create-missing-dirs" instead of the cryptic "-p"?

Done.

The comment needs improving. I don't understand the part about deprecating usage of directories. Directories aren't going anywhere, and the macro is all about specifying directories to install in.

I meant directories.gpr which is not needed for projects which use gprinstall in most cases.
Fixed.

Edited 3 years ago by landgraf

rombobeorn commented 3 years ago

I meant directories.gpr which is not needed for projects which use gprinstall in most cases.

Ah. Well, directories.gpr is still the only thing that can make project files support multilib, so if we should consider that deprecated, then it's not because of GPRinstall but rather because nobody cares much about i386 anymore.

Unless GPRinstall has gained multilib support recently? But I don't expect Adacore to start caring about multilib now that it's mostly defunct, after they have ignored it for all these years.