PR#108: Enable kata-osbuilder-generate.service by default - rpms/fedora-release

rpms / fedora-release

#108 Enable kata-osbuilder-generate.service by default

Merged 4 years ago by sgallagh. Opened 4 years ago by crobinso.

rpms/ crobinso/fedora-release kata-f33 into master

Enable kata-osbuilder-generate.service by default

Cole Robinson • 4 years ago

8d0ed8b

90-default.preset

file modified

+5 -1

		`@@ -283,4 +283,8 @@`
		`enable flatpak-add-fedora-repos.service`

		`# Run fstrim weekly on filesystems listed in fstab`
		`- enable fstrim.timer`
		`\ No newline at end of file`
		`+ enable fstrim.timer`
		`+`
		`+ # oneshot to generate kata VM appliance at host bootup`
		`+ # for the booted kernel`
		`+ enable kata-osbuilder-generate.service`

crobinso commented 4 years ago

kata is an OCI container runtime that essentially wraps a qemu/kvm
VM around around a traditional container image. Inside the VM runs
a small appliance OS, containing the minimally needed kernel modules,
systemd, the kata-agent, and not much else. This appliance is generated
from host content, mostly using dracut.

kata-osbuilder-generate.service is a oneshot startup service that
generates the appliance for the boot kernel, and then exits. It's
only installed when kata is installed.

if this is acceptable please also enable this for f32. I will send
a separate PR if that is preferred

crobinso commented 4 years ago

ping. any info needed from me here? is there another process I should follow to get this discussed? thanks in advance!

sgallagh commented 4 years ago

@crobinso Sorry, I missed this initially. Generally, it's preferred to follow https://docs.fedoraproject.org/en-US/packaging-guidelines/DefaultServices/#_how_to_enable_a_service_by_default (which directs you to file a BZ against a template that asks a bunch of questions that helps us determine if it's acceptable to include)

Fortunately, you've provided the data we would ask for in that BZ, so I'm going to go ahead and merge this. Apologies for the delay.

Pull-Request has been merged by sgallagh

4 years ago

sgallagh commented 4 years ago

I also cherry-picked this change to the F32 branch, however if you want this in F32 Beta, you will need to file a BZ for it and request a Freeze Exception.

crobinso commented 4 years ago

Thanks Stephen! beta release isn't necessary for me, post-beta update is sufficient