Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/af9d57b1d65e4c278a2c9029139f1be1

• check-for-arches : SUCCESS in 2m 10s
• rpm-scratch-build : SUCCESS in 11m 18s
• rpm-linter : SUCCESS in 17m 39s (non-voting)
• rpm-rpminspect : TIMED_OUT in 31m 08s (non-voting)
• check-for-sti-tests : SUCCESS in 16s
• check-for-fmf-tests : SUCCESS in 15s
• rpm-install-test : FAILURE in 1m 30s
  Skipped 6 jobs

https://src.fedoraproject.org/rpms/openssh/pull-request/40 was built and submitted:

• rawhide
• f38

A few questions/answers from the systemd preset BZ template:

• Does the service require post-rpm-installation configuration in order to be useful (for example, does it need manual edits to a configuration file)?

I don't think so. It's just a service that runs.

• Does the service listen on a network socket for connections originating on a separate physical or virtual machine?

No.

• Is the service non-persistent (i.e. run once at startup and exit)?

Yes. It is a oneshot unit. Furthermore it disables future runs by using a ConditionPathExists=!/var/lib/.ssh-host-keys-migration and a ExecStart=touch /var/lib/.ssh-host-keys-migration.

• What is the exact name (or names) of the systemd unit files to be enabled?

ssh-host-keys-migration.service

• Is this request for all Fedora deliverables or only for some Editions (list them)?

It's easiest to reason about if we just let the unit run everywhere. On non OSTree systems the RPM itself disables the unit by writing out the /var/lib/.ssh-host-keys-migration file when the migration occurs in the scriptlet.

LGTM.

I also cherry-picked the commit for the f38 branch.

I also cherry-picked the commit for the f38 branch.

Thanks! Could you possibly do a build and submit a bodhi update?

well actually. maybe attach it to this existing bodhi update: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e2b6da44e4 since we would FE that in under one update most likely;

This does not work for anyone excepted Fedora CoreOS that does preset-all on updates.

To phrase it properly: This only works for Fedora CoreOS because we manually re-preset-all services for each commit and that gets applied on updates.

For everybody else, presets are only applied on first boot so they don't get applied.

I had started working on this for Silverblue/KInoite in https://pagure.io/workstation-ostree-config/pull-request/246 but never completed it.

Classic DNF systems are "saved" by the fact that we do the change in %post:
https://src.fedoraproject.org/rpms/openssh/pull-request/40#_1__41

I think we should go back to a static enablement at the place the change is done (like I had done in https://src.fedoraproject.org/rpms/openssh/pull-request/39#_1__27) so that we keep things in a single place.