Enable presets for nmstate.service

This service will apply network configuration present at /etc/nmstate

- https://github.com/coreos/fedora-coreos-tracker/issues/1175
- https://github.com/coreos/fedora-coreos-config/pull/2269

need to add an enable nmstate.service line?

Maybe add some more context:

Enable nmstate to apply network configuration from /etc/nmstate/*.yml

LGTM

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/54c431ed1cbb44dcb1f7bcd64dcb7664

• check-for-arches : SUCCESS in 2m 26s
• rpm-scratch-build : SUCCESS in 11m 39s
• rpm-linter : SUCCESS in 19m 01s (non-voting)
• rpm-rpminspect : TIMED_OUT in 31m 10s (non-voting)
• check-for-sti-tests : SUCCESS in 18s
• check-for-fmf-tests : SUCCESS in 18s
• rpm-install-test : FAILURE in 1m 54s
  Skipped 6 jobs

Please see https://docs.fedoraproject.org/en-US/packaging-guidelines/DefaultServices/#_how_to_enable_a_service_by_default for instructions on how to request a preset. (It tells you to file a BZ which has a template of questions to answer).

Some questions:

What happens if /etc/nmstate is missing or empty? Does it fail to run or just exit with a non-error condition?

Does enabling this service implicitly change the behavior of NetworkManager (e.g. it uses the declarative format for configuration, overriding any existing configuration).

Depending on the answers, you may need to get approval from FESCo.

Please see https://docs.fedoraproject.org/en-US/packaging-guidelines/DefaultServices/#_how_to_enable_a_service_by_default for instructions on how to request a preset. (It tells you to file a BZ which has a template of questions to answer).

https://bugzilla.redhat.com/show_bug.cgi?id=2180507

Some questions:

What happens if /etc/nmstate is missing or empty? Does it fail to run or just exit with a non-error condition?

Currently, nmstate will fail with error when /etc/nmstate missing, and exit without error when folder is empty.

https://github.com/nmstate/nmstate/pull/2283 will change nmstate to ignore error when /etc/nmstate missing.

Does enabling this service implicitly change the behavior of NetworkManager (e.g. it uses the declarative format for configuration, overriding any existing configuration).

Yes. Nmstate will change configuration of NetworkManager using the file stored in /etc/nmstate folder. Any files name ending with .yml in /etc/nmstate folder will be applied to system and rename to .applied suffix after sucess to prevent repeat apply on next boot.

Depending on the answers, you may need to get approval from FESCo.

Thanks

Any chance we could get this for f38 too?