PR#274: Add presets for grub units - rpms/fedora-release

rpms / fedora-release

#274 Add presets for grub units

Merged 13 days ago by sgallagh. Opened 13 days ago by lorbus.

rpms/ lorbus/fedora-release grub-aux-presets into rawhide

Christian Glombek • 13 days ago

b1dd895

90-default.preset

file modified

		`@@ -393,3 +393,7 @@`
		`# Enable nfs-client.target`
		`# https://bugzilla.redhat.com/show_bug.cgi?id=2218006`
		`enable nfs-client.target`
		`+`
		`+ # https://bugzilla.redhat.com/show_bug.cgi?id=2230575`
		`+ enable grub-boot-indeterminate.service`
		`+ enable grub-systemd-integration.service`

lorbus commented 13 days ago

These units are currently enabled statically by shipping symlinks in
the RPM:
- grub-boot-indeterminate.service
- grub-systemd-integration.service
- grub-boot-success.timer

See https://src.fedoraproject.org/rpms/grub2/blob/dc5c4e3f52ab2a829168e81bd1e9eafced9b7c09/f/grub2.spec#_274-284

Using static enablement for services/timers is not according to the Fedora Packaging Guidelines, and it is also problematic for variants like Fedora IoT, see https://github.com/fedora-iot/greenboot/issues/108

The already existing user preset for grub-boot-success.timer currently has no effect at all as there's no [Install] section on the unit file.
I filed a PR to add the missing [Install] sections here: https://github.com/rhboot/grub2/pull/131

This change should already be safe to merge now.

See: https://bugzilla.redhat.com/show_bug.cgi?id=2230575