I don’t have a problem with the concept, but given that we have different logos for the editions, I’d like to see those handled too.

It would be nice to also have this entry in fedora 28 and 29, so I don't have to add branch-specific patches to my packaging (of e.g. for switchboard-plug-about).

Yeah, there’s nothing incompatible about this change, so we should definitely backport it once it’s merged.

@sgallagh We don't currently have a logo icon that simultaneously identifies as Fedora and the Edition, so that'd be problematic as it stands. Unless something changed about this?

As it is, Workstation and KDE both use the same logo for their "about system" areas. As does Pantheon and others. LOGO is intended to handle that since no one can agree on a common name convention for the distro logo for stuff to pick it up.

We definitely have those logos, because they are used in Anaconda. If they aren’t in the place freedesktop expects them, we can fix that.

Also pinging @martinpitt so that the Cockpit team is aware of this impending change. It would make sense for them to honor this option as well.

@sgallagh You know this is supposed to be the "square" icon, right? I'm unaware of a square icon that simultaneously identifies as Fedora and an Edition.

Also, generic-release counterpart PR: https://src.fedoraproject.org/rpms/generic-release/pull-request/3

@ngompa Well, given that https://pagure.io/design/issue/620 is currently in the middle of actively redesigning the Fedora Logo, I think we should ping some folks like @mattdm, @mizmo and others to consider whether such a thing should be part of the design requirements.

I’ll reference this PR on that ticket as well.

@sgallagh Excellent. It'd be nice to have something along those lines for all the variants we produce to make them stand out a bit.

That said, I think this is good to go, as-is?

Yeah, I suppose I can :thumbsup: this as-is and improve it later. I’ll leave @mohanboddu to give final approval and merge it though.

@mohanboddu If you merge it, can you please cherry pick and release this into f28 and f29, per @decathorpe's request?

Yeah, I suppose I can 👍 this as-is and improve it later. I’ll leave @mohanboddu to give final approval and merge it though.

I agree and we will improve this as needed.

Hi,

I don't know where is the best place to ask this question. But I'm confused - the icon seems to refer to the OS, not the edition. The OS is Fedora. Why would something called the OS logo be more specific than the OS?

Also note that while we have logotypes for spins like KDE, XFE, etc. we do not have logos beyond the Fedora logo. And a spin is not the same as an edition.

So I need more info to understand this and potentially be in a position to address it from the design team side.

I don't know where is the best place to ask this question. But I'm confused - the icon seems to refer to the OS, not the edition. The OS is Fedora. Why would something called the OS logo be more specific than the OS?

I don't know, but there seemed to be some kind of interest in further distinguishing each variant in this manner. And spins may very well want to have custom logos if Editions wind up having them.

I think I really need some more context around the problem this solves. Just because something is possible doesn't mean it makes sense to do :)

@duffy The point of this field in /etc/os-release is that it provides a distribution-independent source of truth for what the logo for this system is. The value given is the name of a theme that is located in the standard freedesktop icon theme path (see https://specifications.freedesktop.org/icon-theme-spec/latest/ ; this example would be /usr/share/icons/hicolor/256x256/apps/fedora-logo-icon.png, using whichever icon size was appropriate where it was being used) and should be used in places such as the GNOME "About" panel, possibly Cockpit's login or multi-system dashboard screen, libvirt's machine overview screen, etc.

I suggested that we might want it to differ between editions, to make it clear if you were running DIY Fedora vs. Fedora Workstation, vs Fedora Server. I think deciding whether to do that is probably a Council-level decision, though. So here's me also pinging @mattdm to get that on their radar as well.

Thanks. We're having a face-to-face council meeting this week and this is very relevant to our topics.

Nice, thanks @sgallagh for the notification! This definitively beats the static per-distro symlinkery that we do in cockpit. Once this goes in, I'm happy to read os-release's LOGO value and prefer that if present. Then over time, we can remove the static logo links.