PR#7: Add a filtered flathub remote - rpms/fedora-workstation-repositories

rpms / fedora-workstation-repositories

#7 Add a filtered flathub remote

Merged 4 years ago by catanzaro. Opened 4 years ago by mclasen.

flathub into master

Add a filtered flathub remote

Matthias Clasen • 4 years ago

a92e858

fedora-workstation-repositories.spec

file modified

+16 -1

		`@@ -1,5 +1,5 @@`
		`Name: fedora-workstation-repositories`
		`- Version: 31`
		`+ Version: 32`
		`Release: 1%{?dist}`
		`Summary: Repository files for searchable repositories`

		`@@ -9,6 +9,8 @@`
		`Source1: google-chrome.repo`
		`Source2: rpmfusion-nonfree-nvidia-driver.repo`
		`Source3: rpmfusion-nonfree-steam.repo`
		`+ Source4: flathub.flatpakrepo`
		`+ Source5: flathub.filter`

		`BuildArch: noarch`

		`@@ -18,6 +20,9 @@`
		`# For /etc/yum.repos.d`
		`Requires: fedora-repos`

		`+ # For /etc/flatpak/remotes.d`
		`+ Requires: flatpak`
		`+`
		`%description`
		`Repository files that make some select non-Fedora software available`
		`via search in gnome-software.`
		`@@ -33,13 +38,23 @@`
		`cp %{SOURCE2} $RPM_BUILD_ROOT%{_sysconfdir}/yum.repos.d/`
		`cp %{SOURCE3} $RPM_BUILD_ROOT%{_sysconfdir}/yum.repos.d/`

		`+ mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/flatpak/remotes.d`
		`+ cp %{SOURCE4} $RPM_BUILD_ROOT%{_sysconfdir}/flatpak/remotes.d/`
		`+ cp %{SOURCE5} $RPM_BUILD_ROOT%{_sysconfdir}/flatpak/remotes.d/`
		`+`
		`%files`
		`%config(noreplace) %{_sysconfdir}/yum.repos.d/_copr_phracek-PyCharm.repo`
		`%config(noreplace) %{_sysconfdir}/yum.repos.d/google-chrome.repo`
		`%config(noreplace) %{_sysconfdir}/yum.repos.d/rpmfusion-nonfree-nvidia-driver.repo`
		`%config(noreplace) %{_sysconfdir}/yum.repos.d/rpmfusion-nonfree-steam.repo`

		`+ %config(noreplace) %{_sysconfdir}/flatpak/remotes.d/flathub.flatpakrepo`
		`+ %config(noreplace) %{_sysconfdir}/flatpak/remotes.d/flathub.filter`
		`+`
		`%changelog`
		`+ * Fri Oct 4 2019 Matthias Clasen <mclasen@redhat.com> - 32-1`
		`+ - Add a filtered flathub remote`
		`+`
		`* Mon Sep 09 2019 Kalev Lember <klember@redhat.com> - 31-1`
		`- Add skip_if_unavailable=True to all third party repos (#1750414)`

flathub.filter

file added

		`@@ -0,0 +1,3 @@`
		`+ deny *`
		`+ allow runtime/org..Platform`
		`+ allow com.valvesoftware.Steam*`

flathub.flatpakrepo

file added

		`@@ -0,0 +1,9 @@`
		`+ [Flatpak Repo]`
		`+ Title=Flathub`
		`+ Url=https://flathub.org/repo/`
		`+ Homepage=https://flathub.org/`
		`+ Comment=Central repository of Flatpak applications`
		`+ Description=Central repository of Flatpak applications`
		`+ Filter=/etc/flatpak/remotes.d/flathub.filter`
		`+ Icon=https://flatpak.org/img/logo-e370cea0.svg`
		+ GPGKey=mQINBFlD2sABEADsiUZUOYBg1UdDaWkEdJYkTSZD68214m8Q1fbrP5AptaUfCl8KYKFMNoAJRBXn9FbE6q6VBzghHXj/rSnA8WPnkbaEWR7xltOqzB1yHpCQ1l8xSfH5N02DMUBSRtD/rOYsBKbaJcOgW0K21sX+BecMY/AI2yADvCJEjhVKrjR9yfRX+NQEhDcbXUFRGt9ZT+TI5yT4xcwbvvTu7aFUR/dH7+wjrQ7lzoGlZGFFrQXSs2WI0WaYHWDeCwymtohXryF8lcWQkhH8UhfNJVBJFgCY8Q6UHkZG0FxMu8xnIDBMjBmSZKwKQn0nwzwM2afskZEnmNPYDI8nuNsSZBZSAw+ThhkdCZHZZRwzmjzyRuLLVFpOj3XryXwZcSefNMPDkZAuWWzPYjxS80cm2hG1WfqrG0Gl8+iX69cbQchb7gbEb0RtqNskTo9DDmO0bNKNnMbzmIJ3/rTbSahKSwtewklqSP/01o0WKZiy+n/RAkUKOFBprjJtWOZkc8SPXV/rnoS2dWsJWQZhuPPtv3tefdDiEyp7ePrfgfKxuHpZES0IZRiFI4J/nAUP5bix+srcIxOVqAam68CbAlPvWTivRUMRVbKjJiGXIOJ78wAMjqPg3QIC0GQ0EPAWwAOzzpdgbnG7TCQetaVV8rSYCuirlPYN+bJIwBtkOC9SWLoPMVZTwQARAQABtC5GbGF0aHViIFJlcG8gU2lnbmluZyBLZXkgPGZsYXRodWJAZmxhdGh1Yi5vcmc+iQJUBBMBCAA+FiEEblwF2XnHba+TwIE1QYTdTZB6fK4FAllD2sACGwMFCRLMAwAFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQQYTdTZB6fK5RJQ/+Ptd4sWxaiAW91FFk7+wmYOkEe1NY2UDNJjEEz34PNP/1RoxveHDt43kYJQ23OWaPJuZAbu+fWtjRYcMBzOsMCaFcRSHFiDIC9aTp4ux/mo+IEeyarYt/oyKb5t5lta6xaAqg7rwt65jW5/aQjnS4h7eFZ+dAKta7Y/fljNrOznUp81/SMcx4QA5G2Pw0hs4Xrxg59oONOTFGBgA6FF8WQghrpR7SnEe0FSEOVsAjwQ13Cfkfa7b70omXSWp7GWfUzgBKyoWxKTqzMN3RQHjjhPJcsQnrqH5enUu4Pcb2LcMFpzimHnUgb9ft72DP5wxfzHGAWOUiUXHbAekfq5iFks8cha/RST6wkxG3Rf44Zn09aOxh1btMcGL+5xb1G0BuCQnA0fP/kDYIPwh9z22EqwRQOspIcvGeLVkFeIfubxpcMdOfQqQnZtHMCabV5Q/Rk9K1ZGc8M2hlg8gHbXMFch2xJ0Wu72eXbA/UY5MskEeBgawTQnQOK/vNm7t0AJMpWK26Qg6178UmRghmeZDj9uNRc3EI1nSbgvmGlpDmCxaAGqaGL1zW4KPW5yN25/qeqXcgCvUjZLI9PNq3Kvizp1lUrbx7heRiSoazCucvHQ1VHUzcPVLUKKTkoTP8okThnRRRsBcZ1+jI4yMWIDLOCT7IW3FePr+3xyuy5eEo9a25Ag0EWUPa7AEQALT/CmSyZ8LWlRYQZKYw417p7Z2hxqd6TjwkwM3IQ1irumkWcTZBZIbBgrSOg6CcXD2oWydCQHWi9qaxhuhEl2bJL5LskmBcMxVdQeD0LLHd8QUnbnnIby8ocvWN1alPfvJFjCUTrmD22U1ycOzRw2lIe4kiQONbOZtdWrVImQQSndjFlisitbmlWHvHm2lOOYy8+GJB7YffVV193hmnBSJffCy4bvkuLxsI+n1DhOzc7MPV3z6HGk4HiEcF0yyt9tCYhpsxHFdBoq2h771HfAcS0s98EVAqYMFnf9em+4cnYpdI6mhIfS1FQiKl6DBAYA8tT3ggla00DurPo0JwX/zN+PaO5h/6O9aCZwV7G6rbkgMuqMergXaf8oP38gr0z+MqWnkfM63Bodq68GP4l4hd02BoFBbDf38TMuGQB14+twJMdfbAxo2MbgluvQgfwHfZ2ca6gyEY+9s/YD1gugLjV+S6CB51WkFNe1z4tAPgJZNxUcKCbeaHNbthl8Hks/pY9RCEseX/EdfzF18epbSjJMPh4DPQXbUoFwmyuYcoBOPmvZHNl9hK7B/1RP8w1ZrXk8qdupC0SNbafX7270B7lMMVImzZetGsM9ypXJ6llhp3FwW09iseNyGJGPsr/dvTMGDXqOPfU/9SAS1LSTY4K9PbRtdrBE318YX8mIk5ABEBAAGJBHIEGAEIACYWIQRuXAXZecdtr5PAgTVBhN1NkHp8rgUCWUPa7AIbAgUJEswDAAJACRBBhN1NkHp8rsF0IAQZAQgAHRYhBFSmzd2JGfsgQgDYrFYnAunj7X7oBQJZQ9rsAAoJEFYnAunj7X7oR6AP/0KYmiAFeqx14Z43/6s2gt3VhxlSd8bmcVV7oJFbMhdHBIeWBp2BvsUf00I0Zl14ZkwCKfLwbbORC2eIxvzJ+QWjGfPhDmS4XUSmhlXxWnYEveSek5Tde+fmu6lqKM8CHg5BNx4GWIX/vdLi1wWJZyhrUwwICAxkuhKxuP2Z1An48930eslTD2GGcjByc27+9cIZjHKa07I/aLffo04V+oMT9/tgzoquzgpVV4jwekADo2MJjhkkPveSNI420bgT+Q7Fi1l0X1aFUniBvQMsaBa27PngWm6xE2ZYvh7nWCdd5g0c0eLIHxWwzV1lZ4Ryx4ITO/VL25ItECcjhTRdYa64sA62MYSaB0x3eR+SihpgP3wSNPFu3MJo6FKTFdi4CBAEmpWHFW7FcRmd+cQXeFrHLN3iNVWryy0HK/CUEJmiZEmpNiXecl4vPIIuyF0zgSCztQtKoMr+injpmQGC/rF/ELBVZTUSLNB350S0Ztvw0FKWDAJSxFmoxt3xycqvvt47rxTrhi78nkk6jATKGyvP55sO+K7Q7Wh0DXA69hvPrYW2eu8jGCdVGxi6HX7L1qcfEd0378S71dZ3g9o6KKl1OsDWWQ6MJ6FGBZedl/ibRfs8p5+sbCX3lQSjEFy3rx6n0rUrXx8U2qb+RCLzJlmC5MNBOTDJwHPcX6gKsUcXZrEQALmRHoo3SrewO41RCr+5nUlqiqV3AohBMhnQbGzyHf2+drutIaoh7Rj80XRh2bkkuPLwlNPf+bTXwNVGse4bej7B3oV6Ae1N7lTNVF4Qh+1OowtGjmfJPWo0z1s6HFJVxoIof9z58Msvgao0zrKGqaMWaNQ6LUeC9g9Aj/9Uqjbo8X54aLiYs8Z1WNc06jKP+gv8AWLtv6CR+l2kLez1YMDucjm7v6iuCMVAmZdmxhg5I/X2+OM3vBsqPDdQpr2TPDLX3rCrSBiS0gOQ6DwN5N5QeTkxmY/7QO8bgLo/Wzu1iilH4vMKW6LBKCaRx5UEJxKpL4wkgITsYKneIt3NTHo5EOuaYk+y2+Dvt6EQFiuMsdbfUjs3seIHsghX/cbPJa4YUqZAL8C4OtVHaijwGo0ymt9MWvS9yNKMyT0JhN2/BdeOVWrHk7wXXJn/ZjpXilicXKPx4udCF76meE+6N2u/T+RYZ7fP1QMEtNZNmYDOfA6sViuPDfQSHLNbauJBo/n1sRYAsL5mcG22UDchJrlKvmK3EOADCQg+myrm8006LltubNB4wWNzHDJ0Ls2JGzQZCd/xGyVmUiidCBUrD537WdknOYE4FD7P0cHaM9brKJ/M8LkEH0zUlo73bY4XagbnCqve6PvQb5G2Z55qhWphd6f4B6DGed86zJEa/RhS

mclasen commented 4 years ago

This allows installing certain whitelisted apps from flathub.

johnmh commented 4 years ago

This pull request seems to include proprietary software. This is Fedora, where we normally like to stick to the Four Foundations, the first of which is Freedom.

catanzaro commented 4 years ago

This is fedora-workstation-repositories, which is not installed by default. Its only purpose is to make it easier to install proprietary software, so that's not a concern here.

johnmh commented 4 years ago

If that is the case, why is it in Fedora at all? That sounds like something
for rpmfusion, or similar. I'm pretty sure this is actually against our
policies on proprietary software.

mclasen commented 4 years ago

This has been discussed at length in the council and other places when this package was introduced.

We don't need to rehash this discussion every time the package is touched, do we ?

catanzaro commented 4 years ago

This package is:

Not installed by default
Installs only disabled repos, repos that are themselves not enabled after package installation
Has been approved by Council only subject to the above conditions
Is four years old, so complaining in one particular pull request doesn't make much sense

The effect of this change is to make Steam searchable in GNOME Software, provided the user has previously selected the option to enable third-party repositories. Since we have a filter to ensure only software approved by Legal is displayed, we should be fine.

I assume this will be tested in rawhide for a while, rather than immediately backported.

Pull-Request has been merged by catanzaro

4 years ago

johnmh commented 4 years ago

Clearly, Steam cannot be approved by Legal, as it's not Free software, and it's not in Fedora.

johnmh commented 4 years ago

Additionally, if this package didn't exist solely to include non-free software in a distribution dedicated to Free Software, perhaps these discussions would not occur.

catanzaro commented 4 years ago

See the third-party software policy for the relevant policy.

johnmh commented 4 years ago

Having read this policy, I believe that Fedora Legal needs to be consulted about this addition to the third-party repos maintained for Workstation. I believe that this addition poses undue legal risk for the Fedora Project or its sponsors, especially as this addition includes a repository explicitly for the installation of proprietary software.

Additionally, I don't believe that the requirement of "If the repository offering changes the owner of the repository must notify the Working Group" can be met for this repository.

johnmh commented 4 years ago

I will also point out that that page does not state how proprietary repositories should be handled, only "third party repositories". I don't believe that the intention was for there to be proprietary software included, this being Fedora.

johnmh commented 4 years ago

Please undo this pull request until Fedora Legal can consider the ramifications of this change.

catanzaro commented 4 years ago

John, I linked you to the section of the policy that describes what third-party software would present unacceptable risk. I further explained the intent of the filter is to hide software that we know would present such risk. I do not believe Steam is a significant risk.

Since you have chosen not to accept the intention of the third-party software policy, which is to make it easier for users to install certain proprietary software not distributed by Fedora, I don't think further discussion here will be productive.

mclasen commented 4 years ago

Steam is already on the list of accepted 3rd party repositories.

johnmh commented 4 years ago

Where is this list located?

catanzaro commented 4 years ago

That would be https://src.fedoraproject.org/rpms/fedora-workstation-repositories/tree/master

johnmh commented 4 years ago

In that case, clearly not, as that's literally this repository..