PR#32: Add Recommends for libglvnd-gles (rhbz#1948010) - rpms/firefox

rpms / firefox

#32 Add Recommends for libglvnd-gles (rhbz#1948010)

Closed 2 years ago by stransky. Opened 2 years ago by ngompa.

rpms/ ngompa/firefox add-libglvnd-gles-dep into rawhide

Add Recommends for libglvnd-gles (rhbz#1948010)

Neal Gompa • 2 years ago

5238048

firefox.spec

file modified

+5 -1

		`@@ -154,7 +154,7 @@`
		`Summary: Mozilla Firefox Web browser`
		`Name: firefox`
		`Version: 87.0`
		`- Release: 12%{?pre_tag}%{?dist}`
		`+ Release: 13%{?pre_tag}%{?dist}`
		`URL: https://www.mozilla.org/firefox/`
		`License: MPLv1.1 or GPLv2+ or LGPLv2+`
		`Source0: https://archive.mozilla.org/pub/firefox/releases/%{version}%{?pre_version}/source/firefox-%{version}%{?pre_version}.source.tar.xz`
		`@@ -298,6 +298,7 @@`
		`Requires: mozilla-filesystem`
		`Recommends: mozilla-openh264 >= 2.1.1`
		`Recommends: libva`
		`+ Recommends: libglvnd-gles`
		`Requires: p11-kit-trust`
		`%if %{?system_nss}`
		`Requires: nspr >= %{nspr_build_version}`
		`@@ -1058,6 +1059,9 @@`
		`#---------------------------------------------------------------------`

		`%changelog`
		`+ * Mon Apr 19 2021 Neal Gompa <ngompa13@gmail.com> - 87.0-13`
		`+ - Add Recommends for libglvnd-gles (rhbz#1948010)`
		`+`
		`* Mon Apr 12 2021 Martin Stransky <stransky@redhat.com> - 87.0-12`
		`- Added fix for mozbz#1701089 (Widevine playback issues).`

ngompa commented 2 years ago

This should resolve the issue where Firefox falls back to the broken basic renderer on desktops that don't use GLES itself.

ngompa commented 2 years ago

@stransky Could you please review and merge this and ship it for F34+? It should resolve the remaining OpenQA issues with Firefox on Plasma Wayland (at least it does in virtually every environment I have locally).

cc: @adamwill, @rdieter, @jgrulich

zuul commented 2 years ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

check-for-arches : SUCCESS in 1m 15s
rpm-scratch-build : FAILURE in 13m 10s
rpm-scratch-build-s390x : FAILURE in 12m 26s (non-voting)
rpm-scratch-build-ppc64le : FAILURE in 15m 27s (non-voting)
rpm-scratch-build-i686 : FAILURE in 16m 27s (non-voting)
rpm-scratch-build-armv7hl : FAILURE in 12m 45s (non-voting)
rpm-scratch-build-aarch64 : FAILURE in 17m 40s (non-voting)
rpm-linter : SKIPPED
rpm-rpminspect : SKIPPED (non-voting)
check-for-tests : SKIPPED
rpm-install-test : SKIPPED
rpm-test : SKIPPED

stransky commented 2 years ago

That looks wrong to me....why Firefox should depend on such system-level package? It should be installed by system with other GL libraries (libglvnd / mesa for instance). AFAIK it's installed by Workstation by default but it's missing in KDE spin.

Also, adding such dependence to Firefox will leads to default install on KDE so why not to install it as a part of KDE spin?

Another thing is that Firefox does not depend on libglvnd-gles, it needs GL only when HW acceleration is enabled, it works without it (although it's broken due to Kwin Wayland compositor issues right now).

I think a better solution may be to disable default Firefox Wayland backend for KDE until Kwin is fixed anyway.

adamwill commented 2 years ago

But I tested this in openQA and it didn't help at all. And now I updated my personal system to F34 I'm actually seeing not-fully-rendered popovers there (e.g. Bitwarden's UI) too, and I have libglvnd-gles installed.

rebased onto 148746236e25c8cbda5b1d8101aaa5b946f25664

2 years ago

rebased onto 5238048

2 years ago

ngompa commented 2 years ago

@stransky Can you please review and merge this to fix rhbz#1948010? If you would prefer this to be a Requires, I can do that too.

cc: @bcotton, @rdieter, @adamwill

rdieter commented 2 years ago

Re "That looks wrong to me" comment:

Workstation only installs this library by default because something there explicitly depends on it already. Clearly, that's not the case for kde plasma.

IMO, if firefox needs this runtime library for proper function, then it really should depend on it explicitly. Yes, it's not a hard requirement, but that's why we're advocating for only Recommends here.

What's wrong to me: expecting individual spins to install random runtime libraries to workaround issues like this.

Another approach: if you really think libglvnd-gles should be pre-installed globally (ie, distro-wide), then advocate that to the powers-that-be, but that's outside the scope of this PR