PR#1: Test fprintd build and gating - rpms/fprintd

rpms / fprintd

#1 Test fprintd build and gating

Closed 3 years ago by benzea. Opened 4 years ago by benzea.

rpms/ benzea/fprintd benzea/fprintd-v2 into master

Add gating tests for fprintd

Benjamin Berg • 4 years ago

854b603

git snapshot build of fprintd 1.90.0

Benjamin Berg • 4 years ago

6297505

.gitignore

file modified

		`@@ -8,3 +8,4 @@`
		`/fprintd-0.8.0.tar.xz`
		`/fprintd-0.8.1.tar.xz`
		`/fprintd-0.9.0.tar.xz`
		`+ /fprintd-518cadf.tar.gz`

0001-pam-Fix-rhost-string-length-check.patch

file removed

-25

		`@@ -1,25 +0,0 @@`
		`- From 96444b4156cbc5d0364ac45a7b3288ae28dfbb58 Mon Sep 17 00:00:00 2001`
		`- From: Benjamin Berg <bberg@redhat.com>`
		`- Date: Tue, 13 Aug 2019 14:16:11 +0200`
		`- Subject: [PATCH] pam: Fix rhost string length check`
		`-`
		`- ---`
		`- pam/pam_fprintd.c \| 2 +-`
		`- 1 file changed, 1 insertion(+), 1 deletion(-)`
		`-`
		`- diff --git a/pam/pam_fprintd.c b/pam/pam_fprintd.c`
		`- index 408b74c..b2eee4d 100644`
		`- --- a/pam/pam_fprintd.c`
		`- +++ b/pam/pam_fprintd.c`
		`- @@ -481,7 +481,7 @@ PAM_EXTERN int pam_sm_authenticate(pam_handle_t *pamh, int flags, int argc,`
		`- * "localhost" if the host is local.`
		`- * We want to not run for known remote hosts */`
		`- if (rhost != NULL &&`
		`- - rhost != '\0' &&`
		`- + *rhost != '\0' &&`
		`- strcmp (rhost, "localhost") != 0) {`
		`- return PAM_AUTHINFO_UNAVAIL;`
		`- }`
		`- --`
		`- 2.21.0`
		`-`

fprintd.spec

file modified

+16 -8

		`@@ -1,24 +1,27 @@`
		`Name: fprintd`
		`- Version: 0.9.0`
		`- Release: 1%{?dist}`
		`+`
		`+ %global commit 518cadf19b382dd5134b20bad734b491e76027d5`
		`+ %global shortcommit %(c=%{commit}; echo ${c:0:7})`
		`+`
		`+ Version: 1.90.0`
		`+ Release: 0.20191009git%{shortcommit}%{?dist}`
		`Summary: D-Bus service for Fingerprint reader access`

		`License: GPLv2+`
		`- Source0: https://gitlab.freedesktop.org/libfprint/fprintd/uploads/bdd9f91909f535368b7c21f72311704a/%{name}-%{version}.tar.xz`
		`+ Source0: https://gitlab.freedesktop.org/libfprint/fprintd/-/archive/%{commit}/%{name}-%{shortcommit}.tar.gz`
		`Url: http://www.freedesktop.org/wiki/Software/fprint/fprintd`
		`ExcludeArch: s390 s390x`

		`BuildRequires: dbus-glib-devel`
		`BuildRequires: pam-devel`
		`- BuildRequires: libfprint-devel >= 0.1.0`
		`+ BuildRequires: libfprint-devel >= 1.90.0`
		`BuildRequires: polkit-devel`
		`BuildRequires: gtk-doc`
		`BuildRequires: intltool`
		`BuildRequires: autoconf automake libtool`
		`BuildRequires: perl-podlators`
		`BuildRequires: pkgconfig(systemd)`
		`-`
		`- Patch0: 0001-pam-Fix-rhost-string-length-check.patch`
		`+ BuildRequires: python3-dbusmock`

		`%description`
		`D-Bus service to access fingerprint readers.`
		`@@ -49,9 +52,11 @@`
		`fingerprint readers access.`

		`%prep`
		`- %autosetup -p1 -n %{name}-%{version}`
		`+ %autosetup -p1 -n %{name}-%{commit}`

		`%build`
		`+ # Building a git snapshot, so we need to run autogen`
		`+ ./autogen.sh`
		`%configure --libdir=/%{_lib}/ --enable-gtk-doc --enable-pam`

		`make %{?_smp_mflags}`
		`@@ -76,7 +81,7 @@`
		`%{_libexecdir}/fprintd`
		`# FIXME This file should be marked as config when it does something useful`
		`%{_sysconfdir}/fprintd.conf`
		`- %{_sysconfdir}/dbus-1/system.d/net.reactivated.Fprint.conf`
		`+ %{_datadir}/dbus-1/system.d/net.reactivated.Fprint.conf`
		`%{_datadir}/dbus-1/system-services/net.reactivated.Fprint.service`
		`/usr/lib/systemd/system/fprintd.service`
		`%{_datadir}/polkit-1/actions/net.reactivated.fprint.device.policy`
		`@@ -93,6 +98,9 @@`
		`%{_datadir}/dbus-1/interfaces/net.reactivated.Fprint.Manager.xml`

		`%changelog`
		`+ * Tue Oct 08 2019 Benjamin Berg <bberg@redhat.com> - 1.90.0-0.20191009git%{shortcommit}`
		`+ - git snapshot build of fprintd 1.90.0`
		`+`
		`* Wed Aug 14 2019 Benjamin Berg <bberg@redhat.com> - 0.9.0-1`
		`+ fprintd-0.9.0-1`
		`- Update to 0.9.0`

gating.yaml

file added

		`@@ -0,0 +1,6 @@`
		`+ --- !Policy`
		`+ product_versions:`
		`+ - fedora-*`
		`+ decision_context: bodhi_update_push_testing`
		`+ rules:`
		`+ - !PassingTestCaseRule {test_case_name: dist.depcheck}`

sources

file modified

+1 -1

		`@@ -1,1 +1,1 @@`
		`- SHA512 (fprintd-0.9.0.tar.xz) = c8e5ff2c8134e23c6ed83c6c96587dfbc14e4503ca13fcdfd4103b9d2c00332456fdef2e16ea11b0dfde7642ad762f219c38cc5f1a4d875c6ed1970144de9514`
		`+ SHA512 (fprintd-518cadf.tar.gz) = e72191093956818d0957567c964a901160b57071e95d32ab61d2b1920d86f7f26ee645ae49cea5ed9397858a092da4151c992b30fbbd2c1cdb025a533b311908`

tests/tests.yml

file added

+16

		`@@ -0,0 +1,16 @@`
		`+ ---`
		`+ - hosts: localhost`
		`+ roles:`
		`+ - role: standard-test-source`
		`+ tags:`
		`+ - always`
		`+ - role: standard-test-basic`
		`+ tags:`
		`+ - atomic`
		`+ - classic`
		`+ required_packages:`
		`+ - python3-dbusmock`
		`+ tests:`
		`+ - fprintd:`
		`+ dir: .`
		`+ run: source/tests/fprintd.py`