a8767b3
From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
f524ac5
From: Fedora GDB patches <invalid@email.com>
f524ac5
Date: Fri, 27 Oct 2017 21:07:50 +0200
f524ac5
Subject: gdb-6.6-buildid-locate.patch
f524ac5
f637971
;; New locating of the matching binaries from the pure core file (build-id).
f637971
;;=push+jan
f524ac5
0a2f2a5
diff --git a/bfd/libbfd-in.h b/bfd/libbfd-in.h
0a2f2a5
--- a/bfd/libbfd-in.h
0a2f2a5
+++ b/bfd/libbfd-in.h
2c18014
@@ -121,7 +121,7 @@ static inline char *
0a2f2a5
 bfd_strdup (const char *str)
0a2f2a5
 {
0a2f2a5
   size_t len = strlen (str) + 1;
0a2f2a5
-  char *buf = bfd_malloc (len);
0a2f2a5
+  char *buf = (char *) bfd_malloc (len);
0a2f2a5
   if (buf != NULL)
0a2f2a5
     memcpy (buf, str, len);
0a2f2a5
   return buf;
0a2f2a5
diff --git a/bfd/libbfd.h b/bfd/libbfd.h
0a2f2a5
--- a/bfd/libbfd.h
0a2f2a5
+++ b/bfd/libbfd.h
2c18014
@@ -126,7 +126,7 @@ static inline char *
0a2f2a5
 bfd_strdup (const char *str)
0a2f2a5
 {
0a2f2a5
   size_t len = strlen (str) + 1;
0a2f2a5
-  char *buf = bfd_malloc (len);
0a2f2a5
+  char *buf = (char *) bfd_malloc (len);
0a2f2a5
   if (buf != NULL)
0a2f2a5
     memcpy (buf, str, len);
0a2f2a5
   return buf;
f637971
diff --git a/gdb/build-id.c b/gdb/build-id.c
f637971
--- a/gdb/build-id.c
f637971
+++ b/gdb/build-id.c
2c18014
@@ -24,13 +24,70 @@
f7760f8
 #include "gdbsupport/gdb_vecs.h"
f7760f8
 #include "symfile.h"
f7760f8
 #include "objfiles.h"
e90857f
+#include <sys/stat.h>
e90857f
+#include "elf-bfd.h"
e90857f
+#include "elf/common.h"
e90857f
+#include "elf/external.h"
e90857f
+#include "elf/internal.h"
Jan Kratochvil 2c55a54
 #include "filenames.h"
e90857f
+#include "gdb_bfd.h"
e90857f
+#include "gdbcmd.h"
Jan Kratochvil 32f92b2
 #include "gdbcore.h"
e90857f
+#include "objfiles.h"
2bcd68d
+#include "observable.h"
e90857f
+#include "symfile.h"
Jan Kratochvil 2c55a54
+
917a6fb
+#define BUILD_ID_VERBOSE_NONE 0
917a6fb
+#define BUILD_ID_VERBOSE_FILENAMES 1
917a6fb
+#define BUILD_ID_VERBOSE_BINARY_PARSE 2
917a6fb
+static int build_id_verbose = BUILD_ID_VERBOSE_FILENAMES;
4e2e788
+static void
917a6fb
+show_build_id_verbose (struct ui_file *file, int from_tty,
917a6fb
+		       struct cmd_list_element *c, const char *value)
4e2e788
+{
917a6fb
+  fprintf_filtered (file, _("Verbosity level of the build-id locator is %s.\n"),
4e2e788
+		    value);
4e2e788
+}
Jan Kratochvil 09dd777
+/* Locate NT_GNU_BUILD_ID and return its matching debug filename.
Jan Kratochvil 09dd777
+   FIXME: NOTE decoding should be unified with the BFD core notes decoding.  */
Jan Kratochvil 2f7f533
+
Jan Kratochvil ae96b4a
+static struct bfd_build_id *
4e2e788
+build_id_buf_get (bfd *templ, gdb_byte *buf, bfd_size_type size)
4e2e788
+{
4e2e788
+  bfd_byte *p;
4e2e788
+
4e2e788
+  p = buf;
4e2e788
+  while (p < buf + size)
4e2e788
+    {
4e2e788
+      /* FIXME: bad alignment assumption.  */
4e2e788
+      Elf_External_Note *xnp = (Elf_External_Note *) p;
4e2e788
+      size_t namesz = H_GET_32 (templ, xnp->namesz);
4e2e788
+      size_t descsz = H_GET_32 (templ, xnp->descsz);
Jan Kratochvil 872aab0
+      bfd_byte *descdata = (gdb_byte *) xnp->name + BFD_ALIGN (namesz, 4);
4e2e788
+
4e2e788
+      if (H_GET_32 (templ, xnp->type) == NT_GNU_BUILD_ID
4e2e788
+	  && namesz == sizeof "GNU"
4e2e788
+	  && memcmp (xnp->name, "GNU", sizeof "GNU") == 0)
4e2e788
+	{
a3b5cf4
+	  size_t sz = descsz;
Jan Kratochvil 7306e88
+	  gdb_byte *data = (gdb_byte *) descdata;
Jan Kratochvil ae96b4a
+	  struct bfd_build_id *retval;
4e2e788
+
a3b5cf4
+	  retval = (struct bfd_build_id *) xmalloc (sizeof *retval - 1 + sz);
a3b5cf4
+	  retval->size = sz;
a3b5cf4
+	  memcpy (retval->data, data, sz);
Jan Kratochvil 32f92b2
+
4e2e788
+	  return retval;
4e2e788
+	}
4e2e788
+      p = descdata + BFD_ALIGN (descsz, 4);
4e2e788
+    }
4e2e788
+  return NULL;
4e2e788
+}
Jan Kratochvil 32f92b2
 
Jan Kratochvil 32f92b2
 /* See build-id.h.  */
Jan Kratochvil 32f92b2
 
Jan Kratochvil ae96b4a
 const struct bfd_build_id *
Jan Kratochvil 1054fa6
-build_id_bfd_get (bfd *abfd)
4e2e788
+build_id_bfd_shdr_get (bfd *abfd)
4e2e788
 {
a5d2c85
   if (!bfd_check_format (abfd, bfd_object)
a5d2c85
       && !bfd_check_format (abfd, bfd_core))
2c18014
@@ -43,6 +100,348 @@ build_id_bfd_get (bfd *abfd)
Jan Kratochvil ae96b4a
   return NULL;
4e2e788
 }
4e2e788
 
4e2e788
+/* Core files may have missing (corrupt) SHDR but PDHR is correct there.
4e2e788
+   bfd_elf_bfd_from_remote_memory () has too much overhead by
4e2e788
+   allocating/reading all the available ELF PT_LOADs.  */
4e2e788
+
Jan Kratochvil ae96b4a
+static struct bfd_build_id *
4e2e788
+build_id_phdr_get (bfd *templ, bfd_vma loadbase, unsigned e_phnum,
4e2e788
+		   Elf_Internal_Phdr *i_phdr)
4e2e788
+{
4e2e788
+  int i;
Jan Kratochvil ae96b4a
+  struct bfd_build_id *retval = NULL;
4e2e788
+
4e2e788
+  for (i = 0; i < e_phnum; i++)
4e2e788
+    if (i_phdr[i].p_type == PT_NOTE && i_phdr[i].p_filesz > 0)
4e2e788
+      {
4e2e788
+	Elf_Internal_Phdr *hdr = &i_phdr[i];
4e2e788
+	gdb_byte *buf;
4e2e788
+	int err;
4e2e788
+
Jan Kratochvil 7306e88
+	buf = (gdb_byte *) xmalloc (hdr->p_filesz);
4e2e788
+	err = target_read_memory (loadbase + i_phdr[i].p_vaddr, buf,
4e2e788
+				  hdr->p_filesz);
4e2e788
+	if (err == 0)
4e2e788
+	  retval = build_id_buf_get (templ, buf, hdr->p_filesz);
4e2e788
+	else
4e2e788
+	  retval = NULL;
4e2e788
+	xfree (buf);
4e2e788
+	if (retval != NULL)
4e2e788
+	  break;
4e2e788
+      }
4e2e788
+  return retval;
4e2e788
+}
4e2e788
+
4e2e788
+/* First we validate the file by reading in the ELF header and checking
4e2e788
+   the magic number.  */
4e2e788
+
4e2e788
+static inline bfd_boolean
4e2e788
+elf_file_p (Elf64_External_Ehdr *x_ehdrp64)
4e2e788
+{
4e2e788
+  gdb_assert (sizeof (Elf64_External_Ehdr) >= sizeof (Elf32_External_Ehdr));
4e2e788
+  gdb_assert (offsetof (Elf64_External_Ehdr, e_ident)
4e2e788
+	      == offsetof (Elf32_External_Ehdr, e_ident));
4e2e788
+  gdb_assert (sizeof (((Elf64_External_Ehdr *) 0)->e_ident)
4e2e788
+	      == sizeof (((Elf32_External_Ehdr *) 0)->e_ident));
4e2e788
+
4e2e788
+  return ((x_ehdrp64->e_ident[EI_MAG0] == ELFMAG0)
4e2e788
+	  && (x_ehdrp64->e_ident[EI_MAG1] == ELFMAG1)
4e2e788
+	  && (x_ehdrp64->e_ident[EI_MAG2] == ELFMAG2)
4e2e788
+	  && (x_ehdrp64->e_ident[EI_MAG3] == ELFMAG3));
4e2e788
+}
4e2e788
+
4e2e788
+/* Translate an ELF file header in external format into an ELF file header in
4e2e788
+   internal format.  */
4e2e788
+
4e2e788
+#define H_GET_WORD(bfd, ptr) (is64 ? H_GET_64 (bfd, (ptr))		\
4e2e788
+				   : H_GET_32 (bfd, (ptr)))
4e2e788
+#define H_GET_SIGNED_WORD(bfd, ptr) (is64 ? H_GET_S64 (bfd, (ptr))	\
4e2e788
+					  : H_GET_S32 (bfd, (ptr)))
4e2e788
+
4e2e788
+static void
4e2e788
+elf_swap_ehdr_in (bfd *abfd,
4e2e788
+		  const Elf64_External_Ehdr *src64,
4e2e788
+		  Elf_Internal_Ehdr *dst)
4e2e788
+{
4e2e788
+  int is64 = bfd_get_arch_size (abfd) == 64;
4e2e788
+#define SRC(field) (is64 ? src64->field \
4e2e788
+			 : ((const Elf32_External_Ehdr *) src64)->field)
4e2e788
+
4e2e788
+  int signed_vma = get_elf_backend_data (abfd)->sign_extend_vma;
4e2e788
+  memcpy (dst->e_ident, SRC (e_ident), EI_NIDENT);
4e2e788
+  dst->e_type = H_GET_16 (abfd, SRC (e_type));
4e2e788
+  dst->e_machine = H_GET_16 (abfd, SRC (e_machine));
4e2e788
+  dst->e_version = H_GET_32 (abfd, SRC (e_version));
4e2e788
+  if (signed_vma)
4e2e788
+    dst->e_entry = H_GET_SIGNED_WORD (abfd, SRC (e_entry));
4e2e788
+  else
4e2e788
+    dst->e_entry = H_GET_WORD (abfd, SRC (e_entry));
4e2e788
+  dst->e_phoff = H_GET_WORD (abfd, SRC (e_phoff));
4e2e788
+  dst->e_shoff = H_GET_WORD (abfd, SRC (e_shoff));
4e2e788
+  dst->e_flags = H_GET_32 (abfd, SRC (e_flags));
4e2e788
+  dst->e_ehsize = H_GET_16 (abfd, SRC (e_ehsize));
4e2e788
+  dst->e_phentsize = H_GET_16 (abfd, SRC (e_phentsize));
4e2e788
+  dst->e_phnum = H_GET_16 (abfd, SRC (e_phnum));
4e2e788
+  dst->e_shentsize = H_GET_16 (abfd, SRC (e_shentsize));
4e2e788
+  dst->e_shnum = H_GET_16 (abfd, SRC (e_shnum));
4e2e788
+  dst->e_shstrndx = H_GET_16 (abfd, SRC (e_shstrndx));
4e2e788
+
4e2e788
+#undef SRC
4e2e788
+}
4e2e788
+
4e2e788
+/* Translate an ELF program header table entry in external format into an
4e2e788
+   ELF program header table entry in internal format.  */
4e2e788
+
Jan Kratochvil f8eee05
+static void
4e2e788
+elf_swap_phdr_in (bfd *abfd,
4e2e788
+		  const Elf64_External_Phdr *src64,
4e2e788
+		  Elf_Internal_Phdr *dst)
4e2e788
+{
4e2e788
+  int is64 = bfd_get_arch_size (abfd) == 64;
4e2e788
+#define SRC(field) (is64 ? src64->field					\
4e2e788
+			 : ((const Elf32_External_Phdr *) src64)->field)
4e2e788
+
4e2e788
+  int signed_vma = get_elf_backend_data (abfd)->sign_extend_vma;
4e2e788
+
4e2e788
+  dst->p_type = H_GET_32 (abfd, SRC (p_type));
4e2e788
+  dst->p_flags = H_GET_32 (abfd, SRC (p_flags));
4e2e788
+  dst->p_offset = H_GET_WORD (abfd, SRC (p_offset));
4e2e788
+  if (signed_vma)
4e2e788
+    {
4e2e788
+      dst->p_vaddr = H_GET_SIGNED_WORD (abfd, SRC (p_vaddr));
4e2e788
+      dst->p_paddr = H_GET_SIGNED_WORD (abfd, SRC (p_paddr));
4e2e788
+    }
4e2e788
+  else
4e2e788
+    {
4e2e788
+      dst->p_vaddr = H_GET_WORD (abfd, SRC (p_vaddr));
4e2e788
+      dst->p_paddr = H_GET_WORD (abfd, SRC (p_paddr));
4e2e788
+    }
4e2e788
+  dst->p_filesz = H_GET_WORD (abfd, SRC (p_filesz));
4e2e788
+  dst->p_memsz = H_GET_WORD (abfd, SRC (p_memsz));
4e2e788
+  dst->p_align = H_GET_WORD (abfd, SRC (p_align));
4e2e788
+
4e2e788
+#undef SRC
4e2e788
+}
4e2e788
+
4e2e788
+#undef H_GET_SIGNED_WORD
4e2e788
+#undef H_GET_WORD
4e2e788
+
4e2e788
+static Elf_Internal_Phdr *
4e2e788
+elf_get_phdr (bfd *templ, bfd_vma ehdr_vma, unsigned *e_phnum_pointer,
4e2e788
+              bfd_vma *loadbase_pointer)
4e2e788
+{
4e2e788
+  /* sizeof (Elf64_External_Ehdr) >= sizeof (Elf32_External_Ehdr)  */
4e2e788
+  Elf64_External_Ehdr x_ehdr64;	/* Elf file header, external form */
4e2e788
+  Elf_Internal_Ehdr i_ehdr;	/* Elf file header, internal form */
4e2e788
+  bfd_size_type x_phdrs_size;
4e2e788
+  gdb_byte *x_phdrs_ptr;
4e2e788
+  Elf_Internal_Phdr *i_phdrs;
4e2e788
+  int err;
4e2e788
+  unsigned int i;
4e2e788
+  bfd_vma loadbase;
4e2e788
+  int loadbase_set;
4e2e788
+
4e2e788
+  gdb_assert (templ != NULL);
4e2e788
+  gdb_assert (sizeof (Elf64_External_Ehdr) >= sizeof (Elf32_External_Ehdr));
4e2e788
+
4e2e788
+  /* Read in the ELF header in external format.  */
4e2e788
+  err = target_read_memory (ehdr_vma, (bfd_byte *) &x_ehdr64, sizeof x_ehdr64);
4e2e788
+  if (err)
4e2e788
+    {
917a6fb
+      if (build_id_verbose >= BUILD_ID_VERBOSE_BINARY_PARSE)
4e2e788
+        warning (_("build-id: Error reading ELF header at address 0x%lx"),
4e2e788
+		 (unsigned long) ehdr_vma);
4e2e788
+      return NULL;
4e2e788
+    }
4e2e788
+
4e2e788
+  /* Now check to see if we have a valid ELF file, and one that BFD can
4e2e788
+     make use of.  The magic number must match, the address size ('class')
4e2e788
+     and byte-swapping must match our XVEC entry.  */
4e2e788
+
4e2e788
+  if (! elf_file_p (&x_ehdr64)
4e2e788
+      || x_ehdr64.e_ident[EI_VERSION] != EV_CURRENT
4e2e788
+      || !((bfd_get_arch_size (templ) == 64
4e2e788
+            && x_ehdr64.e_ident[EI_CLASS] == ELFCLASS64)
4e2e788
+           || (bfd_get_arch_size (templ) == 32
4e2e788
+	       && x_ehdr64.e_ident[EI_CLASS] == ELFCLASS32)))
4e2e788
+    {
917a6fb
+      if (build_id_verbose >= BUILD_ID_VERBOSE_BINARY_PARSE)
4e2e788
+        warning (_("build-id: Unrecognized ELF header at address 0x%lx"),
4e2e788
+		 (unsigned long) ehdr_vma);
4e2e788
+      return NULL;
4e2e788
+    }
4e2e788
+
4e2e788
+  /* Check that file's byte order matches xvec's */
4e2e788
+  switch (x_ehdr64.e_ident[EI_DATA])
4e2e788
+    {
4e2e788
+    case ELFDATA2MSB:		/* Big-endian */
4e2e788
+      if (! bfd_header_big_endian (templ))
4e2e788
+	{
917a6fb
+	  if (build_id_verbose >= BUILD_ID_VERBOSE_BINARY_PARSE)
4e2e788
+	    warning (_("build-id: Unrecognized "
4e2e788
+		       "big-endian ELF header at address 0x%lx"),
4e2e788
+		     (unsigned long) ehdr_vma);
4e2e788
+	  return NULL;
4e2e788
+	}
4e2e788
+      break;
4e2e788
+    case ELFDATA2LSB:		/* Little-endian */
4e2e788
+      if (! bfd_header_little_endian (templ))
4e2e788
+	{
917a6fb
+	  if (build_id_verbose >= BUILD_ID_VERBOSE_BINARY_PARSE)
4e2e788
+	    warning (_("build-id: Unrecognized "
4e2e788
+		       "little-endian ELF header at address 0x%lx"),
4e2e788
+		     (unsigned long) ehdr_vma);
4e2e788
+	  return NULL;
4e2e788
+	}
4e2e788
+      break;
4e2e788
+    case ELFDATANONE:		/* No data encoding specified */
4e2e788
+    default:			/* Unknown data encoding specified */
917a6fb
+      if (build_id_verbose >= BUILD_ID_VERBOSE_BINARY_PARSE)
4e2e788
+	warning (_("build-id: Unrecognized "
4e2e788
+		   "ELF header endianity at address 0x%lx"),
4e2e788
+		 (unsigned long) ehdr_vma);
4e2e788
+      return NULL;
4e2e788
+    }
4e2e788
+
4e2e788
+  elf_swap_ehdr_in (templ, &x_ehdr64, &i_ehdr);
4e2e788
+
4e2e788
+  /* The file header tells where to find the program headers.
4e2e788
+     These are what we use to actually choose what to read.  */
4e2e788
+
4e2e788
+  if (i_ehdr.e_phentsize != (bfd_get_arch_size (templ) == 64
4e2e788
+                             ? sizeof (Elf64_External_Phdr)
4e2e788
+			     : sizeof (Elf32_External_Phdr))
4e2e788
+      || i_ehdr.e_phnum == 0)
4e2e788
+    {
917a6fb
+      if (build_id_verbose >= BUILD_ID_VERBOSE_BINARY_PARSE)
4e2e788
+	warning (_("build-id: Invalid ELF program headers from the ELF header "
4e2e788
+		   "at address 0x%lx"), (unsigned long) ehdr_vma);
4e2e788
+      return NULL;
4e2e788
+    }
4e2e788
+
4e2e788
+  x_phdrs_size = (bfd_get_arch_size (templ) == 64 ? sizeof (Elf64_External_Phdr)
4e2e788
+						: sizeof (Elf32_External_Phdr));
4e2e788
+
Jan Kratochvil 7306e88
+  i_phdrs = (Elf_Internal_Phdr *) xmalloc (i_ehdr.e_phnum * (sizeof *i_phdrs + x_phdrs_size));
Jan Kratochvil 7306e88
+  x_phdrs_ptr = (gdb_byte *) &i_phdrs[i_ehdr.e_phnum];
4e2e788
+  err = target_read_memory (ehdr_vma + i_ehdr.e_phoff, (bfd_byte *) x_phdrs_ptr,
4e2e788
+			    i_ehdr.e_phnum * x_phdrs_size);
4e2e788
+  if (err)
4e2e788
+    {
4e2e788
+      free (i_phdrs);
917a6fb
+      if (build_id_verbose >= BUILD_ID_VERBOSE_BINARY_PARSE)
4e2e788
+        warning (_("build-id: Error reading "
4e2e788
+		   "ELF program headers at address 0x%lx"),
cc17157
+		 (unsigned long) (ehdr_vma + i_ehdr.e_phoff));
4e2e788
+      return NULL;
4e2e788
+    }
4e2e788
+
4e2e788
+  loadbase = ehdr_vma;
4e2e788
+  loadbase_set = 0;
4e2e788
+  for (i = 0; i < i_ehdr.e_phnum; ++i)
4e2e788
+    {
4e2e788
+      elf_swap_phdr_in (templ, (Elf64_External_Phdr *)
4e2e788
+			       (x_phdrs_ptr + i * x_phdrs_size), &i_phdrs[i]);
4e2e788
+      /* IA-64 vDSO may have two mappings for one segment, where one mapping
4e2e788
+	 is executable only, and one is read only.  We must not use the
4e2e788
+	 executable one (PF_R is the first one, PF_X the second one).  */
4e2e788
+      if (i_phdrs[i].p_type == PT_LOAD && (i_phdrs[i].p_flags & PF_R))
4e2e788
+	{
4e2e788
+	  /* Only the first PT_LOAD segment indicates the file bias.
4e2e788
+	     Next segments may have P_VADDR arbitrarily higher.
4e2e788
+	     If the first segment has P_VADDR zero any next segment must not
4e2e788
+	     confuse us, the first one sets LOADBASE certainly enough.  */
4e2e788
+	  if (!loadbase_set && i_phdrs[i].p_offset == 0)
4e2e788
+	    {
4e2e788
+	      loadbase = ehdr_vma - i_phdrs[i].p_vaddr;
4e2e788
+	      loadbase_set = 1;
4e2e788
+	    }
4e2e788
+	}
4e2e788
+    }
4e2e788
+
917a6fb
+  if (build_id_verbose >= BUILD_ID_VERBOSE_BINARY_PARSE)
4e2e788
+    warning (_("build-id: Found ELF header at address 0x%lx, loadbase 0x%lx"),
4e2e788
+	     (unsigned long) ehdr_vma, (unsigned long) loadbase);
4e2e788
+
4e2e788
+  *e_phnum_pointer = i_ehdr.e_phnum;
4e2e788
+  *loadbase_pointer = loadbase;
4e2e788
+  return i_phdrs;
4e2e788
+}
4e2e788
+
4e2e788
+/* BUILD_ID_ADDR_GET gets ADDR located somewhere in the object.
4e2e788
+   Find the first section before ADDR containing an ELF header.
4e2e788
+   We rely on the fact the sections from multiple files do not mix.
4e2e788
+   FIXME: We should check ADDR is contained _inside_ the section with possibly
4e2e788
+   missing content (P_FILESZ < P_MEMSZ).  These omitted sections are currently
4e2e788
+   hidden by _BFD_ELF_MAKE_SECTION_FROM_PHDR.  */
4e2e788
+
4e2e788
+static CORE_ADDR build_id_addr;
4e2e788
+struct build_id_addr_sect
4e2e788
+  {
4e2e788
+    struct build_id_addr_sect *next;
4e2e788
+    asection *sect;
4e2e788
+  };
4e2e788
+static struct build_id_addr_sect *build_id_addr_sect;
4e2e788
+
4e2e788
+static void build_id_addr_candidate (bfd *abfd, asection *sect, void *obj)
4e2e788
+{
0a2f2a5
+  if (build_id_addr >= bfd_section_vma (sect))
4e2e788
+    {
4e2e788
+      struct build_id_addr_sect *candidate;
4e2e788
+
Jan Kratochvil 7306e88
+      candidate = (struct build_id_addr_sect *) xmalloc (sizeof *candidate);
4e2e788
+      candidate->next = build_id_addr_sect;
4e2e788
+      build_id_addr_sect = candidate;
4e2e788
+      candidate->sect = sect;
4e2e788
+    }
4e2e788
+}
4e2e788
+
Jan Kratochvil ae96b4a
+struct bfd_build_id *
4e2e788
+build_id_addr_get (CORE_ADDR addr)
4e2e788
+{
4e2e788
+  struct build_id_addr_sect *candidate;
Jan Kratochvil ae96b4a
+  struct bfd_build_id *retval = NULL;
4e2e788
+  Elf_Internal_Phdr *i_phdr = NULL;
4e2e788
+  bfd_vma loadbase = 0;
4e2e788
+  unsigned e_phnum = 0;
4e2e788
+
4e2e788
+  if (core_bfd == NULL)
4e2e788
+    return NULL;
4e2e788
+
4e2e788
+  build_id_addr = addr;
4e2e788
+  gdb_assert (build_id_addr_sect == NULL);
4e2e788
+  bfd_map_over_sections (core_bfd, build_id_addr_candidate, NULL);
4e2e788
+
4e2e788
+  /* Sections are sorted in the high-to-low VMAs order.
4e2e788
+     Stop the search on the first ELF header we find.
4e2e788
+     Do not continue the search even if it does not contain NT_GNU_BUILD_ID.  */
4e2e788
+
4e2e788
+  for (candidate = build_id_addr_sect; candidate != NULL;
4e2e788
+       candidate = candidate->next)
4e2e788
+    {
4e2e788
+      i_phdr = elf_get_phdr (core_bfd,
0a2f2a5
+			     bfd_section_vma (candidate->sect),
4e2e788
+			     &e_phnum, &loadbase);
4e2e788
+      if (i_phdr != NULL)
4e2e788
+	break;
4e2e788
+    }
4e2e788
+
4e2e788
+  if (i_phdr != NULL)
4e2e788
+    {
4e2e788
+      retval = build_id_phdr_get (core_bfd, loadbase, e_phnum, i_phdr);
4e2e788
+      xfree (i_phdr);
4e2e788
+    }
4e2e788
+
4e2e788
+  while (build_id_addr_sect != NULL)
4e2e788
+    {
4e2e788
+      candidate = build_id_addr_sect;
4e2e788
+      build_id_addr_sect = candidate->next;
4e2e788
+      xfree (candidate);
4e2e788
+    }
4e2e788
+
4e2e788
+  return retval;
4e2e788
+}
4e2e788
+
Jan Kratochvil 2c55a54
 /* See build-id.h.  */
4e2e788
 
Jan Kratochvil 2c55a54
 int
2c18014
@@ -51,7 +450,7 @@ build_id_verify (bfd *abfd, size_t check_len, const bfd_byte *check)
Jan Kratochvil ae96b4a
   const struct bfd_build_id *found;
Jan Kratochvil 2c55a54
   int retval = 0;
4e2e788
 
4e2e788
-  found = build_id_bfd_get (abfd);
4e2e788
+  found = build_id_bfd_shdr_get (abfd);
4e2e788
 
4e2e788
   if (found == NULL)
Jan Kratochvil 2c55a54
     warning (_("File \"%s\" has no build-id, file skipped"),
2c18014
@@ -66,56 +465,159 @@ build_id_verify (bfd *abfd, size_t check_len, const bfd_byte *check)
Jan Kratochvil 2c55a54
   return retval;
eb9d945
 }
4e2e788
 
Jan Kratochvil 2c55a54
+static char *
Jan Kratochvil 752ff76
+link_resolve (const char *symlink, int level)
Jan Kratochvil 752ff76
+{
Jan Kratochvil 752ff76
+  char buf[PATH_MAX + 1], *target, *retval;
Jan Kratochvil 752ff76
+  ssize_t got;
Jan Kratochvil 752ff76
+
Jan Kratochvil 752ff76
+  if (level > 10)
Jan Kratochvil 752ff76
+    return xstrdup (symlink);
Jan Kratochvil 752ff76
+
Jan Kratochvil 752ff76
+  got = readlink (symlink, buf, sizeof (buf));
Jan Kratochvil 752ff76
+  if (got < 0 || got >= sizeof (buf))
Jan Kratochvil 752ff76
+    return xstrdup (symlink);
Jan Kratochvil 752ff76
+  buf[got] = '\0';
Jan Kratochvil 752ff76
+
Jan Kratochvil 752ff76
+  if (IS_ABSOLUTE_PATH (buf))
Jan Kratochvil 752ff76
+    target = xstrdup (buf);
Jan Kratochvil 752ff76
+  else
Jan Kratochvil 752ff76
+    {
Jan Kratochvil 5bb0f3b
+      const std::string dir (ldirname (symlink));
Jan Kratochvil 752ff76
+
Jan Kratochvil 752ff76
+      target = xstrprintf ("%s"
Jan Kratochvil 752ff76
+#ifndef HAVE_DOS_BASED_FILE_SYSTEM
Jan Kratochvil 752ff76
+			   "/"
Jan Kratochvil 752ff76
+#else /* HAVE_DOS_BASED_FILE_SYSTEM */
Jan Kratochvil 752ff76
+			   "\\"
Jan Kratochvil 752ff76
+#endif /* HAVE_DOS_BASED_FILE_SYSTEM */
Jan Kratochvil 5bb0f3b
+			   "%s", dir.c_str(), buf);
Jan Kratochvil 752ff76
+    }
Jan Kratochvil 752ff76
+
Jan Kratochvil 752ff76
+  retval = link_resolve (target, level + 1);
Jan Kratochvil 752ff76
+  xfree (target);
Jan Kratochvil 752ff76
+  return retval;
Jan Kratochvil 752ff76
+}
Jan Kratochvil 752ff76
+
29841d1
 /* Helper for build_id_to_debug_bfd.  LINK is a path to a potential
29841d1
    build-id-based separate debug file, potentially a symlink to the real file.
29841d1
    If the file exists and matches BUILD_ID, return a BFD reference to it.  */
Jan Kratochvil 2c55a54
 
29841d1
 static gdb_bfd_ref_ptr
29841d1
-build_id_to_debug_bfd_1 (const std::string &link, size_t build_id_len,
29841d1
-			 const bfd_byte *build_id)
29841d1
+build_id_to_debug_bfd_1 (const std::string &orig_link, size_t build_id_len,
a5d2c85
+			 const bfd_byte *build_id, char **link_return)
4e2e788
 {
29841d1
+  gdb_bfd_ref_ptr ret_bfd = {};
29841d1
+  std::string ret_link;
29841d1
+
29841d1
   if (separate_debug_file_debug)
2bcd68d
     {
29841d1
-      printf_unfiltered (_("  Trying %s..."), link.c_str ());
29841d1
+      printf_unfiltered (_("  Trying %s..."), orig_link.c_str ());
29841d1
       gdb_flush (gdb_stdout);
29841d1
     }
2bcd68d
 
29841d1
-  /* lrealpath() is expensive even for the usually non-existent files.  */
29841d1
-  gdb::unique_xmalloc_ptr<char> filename;
29841d1
-  if (access (link.c_str (), F_OK) == 0)
29841d1
-    filename.reset (lrealpath (link.c_str ()));
2bcd68d
-
29841d1
-  if (filename == NULL)
29841d1
+  for (unsigned seqno = 0;; seqno++)
29841d1
     {
29841d1
-      if (separate_debug_file_debug)
29841d1
-	printf_unfiltered (_(" no, unable to compute real path\n"));
29841d1
+      std::string link = orig_link;
f637971
 
29841d1
-      return {};
29841d1
-    }
29841d1
+      if (seqno > 0)
29841d1
+	{
29841d1
+	  /* There can be multiple build-id symlinks pointing to real files
29841d1
+	     with the same build-id (such as hard links).  Some of the real
29841d1
+	     files may not be installed.  */
Jan Kratochvil 2c55a54
 
29841d1
-  /* We expect to be silent on the non-existing files.  */
2c18014
-  gdb_bfd_ref_ptr debug_bfd = gdb_bfd_open (filename.get (), gnutarget);
29841d1
+	  string_appendf (link, ".%u", seqno);
29841d1
+	}
29841d1
 
29841d1
-  if (debug_bfd == NULL)
29841d1
-    {
29841d1
-      if (separate_debug_file_debug)
29841d1
-	printf_unfiltered (_(" no, unable to open.\n"));
29841d1
+      ret_link = link;
Jan Kratochvil 1054fa6
+
29841d1
+      struct stat statbuf_trash;
Jan Kratochvil 752ff76
+
29841d1
+      /* `access' automatically dereferences LINK.  */
29841d1
+      if (lstat (link.c_str (), &statbuf_trash) != 0)
29841d1
+	{
29841d1
+	  /* Stop increasing SEQNO.  */
29841d1
+	  break;
29841d1
+	}
31f5b96
+
29841d1
+      /* lrealpath() is expensive even for the usually non-existent files.  */
29841d1
+      gdb::unique_xmalloc_ptr<char> filename;
31f5b96
+
29841d1
+      if (access (link.c_str (), F_OK) == 0)
29841d1
+	filename.reset (lrealpath (link.c_str ()));
Jan Kratochvil 4adfc8b
+
29841d1
+      if (filename == NULL)
29841d1
+	{
29841d1
+	  if (separate_debug_file_debug)
29841d1
+	    printf_unfiltered (_(" no, unable to compute real path\n"));
Jan Kratochvil af2c2a5
+
29841d1
+	  continue;
29841d1
+	}
a5d2c85
 
a5d2c85
-      return {};
29841d1
+      /* We expect to be silent on the non-existing files.  */
29841d1
+      gdb_bfd_ref_ptr debug_bfd = gdb_bfd_open (filename.get (), gnutarget, -1);
f7760f8
+
29841d1
+      if (debug_bfd == NULL)
29841d1
+	{
29841d1
+	  if (separate_debug_file_debug)
29841d1
+	    printf_unfiltered (_(" no, unable to open.\n"));
31f5b96
+
29841d1
+	  continue;
29841d1
+	}
f637971
+
29841d1
+      if (!build_id_verify (debug_bfd.get(), build_id_len, build_id))
29841d1
+	{
29841d1
+	  if (separate_debug_file_debug)
29841d1
+	    printf_unfiltered (_(" no, build-id does not match.\n"));
f637971
+
29841d1
+	  continue;
0911f37
+	}
e90857f
+
29841d1
+      ret_bfd = debug_bfd;
29841d1
+      break;
29841d1
     }
Jan Kratochvil af2c2a5
 
29841d1
-  if (!build_id_verify (debug_bfd.get(), build_id_len, build_id))
29841d1
+  std::string link_all;
29841d1
+
29841d1
+  if (ret_bfd != NULL)
29841d1
     {
29841d1
       if (separate_debug_file_debug)
29841d1
-	printf_unfiltered (_(" no, build-id does not match.\n"));
a5d2c85
-
a5d2c85
-      return {};
29841d1
+	printf_unfiltered (_(" yes!\n"));
29841d1
+    }
29841d1
+  else
29841d1
+    {
29841d1
+      /* If none of the real files is found report as missing file
29841d1
+	 always the non-.%u-suffixed file.  */
29841d1
+      std::string link0 = orig_link;
29841d1
+
Jan Kratochvil 752ff76
+      /* If the symlink has target request to install the target.
29841d1
+	 BASE-debuginfo.rpm contains the symlink but BASE.rpm may be missing.
29841d1
+	 https://bugzilla.redhat.com/show_bug.cgi?id=981154  */
2bcd68d
+      std::string link0_resolved (link_resolve (link0.c_str (), 0));
a5d2c85
+
2bcd68d
+      if (link_all.empty ())
Jan Kratochvil 2c55a54
+	link_all = link0_resolved;
Jan Kratochvil 752ff76
+      else
29841d1
+	{
Jan Kratochvil 752ff76
+	  /* Use whitespace instead of DIRNAME_SEPARATOR to be compatible with
Jan Kratochvil 752ff76
+	     its possible use as an argument for installation command.  */
2bcd68d
+	  link_all += " " + link0_resolved;
29841d1
+	}
29841d1
     }
2bcd68d
 
29841d1
-  if (separate_debug_file_debug)
29841d1
-    printf_unfiltered (_(" yes!\n"));
4e2e788
+  if (link_return != NULL)
0911f37
+    {
29841d1
+      if (ret_bfd != NULL)
29841d1
+	{
29841d1
+	  *link_return = xstrdup (ret_link.c_str ());
29841d1
+	}
29841d1
+      else
29841d1
+	{
2bcd68d
+	  *link_return = xstrdup (link_all.c_str ());
29841d1
+	}
29841d1
+    }
29841d1
 
29841d1
-  return debug_bfd;
29841d1
+  return ret_bfd;
29841d1
 }
29841d1
 
a5d2c85
 /* Common code for finding BFDs of a given build-id.  This function
2c18014
@@ -124,7 +626,7 @@ build_id_to_debug_bfd_1 (const std::string &link, size_t build_id_len,
29841d1
 
a5d2c85
 static gdb_bfd_ref_ptr
a5d2c85
 build_id_to_bfd_suffix (size_t build_id_len, const bfd_byte *build_id,
a5d2c85
-			const char *suffix)
a5d2c85
+			const char *suffix, char **link_return)
29841d1
 {
29841d1
   /* Keep backward compatibility so that DEBUG_FILE_DIRECTORY being "" will
29841d1
      cause "/.build-id/..." lookups.  */
2c18014
@@ -147,16 +649,17 @@ build_id_to_bfd_suffix (size_t build_id_len, const bfd_byte *build_id,
29841d1
       if (size > 0)
29841d1
 	{
29841d1
 	  size--;
29841d1
-	  string_appendf (link, "%02x/", (unsigned) *data++);
29841d1
+	  string_appendf (link, "%02x", (unsigned) *data++);
31f5b96
 	}
31f5b96
-
29841d1
+      if (size > 0)
29841d1
+	link += "/";
29841d1
       while (size-- > 0)
29841d1
 	string_appendf (link, "%02x", (unsigned) *data++);
Jan Kratochvil f8eee05
 
a5d2c85
       link += suffix;
a5d2c85
 
29841d1
       gdb_bfd_ref_ptr debug_bfd
29841d1
-	= build_id_to_debug_bfd_1 (link, build_id_len, build_id);
a5d2c85
+	= build_id_to_debug_bfd_1 (link, build_id_len, build_id, link_return);
29841d1
       if (debug_bfd != NULL)
29841d1
 	return debug_bfd;
29841d1
 
2c18014
@@ -170,7 +673,8 @@ build_id_to_bfd_suffix (size_t build_id_len, const bfd_byte *build_id,
29841d1
       if (strcmp (gdb_sysroot, TARGET_SYSROOT_PREFIX) != 0)
29841d1
 	{
29841d1
 	  link = gdb_sysroot + link;
29841d1
-	  debug_bfd = build_id_to_debug_bfd_1 (link, build_id_len, build_id);
29841d1
+	  debug_bfd = build_id_to_debug_bfd_1 (link, build_id_len, build_id,
a5d2c85
+					       link_return);
29841d1
 	  if (debug_bfd != NULL)
29841d1
 	    return debug_bfd;
29841d1
 	}
2c18014
@@ -179,38 +683,208 @@ build_id_to_bfd_suffix (size_t build_id_len, const bfd_byte *build_id,
29841d1
   return {};
Jan Kratochvil f8eee05
 }
Jan Kratochvil f8eee05
 
Jan Kratochvil 2c55a54
+char *
Jan Kratochvil ae96b4a
+build_id_to_filename (const struct bfd_build_id *build_id, char **link_return)
Jan Kratochvil 2c55a54
+{
Jan Kratochvil af2c2a5
+  gdb_bfd_ref_ptr abfd;
Jan Kratochvil 2c55a54
+  char *result;
Jan Kratochvil 2c55a54
+  
a5d2c85
+  abfd = build_id_to_exec_bfd (build_id->size, build_id->data, link_return);
Jan Kratochvil 2c55a54
+  if (abfd == NULL)
Jan Kratochvil 2c55a54
+    return NULL;
Jan Kratochvil 2c55a54
+
0a2f2a5
+  result = xstrdup (bfd_get_filename (abfd.get ()));
Jan Kratochvil 2c55a54
+  return result;
Jan Kratochvil 2c55a54
+}
Jan Kratochvil 2c55a54
+
338fe93
+/* This MISSING_FILEPAIR_HASH tracker is used only for the duplicite messages
eb11e3c
+     Try to install the hash file ...
338fe93
+   avoidance.  */
338fe93
+
338fe93
+struct missing_filepair
6a80c39
+  {
6a80c39
+    char *binary;
6a80c39
+    char *debug;
6a80c39
+    char data[1];
6a80c39
+  };
6a80c39
+
338fe93
+static struct htab *missing_filepair_hash;
338fe93
+static struct obstack missing_filepair_obstack;
6a80c39
+
6a80c39
+static void *
338fe93
+missing_filepair_xcalloc (size_t nmemb, size_t nmemb_size)
6a80c39
+{
6a80c39
+  void *retval;
6a80c39
+  size_t size = nmemb * nmemb_size;
338fe93
+
338fe93
+  retval = obstack_alloc (&missing_filepair_obstack, size);
6a80c39
+  memset (retval, 0, size);
Jan Kratochvil f8eee05
+  return retval;
Jan Kratochvil f8eee05
+}
Jan Kratochvil f8eee05
+
6a80c39
+static hashval_t
338fe93
+missing_filepair_hash_func (const struct missing_filepair *elem)
6a80c39
+{
338fe93
+  hashval_t retval = 0;
338fe93
+
338fe93
+  retval ^= htab_hash_string (elem->binary);
338fe93
+  if (elem->debug != NULL)
338fe93
+    retval ^= htab_hash_string (elem->debug);
338fe93
+
Jan Kratochvil 4adfc8b
+  return retval;
Jan Kratochvil 4adfc8b
+}
Jan Kratochvil 4adfc8b
+
6a80c39
+static int
338fe93
+missing_filepair_eq (const struct missing_filepair *elem1,
338fe93
+		       const struct missing_filepair *elem2)
6a80c39
+{
6a80c39
+  return strcmp (elem1->binary, elem2->binary) == 0
c030186
+         && ((elem1->debug == NULL) == (elem2->debug == NULL))
c030186
+         && (elem1->debug == NULL || strcmp (elem1->debug, elem2->debug) == 0);
6a80c39
+}
6a80c39
+
6a80c39
+static void
338fe93
+missing_filepair_change (void)
6a80c39
+{
338fe93
+  if (missing_filepair_hash != NULL)
6a80c39
+    {
338fe93
+      obstack_free (&missing_filepair_obstack, NULL);
338fe93
+      /* All their memory came just from missing_filepair_OBSTACK.  */
338fe93
+      missing_filepair_hash = NULL;
6a80c39
+    }
6a80c39
+}
6a80c39
+
6a80c39
+static void
407ebe9
+debug_print_executable_changed (void)
6a80c39
+{
338fe93
+  missing_filepair_change ();
6a80c39
+}
6a80c39
+
338fe93
+/* Notify user the file BINARY with (possibly NULL) associated separate debug
338fe93
+   information file DEBUG is missing.  DEBUG may or may not be the build-id
338fe93
+   file such as would be:
338fe93
+     /usr/lib/debug/.build-id/dd/b1d2ce632721c47bb9e8679f369e2295ce71be.debug
338fe93
+   */
338fe93
+
6a80c39
+void
338fe93
+debug_print_missing (const char *binary, const char *debug)
6a80c39
+{
6a80c39
+  size_t binary_len0 = strlen (binary) + 1;
338fe93
+  size_t debug_len0 = debug ? strlen (debug) + 1 : 0;
c030186
+  struct missing_filepair missing_filepair_find;
338fe93
+  struct missing_filepair *missing_filepair;
338fe93
+  struct missing_filepair **slot;
6a80c39
+
917a6fb
+  if (build_id_verbose < BUILD_ID_VERBOSE_FILENAMES)
917a6fb
+    return;
917a6fb
+
338fe93
+  if (missing_filepair_hash == NULL)
6a80c39
+    {
338fe93
+      obstack_init (&missing_filepair_obstack);
338fe93
+      missing_filepair_hash = htab_create_alloc (64,
338fe93
+	(hashval_t (*) (const void *)) missing_filepair_hash_func,
338fe93
+	(int (*) (const void *, const void *)) missing_filepair_eq, NULL,
338fe93
+	missing_filepair_xcalloc, NULL);
6a80c39
+    }
6a80c39
+
c030186
+  /* Use MISSING_FILEPAIR_FIND first instead of calling obstack_alloc with
c030186
+     obstack_free in the case of a (rare) match.  The problem is ALLOC_F for
c030186
+     MISSING_FILEPAIR_HASH allocates from MISSING_FILEPAIR_OBSTACK maintenance
c030186
+     structures for MISSING_FILEPAIR_HASH.  Calling obstack_free would possibly
c030186
+     not to free only MISSING_FILEPAIR but also some such structures (allocated
c030186
+     during the htab_find_slot call).  */
c030186
+
c030186
+  missing_filepair_find.binary = (char *) binary;
c030186
+  missing_filepair_find.debug = (char *) debug;
c030186
+  slot = (struct missing_filepair **) htab_find_slot (missing_filepair_hash,
c030186
+						      &missing_filepair_find,
c030186
+						      INSERT);
c030186
+
c030186
+  /* While it may be still printed duplicitely with the missing debuginfo file
c030186
+   * it is due to once printing about the binary file build-id link and once
c030186
+   * about the .debug file build-id link as both the build-id symlinks are
c030186
+   * located in the debuginfo package.  */
c030186
+
c030186
+  if (*slot != NULL)
c030186
+    return;
c030186
+
Jan Kratochvil 7306e88
+  missing_filepair = (struct missing_filepair *) obstack_alloc (&missing_filepair_obstack,
Jan Kratochvil 7306e88
+								sizeof (*missing_filepair) - 1
Jan Kratochvil 7306e88
+								+ binary_len0 + debug_len0);
338fe93
+  missing_filepair->binary = missing_filepair->data;
338fe93
+  memcpy (missing_filepair->binary, binary, binary_len0);
338fe93
+  if (debug != NULL)
338fe93
+    {
338fe93
+      missing_filepair->debug = missing_filepair->binary + binary_len0;
338fe93
+      memcpy (missing_filepair->debug, debug, debug_len0);
338fe93
+    }
338fe93
+  else
338fe93
+    missing_filepair->debug = NULL;
6a80c39
+
338fe93
+  *slot = missing_filepair;
6a80c39
+
09c22fd
+  /* We do not collect and flush these messages as each such message
09c22fd
+     already requires its own separate lines.  */
6a80c39
+
09c22fd
+  fprintf_unfiltered (gdb_stdlog,
09c22fd
+		      _("Missing separate debuginfo for %s\n"), binary);
09c22fd
+  if (debug != NULL)
eb11e3c
+    fprintf_unfiltered (gdb_stdlog, _("Try to install the hash file %s\n"),
eb11e3c
+			debug);
6a80c39
+}
6a80c39
+
Jan Kratochvil 2c55a54
 /* See build-id.h.  */
Jan Kratochvil 2c55a54
 
a5d2c85
 gdb_bfd_ref_ptr
a5d2c85
-build_id_to_debug_bfd (size_t build_id_len, const bfd_byte *build_id)
a5d2c85
+build_id_to_debug_bfd (size_t build_id_len, const bfd_byte *build_id,
a5d2c85
+		       char **link_return)
a5d2c85
 {
a5d2c85
-  return build_id_to_bfd_suffix (build_id_len, build_id, ".debug");
a5d2c85
+  return build_id_to_bfd_suffix (build_id_len, build_id, ".debug",
a5d2c85
+				 link_return);
a5d2c85
 }
a5d2c85
 
a5d2c85
 /* See build-id.h.  */
a5d2c85
 
a5d2c85
 gdb_bfd_ref_ptr
a5d2c85
-build_id_to_exec_bfd (size_t build_id_len, const bfd_byte *build_id)
a5d2c85
+build_id_to_exec_bfd (size_t build_id_len, const bfd_byte *build_id,
a5d2c85
+		      char **link_return)
a5d2c85
 {
a5d2c85
-  return build_id_to_bfd_suffix (build_id_len, build_id, "");
a5d2c85
+  return build_id_to_bfd_suffix (build_id_len, build_id, "", link_return);
a5d2c85
 }
a5d2c85
 
a5d2c85
 /* See build-id.h.  */
a5d2c85
 
2bcd68d
 std::string
8c4c91e
-find_separate_debug_file_by_buildid (struct objfile *objfile)
8c4c91e
+find_separate_debug_file_by_buildid (struct objfile *objfile,
Jan Kratochvil af2c2a5
+			gdb::unique_xmalloc_ptr<char> *build_id_filename_return)
6a80c39
 {
Jan Kratochvil ae96b4a
   const struct bfd_build_id *build_id;
4e2e788
 
4e2e788
-  build_id = build_id_bfd_get (objfile->obfd);
8c4c91e
+  if (build_id_filename_return)
8c4c91e
+    *build_id_filename_return = NULL;
8c4c91e
+
4e2e788
+  build_id = build_id_bfd_shdr_get (objfile->obfd);
4e2e788
   if (build_id != NULL)
4e2e788
     {
f637971
       if (separate_debug_file_debug)
f637971
 	printf_unfiltered (_("\nLooking for separate debug info (build-id) for "
f637971
 			     "%s\n"), objfile_name (objfile));
f637971
 
Jan Kratochvil af2c2a5
+      char *build_id_filename_cstr = NULL;
Jan Kratochvil af2c2a5
       gdb_bfd_ref_ptr abfd (build_id_to_debug_bfd (build_id->size,
Jan Kratochvil af2c2a5
-						   build_id->data));
Jan Kratochvil af2c2a5
+						    build_id->data,
a5d2c85
+	      (!build_id_filename_return ? NULL : &build_id_filename_cstr)));
Jan Kratochvil af2c2a5
+      if (build_id_filename_return)
Jan Kratochvil af2c2a5
+	{
Jan Kratochvil af2c2a5
+	  if (!build_id_filename_cstr)
Jan Kratochvil af2c2a5
+	    gdb_assert (!*build_id_filename_return);
Jan Kratochvil af2c2a5
+	  else
Jan Kratochvil af2c2a5
+	    {
Jan Kratochvil af2c2a5
+	      *build_id_filename_return = gdb::unique_xmalloc_ptr<char> (build_id_filename_cstr);
Jan Kratochvil af2c2a5
+	      build_id_filename_cstr = NULL;
Jan Kratochvil af2c2a5
+	    }
Jan Kratochvil af2c2a5
+	}
f637971
+
4e2e788
       /* Prevent looping on a stripped .debug file.  */
Jan Kratochvil 2c55a54
       if (abfd != NULL
Jan Kratochvil af2c2a5
 	  && filename_cmp (bfd_get_filename (abfd.get ()),
2c18014
@@ -223,3 +897,21 @@ find_separate_debug_file_by_buildid (struct objfile *objfile)
2bcd68d
 
2bcd68d
   return std::string ();
8c4c91e
 }
8c4c91e
+
Jan Kratochvil 2c55a54
+extern void _initialize_build_id (void);
8c4c91e
+
Jan Kratochvil 2c55a54
+void
Jan Kratochvil 2c55a54
+_initialize_build_id (void)
Jan Kratochvil 2c55a54
+{
8c4c91e
+  add_setshow_zinteger_cmd ("build-id-verbose", no_class, &build_id_verbose,
8c4c91e
+			    _("\
8c4c91e
+Set debugging level of the build-id locator."), _("\
8c4c91e
+Show debugging level of the build-id locator."), _("\
8c4c91e
+Level 1 (default) enables printing the missing debug filenames,\n\
8c4c91e
+level 2 also prints the parsing of binaries to find the identificators."),
8c4c91e
+			    NULL,
8c4c91e
+			    show_build_id_verbose,
8c4c91e
+			    &setlist, &showlist);
8c4c91e
+
2bcd68d
+  gdb::observers::executable_changed.attach (debug_print_executable_changed);
f637971
+}
f637971
diff --git a/gdb/build-id.h b/gdb/build-id.h
f637971
--- a/gdb/build-id.h
f637971
+++ b/gdb/build-id.h
0702d0d
@@ -23,9 +23,10 @@
f637971
 #include "gdb_bfd.h"
f7760f8
 #include "gdbsupport/rsp-low.h"
f637971
 
f637971
-/* Locate NT_GNU_BUILD_ID from ABFD and return its content.  */
f637971
+/* Separate debuginfo files have corrupted PHDR but SHDR is correct there.
f637971
+   Locate NT_GNU_BUILD_ID from ABFD and return its content.  */
f637971
 
f637971
-extern const struct bfd_build_id *build_id_bfd_get (bfd *abfd);
f637971
+extern const struct bfd_build_id *build_id_bfd_shdr_get (bfd *abfd);
f637971
 
f637971
 /* Return true if ABFD has NT_GNU_BUILD_ID matching the CHECK value.
f637971
    Otherwise, issue a warning and return false.  */
a5d2c85
@@ -38,21 +39,26 @@ extern int build_id_verify (bfd *abfd,
a5d2c85
    can be found, return NULL.  */
f637971
 
f637971
 extern gdb_bfd_ref_ptr build_id_to_debug_bfd (size_t build_id_len,
f637971
-					      const bfd_byte *build_id);
f637971
+					      const bfd_byte *build_id,
a5d2c85
+					      char **link_return);
f637971
+
f637971
+extern char *build_id_to_filename (const struct bfd_build_id *build_id,
f637971
+				   char **link_return);
f637971
 
a5d2c85
 /* Find and open a BFD for an executable file given a build-id.  If no BFD
a5d2c85
    can be found, return NULL.  The returned reference to the BFD must be
a5d2c85
    released by the caller.  */
a5d2c85
 
a5d2c85
 extern gdb_bfd_ref_ptr build_id_to_exec_bfd (size_t build_id_len,
a5d2c85
-					     const bfd_byte *build_id);
a5d2c85
+					     const bfd_byte *build_id,
a5d2c85
+					     char **link_return);
a5d2c85
 
f637971
 /* Find the separate debug file for OBJFILE, by using the build-id
2bcd68d
    associated with OBJFILE's BFD.  If successful, returns the file name for the
2bcd68d
    separate debug file, otherwise, return an empty string.  */
f637971
 
2bcd68d
-extern std::string find_separate_debug_file_by_buildid
2bcd68d
-  (struct objfile *objfile);
2bcd68d
+extern std::string find_separate_debug_file_by_buildid (struct objfile *objfile,
f637971
+		       gdb::unique_xmalloc_ptr<char> *build_id_filename_return);
f637971
 
0702d0d
 /* Return an hex-string representation of BUILD_ID.  */
0702d0d
 
f637971
diff --git a/gdb/coffread.c b/gdb/coffread.c
f637971
--- a/gdb/coffread.c
f637971
+++ b/gdb/coffread.c
99dc38b
@@ -709,7 +709,8 @@ coff_symfile_read (struct objfile *objfile, symfile_add_flags symfile_flags)
2bcd68d
   /* Try to add separate debug file if no symbols table found.   */
2bcd68d
   if (!objfile_has_partial_symbols (objfile))
f637971
     {
2bcd68d
-      std::string debugfile = find_separate_debug_file_by_buildid (objfile);
2bcd68d
+      std::string debugfile = find_separate_debug_file_by_buildid (objfile,
2bcd68d
+								   NULL);
f637971
 
2bcd68d
       if (debugfile.empty ())
f637971
 	debugfile = find_separate_debug_file_by_debuglink (objfile);
f637971
diff --git a/gdb/corelow.c b/gdb/corelow.c
f637971
--- a/gdb/corelow.c
f637971
+++ b/gdb/corelow.c
e90857f
@@ -22,6 +22,10 @@
e90857f
 #include <signal.h>
e90857f
 #include <fcntl.h>
e90857f
 #include "frame.h"		/* required by inferior.h */
f637971
+#include "auxv.h"
e90857f
+#include "build-id.h"
f637971
+#include "elf/common.h"
f637971
+#include "gdbcmd.h"
e90857f
 #include "inferior.h"
e90857f
 #include "infrun.h"
e90857f
 #include "symtab.h"
2c18014
@@ -362,6 +366,8 @@ add_to_thread_list (bfd *abfd, asection *asect, void *reg_sect_arg)
2c18014
     switch_to_thread (thr);			/* Yes, make it current.  */
f637971
 }
f637971
 
0a2f2a5
+static bool build_id_core_loads = true;
f637971
+
2bcd68d
 /* Issue a message saying we have no core to debug, if FROM_TTY.  */
Jan Kratochvil 2f7f533
 
f637971
 static void
2c18014
@@ -398,19 +404,25 @@ core_file_command (const char *filename, int from_tty)
a5d2c85
 static void
a5d2c85
 locate_exec_from_corefile_build_id (bfd *abfd, int from_tty)
a5d2c85
 {
a5d2c85
-  const bfd_build_id *build_id = build_id_bfd_get (abfd);
a5d2c85
+  const bfd_build_id *build_id = build_id_bfd_shdr_get (abfd);
a5d2c85
   if (build_id == nullptr)
a5d2c85
     return;
a5d2c85
 
a5d2c85
+  char *build_id_filename;
a5d2c85
   gdb_bfd_ref_ptr execbfd
a5d2c85
-    = build_id_to_exec_bfd (build_id->size, build_id->data);
a5d2c85
+    = build_id_to_exec_bfd (build_id->size, build_id->data,
a5d2c85
+			    &build_id_filename);
Jan Kratochvil 2f7f533
 
a5d2c85
   if (execbfd != nullptr)
a5d2c85
     {
a5d2c85
       exec_file_attach (bfd_get_filename (execbfd.get ()), from_tty);
a5d2c85
       symbol_file_add_main (bfd_get_filename (execbfd.get ()),
a5d2c85
 			    symfile_add_flag (from_tty ? SYMFILE_VERBOSE : 0));
a5d2c85
+      if (symfile_objfile != NULL)
a5d2c85
+	symfile_objfile->flags |= OBJF_BUILD_ID_CORE_LOADED;
a5d2c85
     }
a5d2c85
+  else
a5d2c85
+    debug_print_missing (BUILD_ID_MAIN_EXECUTABLE_FILENAME, build_id_filename);
a5d2c85
 }
Jan Kratochvil 2f7f533
 
a5d2c85
 /* See gdbcore.h.  */
2c18014
@@ -1189,4 +1201,11 @@ _initialize_corelow ()
2c18014
            maintenance_print_core_file_backed_mappings,
2c18014
 	   _("Print core file's file-backed mappings."),
2c18014
 	   &maintenanceprintlist);
4e2e788
+
f637971
+  add_setshow_boolean_cmd ("build-id-core-loads", class_files,
f637971
+			   &build_id_core_loads, _("\
f637971
+Set whether CORE-FILE loads the build-id associated files automatically."), _("\
f637971
+Show whether CORE-FILE loads the build-id associated files automatically."),
f637971
+			   NULL, NULL, NULL,
f637971
+			   &setlist, &showlist);
f637971
 }
f637971
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
f637971
--- a/gdb/doc/gdb.texinfo
f637971
+++ b/gdb/doc/gdb.texinfo
2c18014
@@ -21074,6 +21074,27 @@ information files.
Jan Kratochvil 2c55a54
 
f637971
 @end table
c499105
 
f637971
+You can also adjust the current verbosity of the @dfn{build id} locating.
f637971
+
f637971
+@table @code
f637971
+
f637971
+@kindex set build-id-verbose
f637971
+@item set build-id-verbose 0
f637971
+No additional messages are printed.
f637971
+
f637971
+@item set build-id-verbose 1
f637971
+Missing separate debug filenames are printed.
f637971
+
f637971
+@item set build-id-verbose 2
f637971
+Missing separate debug filenames are printed and also all the parsing of the
f637971
+binaries to find their @dfn{build id} content is printed.
f637971
+
f637971
+@kindex show build-id-verbose
f637971
+@item show build-id-verbose
f637971
+Show the current verbosity value for the @dfn{build id} content locating.
f637971
+
f637971
+@end table
f637971
+
f637971
 @cindex @code{.gnu_debuglink} sections
f637971
 @cindex debug link sections
f637971
 A debug link is a special section of the executable file named
2c18014
diff --git a/gdb/dwarf2/index-cache.c b/gdb/dwarf2/index-cache.c
2c18014
--- a/gdb/dwarf2/index-cache.c
2c18014
+++ b/gdb/dwarf2/index-cache.c
2c18014
@@ -95,7 +95,7 @@ index_cache::store (dwarf2_per_objfile *per_objfile)
0702d0d
     return;
0702d0d
 
292cb41
   /* Get build id of objfile.  */
0702d0d
-  const bfd_build_id *build_id = build_id_bfd_get (obj->obfd);
0702d0d
+  const bfd_build_id *build_id = build_id_bfd_shdr_get (obj->obfd);
0702d0d
   if (build_id == nullptr)
0702d0d
     {
0702d0d
       if (debug_index_cache)
2c18014
@@ -113,7 +113,8 @@ index_cache::store (dwarf2_per_objfile *per_objfile)
292cb41
 
292cb41
   if (dwz != nullptr)
292cb41
     {
292cb41
-      const bfd_build_id *dwz_build_id = build_id_bfd_get (dwz->dwz_bfd.get ());
292cb41
+      const bfd_build_id *dwz_build_id
292cb41
+	= build_id_bfd_shdr_get (dwz->dwz_bfd.get ());
292cb41
 
292cb41
       if (dwz_build_id == nullptr)
292cb41
 	{
2c18014
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
2c18014
--- a/gdb/dwarf2/read.c
2c18014
+++ b/gdb/dwarf2/read.c
362037e
@@ -2225,7 +2225,7 @@ dwarf2_get_dwz_file (dwarf2_per_bfd *per_bfd)
d5fb1cc
     }
580e056
 
Jan Kratochvil 2c55a54
   if (dwz_bfd == NULL)
Jan Kratochvil 2c55a54
-    dwz_bfd = build_id_to_debug_bfd (buildid_len, buildid);
a5d2c85
+    dwz_bfd = build_id_to_debug_bfd (buildid_len, buildid, NULL);
Jan Kratochvil 5387893
 
2c18014
   if (dwz_bfd == nullptr)
2c18014
     {
362037e
@@ -5989,7 +5989,7 @@ get_gdb_index_contents_from_section (objfile *obj, T *section_owner)
0702d0d
 static gdb::array_view<const gdb_byte>
2c18014
 get_gdb_index_contents_from_cache (objfile *obj, dwarf2_per_bfd *dwarf2_per_bfd)
0702d0d
 {
0702d0d
-  const bfd_build_id *build_id = build_id_bfd_get (obj->obfd);
0702d0d
+  const bfd_build_id *build_id = build_id_bfd_shdr_get (obj->obfd);
0702d0d
   if (build_id == nullptr)
0702d0d
     return {};
0702d0d
 
362037e
@@ -6002,7 +6002,7 @@ get_gdb_index_contents_from_cache (objfile *obj, dwarf2_per_bfd *dwarf2_per_bfd)
0702d0d
 static gdb::array_view<const gdb_byte>
0702d0d
 get_gdb_index_contents_from_cache_dwz (objfile *obj, dwz_file *dwz)
0702d0d
 {
0702d0d
-  const bfd_build_id *build_id = build_id_bfd_get (dwz->dwz_bfd.get ());
0702d0d
+  const bfd_build_id *build_id = build_id_bfd_shdr_get (dwz->dwz_bfd.get ());
0702d0d
   if (build_id == nullptr)
0702d0d
     return {};
0702d0d
 
f637971
diff --git a/gdb/elfread.c b/gdb/elfread.c
f637971
--- a/gdb/elfread.c
f637971
+++ b/gdb/elfread.c
2c18014
@@ -1298,7 +1298,9 @@ elf_symfile_read (struct objfile *objfile, symfile_add_flags symfile_flags)
f637971
 	   && objfile->separate_debug_objfile == NULL
f637971
 	   && objfile->separate_debug_objfile_backlink == NULL)
f637971
     {
2bcd68d
-      std::string debugfile = find_separate_debug_file_by_buildid (objfile);
f637971
+      gdb::unique_xmalloc_ptr<char> build_id_filename;
2bcd68d
+      std::string debugfile
2bcd68d
+	= find_separate_debug_file_by_buildid (objfile, &build_id_filename);
f637971
 
2bcd68d
       if (debugfile.empty ())
2bcd68d
 	debugfile = find_separate_debug_file_by_debuglink (objfile);
6c8ccd6
@@ -1313,7 +1315,7 @@ elf_symfile_read (struct objfile *objfile, symfile_add_flags symfile_flags)
2c18014
       else
2c18014
 	{
2c18014
 	  has_dwarf2 = false;
2c18014
-	  const struct bfd_build_id *build_id = build_id_bfd_get (objfile->obfd);
2c18014
+	  const struct bfd_build_id *build_id = build_id_bfd_shdr_get (objfile->obfd);
2c18014
 
2c18014
 	  if (build_id != nullptr)
2c18014
 	    {
6c8ccd6
@@ -1338,6 +1340,10 @@ elf_symfile_read (struct objfile *objfile, symfile_add_flags symfile_flags)
6c8ccd6
 		      has_dwarf2 = true;
6c8ccd6
 		    }
6c8ccd6
 		}
6c8ccd6
+		/* Check if any separate debug info has been extracted out.  */
6c8ccd6
+		else if (bfd_get_section_by_name (objfile->obfd, ".gnu_debuglink")
6c8ccd6
+			 != NULL)
6c8ccd6
+		  debug_print_missing (objfile_name (objfile), build_id_filename.get ());
6c8ccd6
 	    }
6c8ccd6
 	}
6c8ccd6
     }
2c18014
diff --git a/gdb/exec.c b/gdb/exec.c
2c18014
--- a/gdb/exec.c
2c18014
+++ b/gdb/exec.c
2c18014
@@ -264,7 +264,7 @@ validate_exec_file (int from_tty)
2c18014
   reopen_exec_file ();
2c18014
   current_exec_file = get_exec_file (0);
2c18014
 
2c18014
-  const bfd_build_id *exec_file_build_id = build_id_bfd_get (exec_bfd);
2c18014
+  const bfd_build_id *exec_file_build_id = build_id_bfd_shdr_get (exec_bfd);
2c18014
   if (exec_file_build_id != nullptr)
2c18014
     {
2c18014
       /* Prepend the target prefix, to force gdb_bfd_open to open the
2c18014
@@ -277,7 +277,7 @@ validate_exec_file (int from_tty)
2c18014
       if (abfd != nullptr)
2c18014
 	{
2c18014
 	  const bfd_build_id *target_exec_file_build_id
2c18014
-	    = build_id_bfd_get (abfd.get ());
2c18014
+	    = build_id_bfd_shdr_get (abfd.get ());
f637971
 
2c18014
 	  if (target_exec_file_build_id != nullptr)
2c18014
 	    {
f637971
diff --git a/gdb/objfiles.h b/gdb/objfiles.h
f637971
--- a/gdb/objfiles.h
f637971
+++ b/gdb/objfiles.h
2c18014
@@ -714,6 +714,10 @@ struct objfile
2c18014
   bool skip_jit_symbol_lookup = false;
f637971
 };
f637971
 
f637971
+/* This file was loaded according to the BUILD_ID_CORE_LOADS rules.  */
f637971
+
f637971
+#define OBJF_BUILD_ID_CORE_LOADED static_cast<enum objfile_flag>(1 << 12)
f637971
+
2c18014
 /* A deleter for objfile.  */
f637971
 
2c18014
 struct objfile_deleter
f637971
diff --git a/gdb/python/py-objfile.c b/gdb/python/py-objfile.c
f637971
--- a/gdb/python/py-objfile.c
f637971
+++ b/gdb/python/py-objfile.c
b1bf7bc
@@ -132,7 +132,7 @@ objfpy_get_build_id (PyObject *self, void *closure)
Jan Kratochvil 2f7f533
 
e90857f
   try
Jan Kratochvil 2f7f533
     {
Jan Kratochvil 2f7f533
-      build_id = build_id_bfd_get (objfile->obfd);
Jan Kratochvil 2f7f533
+      build_id = build_id_bfd_shdr_get (objfile->obfd);
Jan Kratochvil 2f7f533
     }
e90857f
   catch (const gdb_exception &except)
Jan Kratochvil 32f92b2
     {
2f578f5
@@ -600,7 +600,7 @@ objfpy_lookup_objfile_by_build_id (const char *build_id)
Jan Kratochvil 2f7f533
       /* Don't return separate debug files.  */
Jan Kratochvil 2f7f533
       if (objfile->separate_debug_objfile_backlink != NULL)
Jan Kratochvil 2f7f533
 	continue;
Jan Kratochvil 2f7f533
-      obfd_build_id = build_id_bfd_get (objfile->obfd);
Jan Kratochvil 2f7f533
+      obfd_build_id = build_id_bfd_shdr_get (objfile->obfd);
Jan Kratochvil 2f7f533
       if (obfd_build_id == NULL)
Jan Kratochvil 2f7f533
 	continue;
Jan Kratochvil 2f7f533
       if (objfpy_build_id_matches (obfd_build_id, build_id))
f637971
diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c
f637971
--- a/gdb/solib-svr4.c
f637971
+++ b/gdb/solib-svr4.c
f637971
@@ -45,6 +45,7 @@
f637971
 #include "auxv.h"
f637971
 #include "gdb_bfd.h"
f637971
 #include "probe.h"
f637971
+#include "build-id.h"
Jan Kratochvil ae96b4a
 
f637971
 static struct link_map_offsets *svr4_fetch_link_map_offsets (void);
f637971
 static int svr4_have_link_map_offsets (void);
2c18014
@@ -1338,9 +1339,51 @@ svr4_read_so_list (svr4_info *info, CORE_ADDR lm, CORE_ADDR prev_lm,
f637971
 	  continue;
f637971
 	}
Jan Kratochvil ae96b4a
 
2bcd68d
-      strncpy (newobj->so_name, buffer.get (), SO_NAME_MAX_PATH_SIZE - 1);
f637971
-      newobj->so_name[SO_NAME_MAX_PATH_SIZE - 1] = '\0';
f637971
-      strcpy (newobj->so_original_name, newobj->so_name);
f637971
+      {
f637971
+	struct bfd_build_id *build_id;
f637971
+
2bcd68d
+	strncpy (newobj->so_original_name, buffer.get (), SO_NAME_MAX_PATH_SIZE - 1);
f637971
+	newobj->so_original_name[SO_NAME_MAX_PATH_SIZE - 1] = '\0';
f637971
+	/* May get overwritten below.  */
f637971
+	strcpy (newobj->so_name, newobj->so_original_name);
f637971
+
2bcd68d
+	build_id = build_id_addr_get (((lm_info_svr4 *) newobj->lm_info)->l_ld);
f637971
+	if (build_id != NULL)
f637971
+	  {
f637971
+	    char *name, *build_id_filename;
f637971
+
f637971
+	    /* Missing the build-id matching separate debug info file
f637971
+	       would be handled while SO_NAME gets loaded.  */
f637971
+	    name = build_id_to_filename (build_id, &build_id_filename);
f637971
+	    if (name != NULL)
f637971
+	      {
f637971
+		strncpy (newobj->so_name, name, SO_NAME_MAX_PATH_SIZE - 1);
f637971
+		newobj->so_name[SO_NAME_MAX_PATH_SIZE - 1] = '\0';
f637971
+		xfree (name);
f637971
+	      }
f637971
+	    else
f637971
+	      {
f637971
+		debug_print_missing (newobj->so_name, build_id_filename);
f637971
+
f637971
+		/* In the case the main executable was found according to
f637971
+		   its build-id (from a core file) prevent loading
f637971
+		   a different build of a library with accidentally the
f637971
+		   same SO_NAME.
f637971
+
f637971
+		   It suppresses bogus backtraces (and prints "??" there
f637971
+		   instead) if the on-disk files no longer match the
f637971
+		   running program version.  */
f637971
+
f637971
+		if (symfile_objfile != NULL
f637971
+		    && (symfile_objfile->flags
f637971
+			& OBJF_BUILD_ID_CORE_LOADED) != 0)
f637971
+		  newobj->so_name[0] = 0;
f637971
+	      }
f637971
+
f637971
+	    xfree (build_id_filename);
f637971
+	    xfree (build_id);
f637971
+	  }
f637971
+      }
f637971
 
f637971
       /* If this entry has no name, or its name matches the name
2bcd68d
 	 for the main executable, don't include it in the list.  */
2c18014
diff --git a/gdb/source.c b/gdb/source.c
2c18014
--- a/gdb/source.c
2c18014
+++ b/gdb/source.c
2c18014
@@ -1165,7 +1165,7 @@ open_source_file (struct symtab *s)
2c18014
 	      srcpath += s->filename;
2c18014
 	    }
2c18014
 
2c18014
-	  const struct bfd_build_id *build_id = build_id_bfd_get (ofp->obfd);
2c18014
+	  const struct bfd_build_id *build_id = build_id_bfd_shdr_get (ofp->obfd);
2c18014
 
2c18014
 	  /* Query debuginfod for the source file.  */
2c18014
 	  if (build_id != nullptr && !srcpath.empty ())
f637971
diff --git a/gdb/symfile.h b/gdb/symfile.h
f637971
--- a/gdb/symfile.h
f637971
+++ b/gdb/symfile.h
2c18014
@@ -550,12 +550,18 @@ void expand_symtabs_matching
f637971
 void map_symbol_filenames (symbol_filename_ftype *fun, void *data,
f637971
 			   int need_fullname);
f637971
 
f7760f8
+
f7760f8
 /* Target-agnostic function to load the sections of an executable into memory.
f7760f8
 
f7760f8
    ARGS should be in the form "EXECUTABLE [OFFSET]", where OFFSET is an
f7760f8
    optional offset to apply to each section.  */
f7760f8
 extern void generic_load (const char *args, int from_tty);
f7760f8
 
f637971
+/* build-id support.  */
f637971
+extern struct bfd_build_id *build_id_addr_get (CORE_ADDR addr);
f637971
+extern void debug_print_missing (const char *binary, const char *debug);
2c18014
+#define BUILD_ID_MAIN_EXECUTABLE_FILENAME _("the main executable file")
f637971
+
f637971
 /* From dwarf2read.c */
f637971
 
f637971
 /* Names for a dwarf2 debugging section.  The field NORMAL is the normal
f637971
diff --git a/gdb/testsuite/gdb.base/corefile.exp b/gdb/testsuite/gdb.base/corefile.exp
f637971
--- a/gdb/testsuite/gdb.base/corefile.exp
f637971
+++ b/gdb/testsuite/gdb.base/corefile.exp
2c18014
@@ -343,3 +343,33 @@ gdb_test_multiple "core-file $corefile" $test {
f637971
 	pass $test
f637971
     }
f637971
 }
f637971
+
f637971
+
f637971
+# Test auto-loading of binary files through build-id from the core file.
f637971
+set buildid [build_id_debug_filename_get $binfile]
f637971
+set wholetest "binfile found by build-id"
f637971
+if {$buildid == ""} {
f637971
+    untested "$wholetest (binary has no build-id)"
f637971
+} else {
f637971
+    gdb_exit
f637971
+    gdb_start
f637971
+
f637971
+    regsub {\.debug$} $buildid {} buildid
f637971
+    set debugdir [standard_output_file ${testfile}-debugdir]
f637971
+    file delete -force -- $debugdir
f637971
+    file mkdir $debugdir/[file dirname $buildid]
f637971
+    file copy $binfile $debugdir/$buildid
f637971
+
f637971
+    set test "show debug-file-directory"
f637971
+    gdb_test_multiple $test $test {
f637971
+	-re "The directory where separate debug symbols are searched for is \"(.*)\"\\.\r\n$gdb_prompt $" {
f637971
+	    set debugdir_orig $expect_out(1,string)
f637971
+	    pass $test
f637971
+	}
f637971
+    }
f637971
+    gdb_test_no_output "set debug-file-directory $debugdir:$debugdir_orig" "set debug-file-directory"
f637971
+    gdb_test "show build-id-core-loads" {Whether CORE-FILE loads the build-id associated files automatically is on\.}
f637971
+    gdb_test "core-file $corefile" "\r\nProgram terminated with .*" "core-file without executable"
f637971
+    gdb_test "info files" "Local exec file:\r\n\[ \t\]*`[string_to_regexp $debugdir/$buildid]', file type .*"
f637971
+    pass $wholetest
f637971
+}
f637971
diff --git a/gdb/testsuite/gdb.base/new-ui-pending-input.exp b/gdb/testsuite/gdb.base/new-ui-pending-input.exp
f637971
--- a/gdb/testsuite/gdb.base/new-ui-pending-input.exp
f637971
+++ b/gdb/testsuite/gdb.base/new-ui-pending-input.exp
f637971
@@ -62,6 +62,7 @@ proc test_command_line_new_ui_pending_input {} {
f637971
     set options ""
f637971
     append options " -iex \"set height 0\""
f637971
     append options " -iex \"set width 0\""
f637971
+    append options " -iex \"set build-id-verbose 0\""
f637971
     append options " -iex \"new-ui console $extra_tty_name\""
f637971
     append options " -ex \"b $bpline\""
f637971
     append options " -ex \"run\""
f637971
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
f637971
--- a/gdb/testsuite/lib/gdb.exp
f637971
+++ b/gdb/testsuite/lib/gdb.exp
2c18014
@@ -2011,6 +2011,17 @@ proc default_gdb_start { } {
f637971
 	}
f637971
     }
f0a9ac3
 
f637971
+    # Turn off the missing warnings as the testsuite does not expect it.
f637971
+    send_gdb "set build-id-verbose 0\n"
f637971
+    gdb_expect 10 {
f637971
+	-re "$gdb_prompt $" {
f637971
+	    verbose "Disabled the missing debug infos warnings." 2
f637971
+	}
f637971
+	timeout {
f637971
+	    warning "Could not disable the missing debug infos warnings.."
f637971
+	}
f637971
+    }
f0a9ac3
+
f0a9ac3
     gdb_debug_init
f637971
     return 0
f637971
 }
f637971
diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-support.exp
f637971
--- a/gdb/testsuite/lib/mi-support.exp
f637971
+++ b/gdb/testsuite/lib/mi-support.exp
2c18014
@@ -308,6 +308,16 @@ proc default_mi_gdb_start { args } {
f637971
 	    warning "Couldn't set the width to 0."
f637971
 	}
f637971
     }
f637971
+    # Turn off the missing warnings as the testsuite does not expect it.
f637971
+    send_gdb "190-gdb-set build-id-verbose 0\n"
f637971
+    gdb_expect 10 {
f637971
+	-re ".*190-gdb-set build-id-verbose 0\r\n190\\\^done\r\n$mi_gdb_prompt$" {
f637971
+	    verbose "Disabled the missing debug infos warnings." 2
f637971
+	}
f637971
+	timeout {
f637971
+	    warning "Could not disable the missing debug infos warnings.."
f637971
+	}
f637971
+    }
f637971
 
f637971
     if { $separate_inferior_pty } {
f637971
 	mi_create_inferior_pty